From: Nicholas Clark <nick@ccl4.org>
Date: Sat, 17 Sep 2005 18:59:37 +0000 (+0000)
Subject: Add reduce duplication in sv_setsv_flags to TODO
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=077e3186237ebd2ebc94ad394d02255c49120a8a;hp=45f723e18cecdd96fecb0ec8aac8d7af7437f6f7;p=p5sagit%2Fp5-mst-13.2.git

Add reduce duplication in sv_setsv_flags to TODO

p4raw-id: //depot/perl@25446
---

diff --git a/pod/perltodo.pod b/pod/perltodo.pod
index 4fec644..3e925e3 100644
--- a/pod/perltodo.pod
+++ b/pod/perltodo.pod
@@ -320,6 +320,18 @@ necessary to do something like
 although C<long double> might not be the only type to add to the padding
 union.
 
+=head2 reduce duplication in sv_setsv_flags
+
+C<Perl_sv_setsv_flags> has a comment
+C</* There's a lot of redundancy below but we're going for speed here */>
+
+Whilst this was true 10 years ago, the growing disparity between RAM and CPU
+speeds mean that the trade offs have changed. In addition, the duplicate code
+adds to the maintenance burden. It would be good to see how much of the
+redundancy can be pruned, particular in the less common paths. (Profiling
+tools at the ready...). For example, why does the test for
+"Can't redefine active sort subroutine" need to occur in two places?
+