From: Nicholas Clark Date: Wed, 26 Dec 2001 19:19:47 +0000 (+0000) Subject: Re: [PATCH] Re: [ PATCH ] Cygwin groups.t (PLEASE CHECK) X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=06bcfee821c1531480dd1ac6ca26709a32b7e93a;p=p5sagit%2Fp5-mst-13.2.git Re: [PATCH] Re: [ PATCH ] Cygwin groups.t (PLEASE CHECK) Message-ID: <20011226191946.K48842@plum.flirble.org> Use report_evil_fh(). p4raw-id: //depot/perl@13892 --- diff --git a/doio.c b/doio.c index 4e977b7..32427eb 100644 --- a/doio.c +++ b/doio.c @@ -951,21 +951,7 @@ Perl_do_eof(pTHX_ GV *gv) if (!io) return TRUE; else if (ckWARN(WARN_IO) && (IoTYPE(io) == IoTYPE_WRONLY)) - { - /* integrate to report_evil_fh()? */ - char *name = NULL; - if (isGV(gv)) { - SV* sv = sv_newmortal(); - gv_efullname4(sv, gv, Nullch, FALSE); - name = SvPV_nolen(sv); - } - if (name && *name) - Perl_warner(aTHX_ WARN_IO, - "Filehandle %s opened only for output", name); - else - Perl_warner(aTHX_ WARN_IO, - "Filehandle opened only for output"); - } + report_evil_fh(gv, io, OP_phoney_OUTPUT_ONLY); while (IoIFP(io)) {