From: Rick Delaney <rick@consumercontact.com>
Date: Tue, 6 Nov 2007 19:18:45 +0000 (-0500)
Subject: Re: [perl #47195] $1 suddenly tainted after regexp on utf-8 string
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=0008a298a756beba82d3333fc66460546e961c07;p=p5sagit%2Fp5-mst-13.2.git

Re: [perl #47195] $1 suddenly tainted after regexp on utf-8 string
Message-ID: <20071107001845.GA21000@bort.ca>

[plus remove the TODO from the now passing test]

p4raw-id: //depot/perl@32236
---

diff --git a/regexec.c b/regexec.c
index 3e42f58..1b9fca1 100644
--- a/regexec.c
+++ b/regexec.c
@@ -5405,8 +5405,8 @@ S_regrepeat(pTHX_ const regexp *prog, const regnode *p, I32 max, int depth)
 	} else {
 	    while (scan < loceol && !isSPACE(*scan))
 		scan++;
-	    break;
 	}
+	break;
     case NSPACEL:
 	PL_reg_flags |= RF_tainted;
 	if (do_utf8) {
diff --git a/t/op/taint.t b/t/op/taint.t
index d33b66c..bb23844 100755
--- a/t/op/taint.t
+++ b/t/op/taint.t
@@ -1236,7 +1236,6 @@ foreach my $ord (78, 163, 256) {
     chop $line;
     is($line, 'A1');
     $line =~ /(A\S*)/;
-    local $::TODO = "Bug for UTF-8 not fixed yet" if $ord > 255;
     ok(!tainted($1), "\\S match with chr $ord");
 }