Change 30034 wasn't enough to silence the warnings - also need to
Nicholas Clark [Sat, 27 Jan 2007 22:48:39 +0000 (22:48 +0000)]
pass a never-NULL parameter to newPADOP from newGVOP

p4raw-id: //depot/perl@30043

op.c

diff --git a/op.c b/op.c
index 8e3e5f8..97cebc0 100644 (file)
--- a/op.c
+++ b/op.c
@@ -3452,9 +3452,9 @@ Perl_newGVOP(pTHX_ I32 type, I32 flags, GV *gv)
     assert(gv);
 #ifdef USE_ITHREADS
     GvIN_PAD_on(gv);
-    return newPADOP(type, flags, SvREFCNT_inc_simple(gv));
+    return newPADOP(type, flags, SvREFCNT_inc_simple_NN(gv));
 #else
-    return newSVOP(type, flags, SvREFCNT_inc_simple(gv));
+    return newSVOP(type, flags, SvREFCNT_inc_simple_NN(gv));
 #endif
 }