First hack at factoring the strategy out, broke the config munging test..

diff --git a/lib/CatalystX/DynamicComponent/ModelToControllerReflector.pm b/lib/CatalystX/DynamicComponent/ModelToControllerReflector.pm
index c343816..4fade17 100644 (file)
--- a/lib/CatalystX/DynamicComponent/ModelToControllerReflector.pm
+++ b/lib/CatalystX/DynamicComponent/ModelToControllerReflector.pm
@@ -1,8 +1,8 @@
 package CatalystX::DynamicComponent::ModelToControllerReflector;
 use Moose::Role;
 use Moose::Util qw/does_role/;
-use List::MoreUtils qw/uniq/;
-use Moose::Autobox;
+use MooseX::Types::Moose qw/Str/;
+use Moose::Util::TypeConstraints;
 use namespace::autoclean;
 
 my $mangle_attributes_on_generated_methods = sub {
@@ -31,6 +31,9 @@ sub _setup_dynamic_controllers {
     }
 }
 
+my $interface = 'CatalystX::DynamicComponent::ModelToControllerReflector::Strategy';
+role_type $interface;
+
 sub _reflect_model_to_controller {
     my ( $app, $model_name, $model ) = @_;
 
@@ -47,16 +50,18 @@ sub _reflect_model_to_controller {
 
     my %controller_methods;
     # FIXME - Abstract this strategy crap out.
+
+    my $strategy = $app->config->{'CatalystX::DynamicComponent::ModelToControllerReflector'}{'reflection_strategy'} || 'InterfaceRoles';
+    $strategy = "CatalystX::DynamicComponent::ModelToControllerReflector::Strategy::$strategy";
+    Class::MOP::load_class($strategy);
+    $strategy->new;
+
     my $model_methods = $model->meta->get_method_map;
-    my $interface_roles = [ uniq( map { exists $_->{interface_roles} ? $_->{interface_roles}->flatten : () } $app->config->{$model_name}, $app->config->{'CatalystX::DynamicComponent::ModelToControllerReflector'} ) ];
-    
-    for my $interface_role (@$interface_roles) {
-            for my $required_method ($interface_role->meta->get_required_method_list) {
-                    # Note need to pass model name, as the method actually comes from
-                    # the underlying model class, not the Catalyst shim class we autogenerated.
-                    $controller_methods{$required_method} = 
-                         $app->generate_reflected_controller_action_method($suffix, $model_methods->{$required_method})
-            }
+    foreach my $method_name ( $strategy->get_reflected_method_list($app, $model->meta) ) {
+        # Note need to pass model name, as the method actually comes from
+        # the underlying model class, not the Catalyst shim class we autogenerated.
+        $controller_methods{$method_name} = 
+             $app->generate_reflected_controller_action_method($suffix, $model_methods->{$method_name})
     }
 
     # Shallow copy so we don't stuff method refs in config

diff --git a/lib/CatalystX/DynamicComponent/ModelToControllerReflector/Strategy.pm b/lib/CatalystX/DynamicComponent/ModelToControllerReflector/Strategy.pm
new file mode 100644 (file)
index 0000000..ce14199
--- /dev/null
+++ b/lib/CatalystX/DynamicComponent/ModelToControllerReflector/Strategy.pm
@@ -0,0 +1,8 @@
+package CatalystX::DynamicComponent::ModelToControllerReflector::Strategy;
+use Moose::Role;
+use namespace::autoclean;
+
+requires 'get_reflected_method_list';
+
+1;
+

diff --git a/lib/CatalystX/DynamicComponent/ModelToControllerReflector/Strategy/InterfaceRoles.pm b/lib/CatalystX/DynamicComponent/ModelToControllerReflector/Strategy/InterfaceRoles.pm
new file mode 100644 (file)
index 0000000..5beb1ae
--- /dev/null
+++ b/lib/CatalystX/DynamicComponent/ModelToControllerReflector/Strategy/InterfaceRoles.pm
@@ -0,0 +1,19 @@
+package CatalystX::DynamicComponent::ModelToControllerReflector::Strategy::InterfaceRoles;
+use Moose;
+use MooseX::Types::Moose qw/HashRef/;
+use Moose::Autobox;
+use List::MoreUtils qw/uniq/;
+use namespace::autoclean;
+
+with 'CatalystX::DynamicComponent::ModelToControllerReflector::Strategy';
+
+sub get_reflected_method_list {;
+    my ($self, $app, $model_meta) = @_;
+    my $model_name = $model_meta->name;
+    my $interface_roles = [ uniq( map { exists $_->{interface_roles} ? $_->{interface_roles}->flatten : () } $app->config->{$model_name}, $app->config->{'CatalystX::DynamicComponent::ModelToControllerReflector'} ) ];
+
+    map { $_->meta->get_required_method_list } @$interface_roles;
+}
+
+__PACKAGE__->meta->make_immutable;
+