perlbug reports "Message sent" even when it hasn't
Tim Bunce (via RT) [Wed, 25 Nov 2009 11:02:24 +0000 (03:02 -0800)]
perlbug doesn't check the return status of Mail::Send and so reports
"Message sent" even if it hasn't:

utils/perlbug.PL

index 8862a94..c015e25 100644 (file)
@@ -1134,7 +1134,7 @@ sub _send_message_mailsend {
     open(REP, "<$filename") or die "Couldn't open '$filename': $!\n";
     while (<REP>) { print $fh $_ }
     close(REP) or die "Error closing $filename: $!";
-    $fh->close;
+    $fh->close or die "Error sending mail: $!";
 
     print "\nMessage sent.\n";
 }