Re: [ID 20010621.007] readline() not quite as equal as <>

Message-ID: <20010625234545.A5022@lustre.linux.in>

p4raw-id: //depot/perl@10932

diff --git a/lib/overload.t b/lib/overload.t
index f98f0c4..d075062 100644 (file)
--- a/lib/overload.t
+++ b/lib/overload.t
@@ -729,7 +729,7 @@ else {
   $iter = iterator->new(5);
   test scalar <${iter}>, '5';  # 176
   $acc = '';
-  $acc .= " $out" while $out = <${iter}>;
+  $acc .= " $out" while $out = <$iter>;
   test $acc, ' 4 3 2 1 0';     # 177
 }
 {

diff --git a/opcode.h b/opcode.h
index e706dff..28f1345 100644 (file)
--- a/opcode.h
+++ b/opcode.h
@@ -1478,7 +1478,7 @@ EXT U32 PL_opargs[] = {
        0x00122804,     /* bless */
        0x00001608,     /* backtick */
        0x00012808,     /* glob */
-       0x00001608,     /* readline */
+       0x0001d608,     /* readline */
        0x00001608,     /* rcatline */
        0x00002204,     /* regcmaybe */
        0x00002204,     /* regcreset */

diff --git a/opcode.pl b/opcode.pl
index 8defa67..4053671 100755 (executable)
--- a/opcode.pl
+++ b/opcode.pl
@@ -444,7 +444,7 @@ bless               bless                   ck_fun          s@      S S?
 backtick       quoted execution (``, qx)       ck_open         t%      
 # glob defaults its first arg to $_
 glob           glob                    ck_glob         t@      S?
-readline       <HANDLE>                ck_fun          t%      F
+readline       <HANDLE>                ck_null         t%      F?
 rcatline       append I/O operator     ck_null         t%      
 
 # Bindable operators.

diff --git a/t/op/flip.t b/t/op/flip.t
index e2d0913..99b22ef 100755 (executable)
--- a/t/op/flip.t
+++ b/t/op/flip.t
@@ -32,5 +32,5 @@ if (($x...$x) eq "1") {print "ok 9\n";} else {print "not ok 9\n";}
     # coredump reported in bug 20001018.008
     readline(UNKNOWN);
     $. = 1;
-    print "ok 10\n" if 1 .. 10;
+    print "ok 10\n" unless 1 .. 10;
 }