Fix fcgi_streambuf::underflow() such that when there is no buffer

the character isn't removed.  AIDA Shinra <shinra@j10n.org>

Modified Files:README libfcgi/fcgio.cpp

diff --git a/README b/README
index 57a140d..f61a269 100755 (executable)
--- a/README
+++ b/README
@@ -1,7 +1,7 @@
 FastCGI Developer's Kit README
 ------------------------------
 
-    $Id: README,v 1.22 2003/06/22 00:16:45 robs Exp $
+    $Id: README,v 1.23 2003/06/22 00:51:26 robs Exp $
     Copyright (c) 1996 Open Market, Inc.
     See the file "LICENSE.TERMS" for information on usage and redistribution
     of this file, and for a DISCLAIMER OF ALL WARRANTIES.
@@ -30,6 +30,9 @@ on http://fastcgi.com/.
 
 2.4.1
 
+ *) Fix fcgi_streambuf::underflow() such that when there is no buffer
+    the character isn't removed.  AIDA Shinra <shinra@j10n.org>
+ 
  *) Add attach() and detach() support.
 
 

diff --git a/libfcgi/fcgio.cpp b/libfcgi/fcgio.cpp
index 95e28ca..5a54c11 100644 (file)
--- a/libfcgi/fcgio.cpp
+++ b/libfcgi/fcgio.cpp
@@ -1,5 +1,5 @@
 //
-// $Id: fcgio.cpp,v 1.13 2002/02/24 20:12:22 robs Exp $
+// $Id: fcgio.cpp,v 1.14 2003/06/22 00:51:27 robs Exp $
 //
 // Allows you communicate with FastCGI streams using C++ iostreams
 //
@@ -91,12 +91,18 @@ int fcgi_streambuf::sync()
 // uflow() removes the char, underflow() doesn't
 int fcgi_streambuf::uflow() 
 {
-    int rv = underflow();
-    if (this->bufsize) gbump(1);
-    return rv;
+    if (this->bufsize)
+    {
+        int c = underflow();        
+        gbump(1);
+        return c;
+    }
+    else
+    {
+        return FCGX_GetChar(this->fcgx);
+    }
 }
                                
-// Note that the expected behaviour when there is no buffer varies
 int fcgi_streambuf::underflow()
 {
     if (this->bufsize)
@@ -113,7 +119,7 @@ int fcgi_streambuf::underflow()
     }
     else
     {
-        return FCGX_GetChar(this->fcgx);
+        return FCGX_UnGetChar(FCGX_GetChar(this->fcgx), this->fcgx);
     } 
 }