Inconsistencies in paramter const-ness noticed by SADAHIRO Tomoyuki.
Nicholas Clark [Sat, 1 Apr 2006 12:32:23 +0000 (12:32 +0000)]
p4raw-id: //depot/perl@27657

embed.fnc
proto.h
sv.c

index dfd3d5a..1e3c562 100644 (file)
--- a/embed.fnc
+++ b/embed.fnc
@@ -310,7 +310,7 @@ dpoM|struct refcounted_he *|refcounted_he_dup \
 dpoM   |HV *   |refcounted_he_chain_2hv|NULLOK const struct refcounted_he *c
 dpoM   |void   |refcounted_he_free|NULLOK struct refcounted_he *he
 dpoM   |struct refcounted_he *|refcounted_he_new \
-                               |NULLOK struct refcounted_he *parent \
+                               |NULLOK struct refcounted_he *const parent \
                                |NULLOK SV *key|NULLOK SV *value
 Apd    |SV**   |hv_store       |NULLOK HV* tb|NULLOK const char* key|I32 klen|NULLOK SV* val \
                                |U32 hash
@@ -1370,7 +1370,7 @@ sR        |I32    |expect_number  |NN char** pattern
 s      |STRLEN |sv_pos_u2b_forwards|NN const U8 *const start \
                |NN const U8 *const send|STRLEN uoffset
 s      |STRLEN |sv_pos_u2b_midway|NN const U8 *const start \
-               |NN const U8 *const send|STRLEN uoffset|STRLEN uend
+               |NN const U8 *send|STRLEN uoffset|STRLEN uend
 s      |STRLEN |sv_pos_u2b_cached|NN SV *sv|NN MAGIC **mgp \
                |NN const U8 *const start|NN const U8 *const send \
                |STRLEN uoffset|STRLEN uoffset0|STRLEN boffset0
diff --git a/proto.h b/proto.h
index 5bbd521..9a7ab7f 100644 (file)
--- a/proto.h
+++ b/proto.h
@@ -727,7 +727,7 @@ PERL_CALLCONV struct refcounted_he *        Perl_refcounted_he_dup(pTHX_ const struct r
 #endif
 PERL_CALLCONV HV *     Perl_refcounted_he_chain_2hv(pTHX_ const struct refcounted_he *c);
 PERL_CALLCONV void     Perl_refcounted_he_free(pTHX_ struct refcounted_he *he);
-PERL_CALLCONV struct refcounted_he *   Perl_refcounted_he_new(pTHX_ struct refcounted_he *parent, SV *key, SV *value);
+PERL_CALLCONV struct refcounted_he *   Perl_refcounted_he_new(pTHX_ struct refcounted_he *const parent, SV *key, SV *value);
 PERL_CALLCONV SV**     Perl_hv_store(pTHX_ HV* tb, const char* key, I32 klen, SV* val, U32 hash);
 PERL_CALLCONV HE*      Perl_hv_store_ent(pTHX_ HV* tb, SV* key, SV* val, U32 hash);
 PERL_CALLCONV SV**     Perl_hv_store_flags(pTHX_ HV* tb, const char* key, I32 klen, SV* val, U32 hash, int flags);
@@ -3733,7 +3733,7 @@ STATIC STRLEN     S_sv_pos_u2b_forwards(pTHX_ const U8 *const start, const U8 *const
                        __attribute__nonnull__(pTHX_1)
                        __attribute__nonnull__(pTHX_2);
 
-STATIC STRLEN  S_sv_pos_u2b_midway(pTHX_ const U8 *const start, const U8 *const send, STRLEN uoffset, STRLEN uend)
+STATIC STRLEN  S_sv_pos_u2b_midway(pTHX_ const U8 *const start, const U8 *send, STRLEN uoffset, STRLEN uend)
                        __attribute__nonnull__(pTHX_1)
                        __attribute__nonnull__(pTHX_2);
 
diff --git a/sv.c b/sv.c
index 7348876..3eb5c32 100644 (file)
--- a/sv.c
+++ b/sv.c
@@ -10869,7 +10869,7 @@ perl_clone_using(PerlInterpreter *proto_perl, UV flags,
     if (!specialCopIO(PL_compiling.cop_io))
        PL_compiling.cop_io = sv_dup_inc(PL_compiling.cop_io, param);
     PL_compiling.cop_hints
-       = Perl_refcounted_he_dup(aTHX_ PL_compiling.cop_hints, proto_perl);
+       = Perl_refcounted_he_dup(aTHX_ PL_compiling.cop_hints, param);
     PL_curcop          = (COP*)any_dup(proto_perl->Tcurcop, proto_perl);
 
     /* pseudo environmental stuff */