Re: Open2 and memory leaks

	Message-ID: <pzyarqpfli.fsf@eeyore.ibcinc.com>

p4raw-id: //depot/perl@1848

diff --git a/lib/IPC/Open3.pm b/lib/IPC/Open3.pm
index f1415e3..d079041 100644 (file)
--- a/lib/IPC/Open3.pm
+++ b/lib/IPC/Open3.pm
@@ -2,15 +2,15 @@ package IPC::Open3;
 
 use strict;
 no strict 'refs'; # because users pass me bareword filehandles
-use vars qw($VERSION @ISA @EXPORT $Fh $Me);
+use vars qw($VERSION @ISA @EXPORT $Me);
 
 require 5.001;
 require Exporter;
 
 use Carp;
-use Symbol 'qualify';
+use Symbol qw(gensym qualify);
 
-$VERSION       = 1.0102;
+$VERSION       = 1.0103;
 @ISA           = qw(Exporter);
 @EXPORT                = qw(open3);
 
@@ -94,7 +94,6 @@ C<cat -v> and continually read and write a line from it.
 #   rdr or wtr are null
 #   a system call fails
 
-$Fh = 'FHOPEN000';     # package static in case called more than once
 $Me = 'open3 (bug)';   # you should never see this, it's always localized
 
 # Fatal.pm needs to be fixed WRT prototypes.
@@ -140,9 +139,9 @@ sub _open3 {
     $dad_rdr = qualify $dad_rdr, $package;
     $dad_err = qualify $dad_err, $package;
 
-    my $kid_rdr = ++$Fh;
-    my $kid_wtr = ++$Fh;
-    my $kid_err = ++$Fh;
+    my $kid_rdr = gensym;
+    my $kid_wtr = gensym;
+    my $kid_err = gensym;
 
     xpipe $kid_rdr, $dad_wtr if !$dup_wtr;
     xpipe $dad_rdr, $kid_wtr if !$dup_rdr;
@@ -154,7 +153,7 @@ sub _open3 {
        # save a copy of her stdout before I put something else there.
        if ($dad_rdr ne $dad_err && $dup_err
                && fileno($dad_err) == fileno(STDOUT)) {
-           my $tmp = ++$Fh;
+           my $tmp = gensym;
            xopen($tmp, ">&$dad_err");
            $dad_err = $tmp;
        }
@@ -163,24 +162,24 @@ sub _open3 {
            xopen \*STDIN,  "<&$dad_wtr" if fileno(STDIN) != fileno($dad_wtr);
        } else {
            xclose $dad_wtr;
-           xopen \*STDIN,  "<&$kid_rdr";
-           xclose $kid_rdr;
+           xopen \*STDIN,  "<&=" . fileno $kid_rdr;
        }
        if ($dup_rdr) {
            xopen \*STDOUT, ">&$dad_rdr" if fileno(STDOUT) != fileno($dad_rdr);
        } else {
            xclose $dad_rdr;
-           xopen \*STDOUT, ">&$kid_wtr";
-           xclose $kid_wtr;
+           xopen \*STDOUT, ">&=" . fileno $kid_wtr;
        }
        if ($dad_rdr ne $dad_err) {
            if ($dup_err) {
-               xopen \*STDERR, ">&$dad_err"
+               # I have to use a fileno here because in this one case
+               # I'm doing a dup but the filehandle might be a reference
+               # (from the special case above).
+               xopen \*STDERR, ">&" . fileno $dad_err
                    if fileno(STDERR) != fileno($dad_err);
            } else {
                xclose $dad_err;
-               xopen \*STDERR, ">&$kid_err";
-               xclose $kid_err;
+               xopen \*STDERR, ">&=" . fileno $kid_err;
            }
        } else {
            xopen \*STDERR, ">&STDOUT" if fileno(STDERR) != fileno(STDOUT);
@@ -194,23 +193,23 @@ sub _open3 {
 
        my @close;
        if ($dup_wtr) {
-         $kid_rdr = $dad_wtr;
-         push @close, \*{$kid_rdr};
+         $kid_rdr = \*{$dad_wtr};
+         push @close, $kid_rdr;
        } else {
-         push @close, \*{$dad_wtr}, \*{$kid_rdr};
+         push @close, \*{$dad_wtr}, $kid_rdr;
        }
        if ($dup_rdr) {
-         $kid_wtr = $dad_rdr;
-         push @close, \*{$kid_wtr};
+         $kid_wtr = \*{$dad_rdr};
+         push @close, $kid_wtr;
        } else {
-         push @close, \*{$dad_rdr}, \*{$kid_wtr};
+         push @close, \*{$dad_rdr}, $kid_wtr;
        }
        if ($dad_rdr ne $dad_err) {
            if ($dup_err) {
-             $kid_err = $dad_err ;
-             push @close, \*{$kid_err};
+             $kid_err = \*{$dad_err};
+             push @close, $kid_err;
            } else {
-             push @close, \*{$dad_err}, \*{$kid_err};
+             push @close, \*{$dad_err}, $kid_err;
            }
        } else {
          $kid_err = $kid_wtr;
@@ -218,13 +217,13 @@ sub _open3 {
        require IO::Pipe;
        $kidpid = eval {
            spawn_with_handles( [ { mode => 'r',
-                                   open_as => \*{$kid_rdr},
+                                   open_as => $kid_rdr,
                                    handle => \*STDIN },
                                  { mode => 'w',
-                                   open_as => \*{$kid_wtr},
+                                   open_as => $kid_wtr,
                                    handle => \*STDOUT },
                                  { mode => 'w',
-                                   open_as => \*{$kid_err},
+                                   open_as => $kid_err,
                                    handle => \*STDERR },
                                ], \@close, @cmd);
        };