correct bugs exposed in MM_Unix.pm by commenting out Selfloader

(MAN3PODS cannot be set to ' '; stray stricture violation)

p4raw-id: //depot/perl@1967

diff --git a/ext/B/Makefile.PL b/ext/B/Makefile.PL
index cdcc4ed..80e5e1b 100644 (file)
--- a/ext/B/Makefile.PL
+++ b/ext/B/Makefile.PL
@@ -16,7 +16,7 @@ if ($^O eq 'MSWin32') {
 WriteMakefile(
     NAME       => "B",
     VERSION    => "a5",
-    MAN3PODS => ' ',
+    MAN3PODS => {},
     clean      => {
        FILES           => "perl$e byteperl$e *$o B.c *~"
     }

diff --git a/ext/DB_File/Makefile.PL b/ext/DB_File/Makefile.PL
index dbe19f1..1a13e0b 100644 (file)
--- a/ext/DB_File/Makefile.PL
+++ b/ext/DB_File/Makefile.PL
@@ -11,7 +11,7 @@ $LIB = "-llibdb" if $^O eq 'MSWin32' ;
 WriteMakefile(
        NAME            => 'DB_File',
        LIBS            => ["-L/usr/local/lib $LIB"],
-        MAN3PODS        => ' ',         # Pods will be built by installman.
+        MAN3PODS        => {},         # Pods will be built by installman.
        #INC            => '-I/usr/local/include',
        VERSION_FROM    => 'DB_File.pm',
        XSPROTOARG      => '-noprototypes',

diff --git a/ext/Data/Dumper/Makefile.PL b/ext/Data/Dumper/Makefile.PL
index 6c94e95..12930c5 100644 (file)
--- a/ext/Data/Dumper/Makefile.PL
+++ b/ext/Data/Dumper/Makefile.PL
@@ -7,5 +7,5 @@ WriteMakefile(
                             SUFFIX     => 'gz',
                             DIST_DEFAULT => 'all tardist',
                           },
-       MAN3PODS        => ' ',
+       MAN3PODS        => {},
 );

diff --git a/ext/DynaLoader/Makefile.PL b/ext/DynaLoader/Makefile.PL
index 7a75115..2141fde 100644 (file)
--- a/ext/DynaLoader/Makefile.PL
+++ b/ext/DynaLoader/Makefile.PL
@@ -4,7 +4,7 @@ WriteMakefile(
     NAME => 'DynaLoader',
     LINKTYPE   => 'static',
     DEFINE     => '-DPERL_CORE -DLIBC="$(LIBC)"',
-    MAN3PODS   => ' ',         # Pods will be built by installman.
+    MAN3PODS   => {},  # Pods will be built by installman.
     SKIP       => [qw(dynamic dynamic_lib dynamic_bs)],
     XSPROTOARG => '-noprototypes',             # XXX remove later?
     VERSION_FROM => 'DynaLoader_pm.PL',

diff --git a/ext/Errno/Makefile.PL b/ext/Errno/Makefile.PL
index bb1467b..604d4fb 100644 (file)
--- a/ext/Errno/Makefile.PL
+++ b/ext/Errno/Makefile.PL
@@ -1,11 +1,11 @@
 use ExtUtils::MakeMaker;
 
-@VMS = ($^O eq 'VMS') ? (MAN3PODS => ' ') : ();
+@VMS = ($^O eq 'VMS') ? (MAN3PODS => {}) : ();
 
 WriteMakefile(
     NAME        => 'Errno',
     VERSION_FROM => 'Errno_pm.PL',
-    MAN3PODS     => ' ',       # Pods will be built by installman.
+    MAN3PODS     => {},        # Pods will be built by installman.
     PL_FILES    => {'Errno_pm.PL'=>'Errno.pm'},
     PM          => {'Errno.pm' => '$(INST_LIBDIR)/Errno.pm'},
     'clean'     => {FILES => 'Errno.pm'},

diff --git a/ext/Fcntl/Makefile.PL b/ext/Fcntl/Makefile.PL
index 66a6df6..0346373 100644 (file)
--- a/ext/Fcntl/Makefile.PL
+++ b/ext/Fcntl/Makefile.PL
@@ -1,7 +1,7 @@
 use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME       => 'Fcntl',
-    MAN3PODS   => ' ',         # Pods will be built by installman.
+    MAN3PODS   => {},  # Pods will be built by installman.
     XSPROTOARG => '-noprototypes',             # XXX remove later?
     VERSION_FROM => 'Fcntl.pm',
 );

diff --git a/ext/GDBM_File/Makefile.PL b/ext/GDBM_File/Makefile.PL
index d244613..2a7256f 100644 (file)
--- a/ext/GDBM_File/Makefile.PL
+++ b/ext/GDBM_File/Makefile.PL
@@ -2,7 +2,7 @@ use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME => 'GDBM_File',
     LIBS => ["-L/usr/local/lib -lgdbm", "-ldbm"],
-    MAN3PODS   => ' ',         # Pods will be built by installman.
+    MAN3PODS   => {},  # Pods will be built by installman.
     XSPROTOARG => '-noprototypes',             # XXX remove later?
     VERSION_FROM => 'GDBM_File.pm',
 );

diff --git a/ext/IO/Makefile.PL b/ext/IO/Makefile.PL
index 4a34be6..6a2d50d 100644 (file)
--- a/ext/IO/Makefile.PL
+++ b/ext/IO/Makefile.PL
@@ -1,7 +1,7 @@
 use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME => 'IO',
-    MAN3PODS   => ' ',                 # Pods will be built by installman.
+    MAN3PODS   => {},                  # Pods will be built by installman.
     XSPROTOARG => '-noprototypes',     # XXX remove later?
     VERSION_FROM => 'lib/IO/Handle.pm',
     XS_VERSION => 1.15

diff --git a/ext/IPC/SysV/Makefile.PL b/ext/IPC/SysV/Makefile.PL
index 370a965..60dd74d 100644 (file)
--- a/ext/IPC/SysV/Makefile.PL
+++ b/ext/IPC/SysV/Makefile.PL
@@ -22,7 +22,7 @@ sub MY::libscan
 WriteMakefile(
        VERSION_FROM    => "SysV.pm",
        NAME            => "IPC::SysV",
-       MAN3PODS        => ' ',         # Pods will be built by installman.
+       MAN3PODS        => {},  # Pods will be built by installman.
  
        'dist'          => {COMPRESS => 'gzip -9f',
                            SUFFIX   => 'gz', 

diff --git a/ext/NDBM_File/Makefile.PL b/ext/NDBM_File/Makefile.PL
index ca4c107..6ceab55 100644 (file)
--- a/ext/NDBM_File/Makefile.PL
+++ b/ext/NDBM_File/Makefile.PL
@@ -2,7 +2,7 @@ use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME       => 'NDBM_File',
     LIBS => ["-L/usr/local/lib -lndbm", "-ldbm -lucb"],
-    MAN3PODS   => ' ',         # Pods will be built by installman.
+    MAN3PODS   => {},  # Pods will be built by installman.
     XSPROTOARG => '-noprototypes',             # XXX remove later?
     VERSION_FROM => 'NDBM_File.pm',
 );

diff --git a/ext/ODBM_File/Makefile.PL b/ext/ODBM_File/Makefile.PL
index 76a5d19..2732a32 100644 (file)
--- a/ext/ODBM_File/Makefile.PL
+++ b/ext/ODBM_File/Makefile.PL
@@ -2,7 +2,7 @@ use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME       => 'ODBM_File',
     LIBS => ["-ldbm -lucb"],
-    MAN3PODS   => ' ',         # Pods will be built by installman.
+    MAN3PODS   => {},  # Pods will be built by installman.
     XSPROTOARG => '-noprototypes',             # XXX remove later?
     VERSION_FROM => 'ODBM_File.pm', 
 );

diff --git a/ext/Opcode/Makefile.PL b/ext/Opcode/Makefile.PL
index 48a6ed8..d7e781f 100644 (file)
--- a/ext/Opcode/Makefile.PL
+++ b/ext/Opcode/Makefile.PL
@@ -1,7 +1,7 @@
 use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME => 'Opcode',
-    MAN3PODS   => ' ',
+    MAN3PODS   => {},
     VERSION_FROM => 'Opcode.pm',
     XS_VERSION => '1.03'
 );

diff --git a/ext/POSIX/Makefile.PL b/ext/POSIX/Makefile.PL
index bc1dda9..d379fdb 100644 (file)
--- a/ext/POSIX/Makefile.PL
+++ b/ext/POSIX/Makefile.PL
@@ -2,7 +2,7 @@ use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME       => 'POSIX',
     ($^O eq 'MSWin32' ? () : (LIBS     => ["-lm -lposix -lcposix"])),
-    MAN3PODS   => ' ',         # Pods will be built by installman.
+    MAN3PODS   => {},  # Pods will be built by installman.
     XSPROTOARG => '-noprototypes',             # XXX remove later?
     VERSION_FROM => 'POSIX.pm', 
 );

diff --git a/ext/SDBM_File/Makefile.PL b/ext/SDBM_File/Makefile.PL
index b639b29..7494785 100644 (file)
--- a/ext/SDBM_File/Makefile.PL
+++ b/ext/SDBM_File/Makefile.PL
@@ -12,7 +12,7 @@ else                  { $myextlib = 'sdbm/libsdbm$(LIB_EXT)';  }
 WriteMakefile(
               NAME     => 'SDBM_File',
               MYEXTLIB => $myextlib,
-              MAN3PODS         => ' ',         # Pods will be built by installman.
+              MAN3PODS         => {},  # Pods will be built by installman.
               XSPROTOARG => '-noprototypes',           # XXX remove later?
               VERSION_FROM => 'SDBM_File.pm',
               DEFINE => $define,

diff --git a/ext/Socket/Makefile.PL b/ext/Socket/Makefile.PL
index 7b9469a..3819143 100644 (file)
--- a/ext/Socket/Makefile.PL
+++ b/ext/Socket/Makefile.PL
@@ -2,6 +2,6 @@ use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME       => 'Socket',
     VERSION_FROM => 'Socket.pm',
-    MAN3PODS   => ' ',         # Pods will be built by installman.
+    MAN3PODS   => {},  # Pods will be built by installman.
     XSPROTOARG => '-noprototypes',             # XXX remove later?
 );

diff --git a/ext/Thread/Makefile.PL b/ext/Thread/Makefile.PL
index e252d4e..e67fbb7 100644 (file)
--- a/ext/Thread/Makefile.PL
+++ b/ext/Thread/Makefile.PL
@@ -2,6 +2,6 @@ use ExtUtils::MakeMaker;
 WriteMakefile(
        NAME => 'Thread',
        VERSION_FROM => 'Thread.pm',
-    MAN3PODS => ' '
+    MAN3PODS => {}
        );
 

diff --git a/ext/attrs/Makefile.PL b/ext/attrs/Makefile.PL
index c421757..86ed3f3 100644 (file)
--- a/ext/attrs/Makefile.PL
+++ b/ext/attrs/Makefile.PL
@@ -2,6 +2,6 @@ use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME       => 'attrs',
     VERSION_FROM => 'attrs.pm',
-    MAN3PODS   => ' ',         # Pods will be built by installman.
+    MAN3PODS   => {},  # Pods will be built by installman.
     XSPROTOARG => '-noprototypes'
 );

diff --git a/ext/re/Makefile.PL b/ext/re/Makefile.PL
index 9ed83d1..040b085 100644 (file)
--- a/ext/re/Makefile.PL
+++ b/ext/re/Makefile.PL
@@ -2,7 +2,7 @@ use ExtUtils::MakeMaker;
 WriteMakefile(
     NAME               => 're',
     VERSION_FROM       => 're.pm',
-    MAN3PODS           => ' ',         # Pods will be built by installman.
+    MAN3PODS           => {},  # Pods will be built by installman.
     XSPROTOARG         => '-noprototypes',
     OBJECT             => 're_exec$(OBJ_EXT) re_comp$(OBJ_EXT) re$(OBJ_EXT)',
     DEFINE             => '-DPERL_EXT_RE_BUILD',

diff --git a/lib/ExtUtils/MM_Unix.pm b/lib/ExtUtils/MM_Unix.pm
index 941a792..ca6d575 100644 (file)
--- a/lib/ExtUtils/MM_Unix.pm
+++ b/lib/ExtUtils/MM_Unix.pm
@@ -3311,7 +3311,7 @@ sub tool_xsubpp {
        }
     }
 
-    $xsubpp = $self->{CAPI} ? "xsubpp -object_capi" : "xsubpp";
+    my $xsubpp = $self->{CAPI} ? "xsubpp -object_capi" : "xsubpp";
 
     return qq{
 XSUBPPDIR = $xsdir