Retract #20644 and #20643; on non-microperl non-fcntl

systems Wrong Thing would be done.  (And as Sarathy
points out, closing both ends of a pipe is rather
identical to never opening it...)

p4raw-id: //depot/perl@20653

diff --git a/pp_sys.c b/pp_sys.c
index 25926a2..86241fa 100644 (file)
--- a/pp_sys.c
+++ b/pp_sys.c
@@ -4138,8 +4138,6 @@ PP(pp_system)
            PerlLIO_close(pp[0]);
 #if defined(HAS_FCNTL) && defined(F_SETFD)
            fcntl(pp[1], F_SETFD, FD_CLOEXEC);
-#else
-           PerlLIO_close(pp[1]); /* Do as best as we can: pretend success. */
 #endif
        }
        if (PL_op->op_flags & OPf_STACKED) {

diff --git a/util.c b/util.c
index cec92e2..aec4354 100644 (file)
--- a/util.c
+++ b/util.c
@@ -1821,8 +1821,6 @@ Perl_my_popen_list(pTHX_ char *mode, int n, SV **args)
 #if defined(HAS_FCNTL) && defined(F_SETFD)
            /* Close error pipe automatically if exec works */
            fcntl(pp[1], F_SETFD, FD_CLOEXEC);
-#else
-           PerlLIO_close(pp[1]); /* Do as best as we can: pretend success. */
 #endif
        }
        /* Now dup our end of _the_ pipe to right position */
@@ -1962,8 +1960,6 @@ Perl_my_popen(pTHX_ char *cmd, char *mode)
            PerlLIO_close(pp[0]);
 #if defined(HAS_FCNTL) && defined(F_SETFD)
            fcntl(pp[1], F_SETFD, FD_CLOEXEC);
-#else
-           PerlLIO_close(pp[1]); /* Do as best as we can: pretend success. */
 #endif
        }
        if (p[THIS] != (*mode == 'r')) {