Move the pack warnings to their own file, as pointed

out by Spider.

p4raw-id: //depot/perl@10908

diff --git a/MANIFEST b/MANIFEST
index 6be8169..3cb87c1 100644 (file)
--- a/MANIFEST
+++ b/MANIFEST
@@ -1865,6 +1865,7 @@ t/lib/warnings/perly              Tests for perly.y for warnings.t
 t/lib/warnings/pp              Tests for pp.c for warnings.t
 t/lib/warnings/pp_ctl          Tests for pp_ctl.c for warnings.t
 t/lib/warnings/pp_hot          Tests for pp_hot.c for warnings.t
+t/lib/warnings/pp_pack         Tests for pp_pack.c for warnings.t
 t/lib/warnings/pp_sys          Tests for pp_sys.c for warnings.t
 t/lib/warnings/regcomp         Tests for regcomp.c for warnings.t
 t/lib/warnings/regexec         Tests for regexec.c for warnings.t

diff --git a/t/lib/warnings/pp b/t/lib/warnings/pp
index 83786a0..4b3014d 100644 (file)
--- a/t/lib/warnings/pp
+++ b/t/lib/warnings/pp
@@ -15,13 +15,6 @@
   Odd number of elements in hash list
        my $a = { 1,2,3 } ;
 
-  Invalid type in unpack: '%c
-       my $A = pack ("A,A", 1,2) ;
-       my @A = unpack ("A,A", "22") ;
-
-  Attempt to pack pointer to temporary value
-       pack("p", "abc") ;
-
   Explicit blessing to '' (assuming package main)
        bless \[], "";
 
@@ -63,37 +56,6 @@ my $b = { 1,2,3};
 EXPECT
 Odd number of elements in hash assignment at - line 3.
 ########
-# pp_pack.c
-use warnings 'pack' ;
-use warnings 'unpack' ;
-my @a = unpack ("A,A", "22") ;
-my $a = pack ("A,A", 1,2) ;
-no warnings 'pack' ;
-no warnings 'unpack' ;
-my @b = unpack ("A,A", "22") ;
-my $b = pack ("A,A", 1,2) ;
-EXPECT
-Invalid type in unpack: ',' at - line 4.
-Invalid type in pack: ',' at - line 5.
-########
-# pp.c
-use warnings 'uninitialized' ;
-my $a = undef ; 
-my $b = $$a;
-no warnings 'uninitialized' ;
-my $c = $$a;
-EXPECT
-Use of uninitialized value in scalar dereference at - line 4.
-########
-# pp_pack.c
-use warnings 'pack' ;
-sub foo { my $a = "a"; return $a . $a++ . $a++ }
-my $a = pack("p", &foo) ;
-no warnings 'pack' ;
-my $b = pack("p", &foo) ;
-EXPECT
-Attempt to pack pointer to temporary value at - line 4.
-########
 # pp.c
 use warnings 'misc' ;
 bless \[], "" ;
@@ -107,44 +69,3 @@ use utf8 ;
 $_ = "\x80  \xff" ;
 reverse ;
 EXPECT
-########
-# pp_pack.c
-use warnings 'pack' ;
-print unpack("C", pack("C",   -1)), "\n",
-       unpack("C", pack("C",    0)), "\n",
-       unpack("C", pack("C",  255)), "\n",
-       unpack("C", pack("C",  256)), "\n",
-       unpack("c", pack("c", -129)), "\n",
-       unpack("c", pack("c", -128)), "\n",
-       unpack("c", pack("c",  127)), "\n",
-       unpack("c", pack("c",  128)), "\n";
-no warnings 'pack' ;
-print unpack("C", pack("C",   -1)), "\n";
-print unpack("C", pack("C",    0)), "\n";
-print unpack("C", pack("C",  255)), "\n";
-print unpack("C", pack("C",  256)), "\n";
-print unpack("c", pack("c", -129)), "\n";
-print unpack("c", pack("c", -128)), "\n";
-print unpack("c", pack("c",  127)), "\n";
-print unpack("c", pack("c",  128)), "\n";
-EXPECT
-Character in "C" format wrapped at - line 3.
-Character in "C" format wrapped at - line 3.
-Character in "c" format wrapped at - line 3.
-Character in "c" format wrapped at - line 3.
-255
-0
-255
-0
-127
--128
-127
--128
-255
-0
-255
-0
-127
--128
-127
--128

diff --git a/t/lib/warnings/pp_pack b/t/lib/warnings/pp_pack
new file mode 100644 (file)
index 0000000..62fa6ec
--- /dev/null
+++ b/t/lib/warnings/pp_pack
@@ -0,0 +1,95 @@
+  pp.c TODO
+
+  Invalid type in unpack: '%c
+       my $A = pack ("A,A", 1,2) ;
+       my @A = unpack ("A,A", "22") ;
+
+  Attempt to pack pointer to temporary value
+       pack("p", "abc") ;
+
+__END__
+# pp_pack.c
+use warnings 'pack' ;
+use warnings 'unpack' ;
+my @a = unpack ("A,A", "22") ;
+my $a = pack ("A,A", 1,2) ;
+no warnings 'pack' ;
+no warnings 'unpack' ;
+my @b = unpack ("A,A", "22") ;
+my $b = pack ("A,A", 1,2) ;
+EXPECT
+Invalid type in unpack: ',' at - line 4.
+Invalid type in pack: ',' at - line 5.
+########
+# pp.c
+use warnings 'uninitialized' ;
+my $a = undef ; 
+my $b = $$a;
+no warnings 'uninitialized' ;
+my $c = $$a;
+EXPECT
+Use of uninitialized value in scalar dereference at - line 4.
+########
+# pp_pack.c
+use warnings 'pack' ;
+sub foo { my $a = "a"; return $a . $a++ . $a++ }
+my $a = pack("p", &foo) ;
+no warnings 'pack' ;
+my $b = pack("p", &foo) ;
+EXPECT
+Attempt to pack pointer to temporary value at - line 4.
+########
+# pp.c
+use warnings 'misc' ;
+bless \[], "" ;
+no warnings 'misc' ;
+bless \[], "" ;
+EXPECT
+Explicit blessing to '' (assuming package main) at - line 3.
+########
+# pp.c
+use utf8 ;
+$_ = "\x80  \xff" ;
+reverse ;
+EXPECT
+########
+# pp_pack.c
+use warnings 'pack' ;
+print unpack("C", pack("C",   -1)), "\n",
+       unpack("C", pack("C",    0)), "\n",
+       unpack("C", pack("C",  255)), "\n",
+       unpack("C", pack("C",  256)), "\n",
+       unpack("c", pack("c", -129)), "\n",
+       unpack("c", pack("c", -128)), "\n",
+       unpack("c", pack("c",  127)), "\n",
+       unpack("c", pack("c",  128)), "\n";
+no warnings 'pack' ;
+print unpack("C", pack("C",   -1)), "\n";
+print unpack("C", pack("C",    0)), "\n";
+print unpack("C", pack("C",  255)), "\n";
+print unpack("C", pack("C",  256)), "\n";
+print unpack("c", pack("c", -129)), "\n";
+print unpack("c", pack("c", -128)), "\n";
+print unpack("c", pack("c",  127)), "\n";
+print unpack("c", pack("c",  128)), "\n";
+EXPECT
+Character in "C" format wrapped at - line 3.
+Character in "C" format wrapped at - line 3.
+Character in "c" format wrapped at - line 3.
+Character in "c" format wrapped at - line 3.
+255
+0
+255
+0
+127
+-128
+127
+-128
+255
+0
+255
+0
+127
+-128
+127
+-128