croak in POSIX::sigaction() when passed a negative signal instead

dumping core.

p4raw-id: //depot/perl@27440

diff --git a/ext/POSIX/POSIX.xs b/ext/POSIX/POSIX.xs
index 730e7e0..50f3a74 100644 (file)
--- a/ext/POSIX/POSIX.xs
+++ b/ext/POSIX/POSIX.xs
@@ -1260,6 +1260,10 @@ sigaction(sig, optaction, oldaction = 0)
            SV** svp;
            SV** sigsvp;
 
+            if (sig < 0) {
+                croak("Negative signals are not allowed");
+            }
+
            if (sig == 0 && SvPOK(ST(0))) {
                const char *s = SvPVX_const(ST(0));
                int i = whichsig(s);

diff --git a/ext/POSIX/t/sigaction.t b/ext/POSIX/t/sigaction.t
index 813960a..c33b732 100644 (file)
--- a/ext/POSIX/t/sigaction.t
+++ b/ext/POSIX/t/sigaction.t
@@ -205,3 +205,6 @@ SKIP: {
     kill 'HUP', $$;
 }
 
+eval { sigaction(-999, "foo"); };
+like($@, qr/Negative signals/,
+    "Prevent negative signals instead of core dumping");