as well. There will be 2 releases, and then it will
be removed.
+ * Moose::Meta::Class
+ - fixing &new_object to make sure trigger gets the
+ coerced value (spotted by Charles Alderman on the
+ mailing list)
+ - added test for this
+
* Moose::Meta::Method::Constructor
- immutable classes which had non-lazy attributes were calling
the default generating sub twice in the constructor. (bug
type constraint object (nothingmuch)
* Moose::Meta::TypeConstraint
- - added the &equals method for comparing two type
- constraints (nothingmuch)
- - added tests for this (nothingmuch)
+ Moose::Meta::TypeConstraint::Class
+ Moose::Meta::TypeConstraint::Enum
+ Moose::Meta::TypeConstraint::Union
+ Moose::Meta::TypeConstraint::Parameterized
+ - added the &equals method for comparing two type
+ constraints (nothingmuch)
+ - added tests for this (nothingmuch)
+
+ * Moose::Meta::TypeConstraint
- add the &parents method, which is just an alias to &parent.
Useful for polymorphism with TC::Class (nothingmuch)
* Moose::Meta::TypeConstraint::Class
- - added the &equals method for comparing two type
- constraints (nothingmuch)
- added the class attribute for introspection purposes
(nothingmuch)
- added tests for this
+
+ * Moose::Meta::TypeConstraint::Enum
+ - broke this out into it's own class (nothingmuch)
* Moose::Cookbook::Recipe*
- fixed references to test file locations in the POD
my ($class, %params) = @_;
my $self = $class->SUPER::new_object(%params);
foreach my $attr ($class->compute_all_applicable_attributes()) {
- if ( defined( my $init_arg = $attr->init_arg ) ) {
- if ( exists($params{$init_arg}) && $attr->can('has_trigger') && $attr->has_trigger ) {
- $attr->trigger->($self, $params{$init_arg}, $attr);
- }
+ # if we have a trigger, then ...
+ if ($attr->can('has_trigger') && $attr->has_trigger) {
+ # make sure we have an init-arg ...
+ if (defined(my $init_arg = $attr->init_arg)) {
+ # now make sure an init-arg was passes ...
+ if (exists $params{$init_arg}) {
+ # and if get here, fire the trigger
+ $attr->trigger->(
+ $self,
+ # check if there is a coercion
+ ($attr->should_coerce
+ # and if so, we need to grab the
+ # value that is actually been stored
+ ? $attr->get_read_method_ref->($self)
+ # otherwise, just get the value from
+ # the constructor params
+ : $params{$init_arg}),
+ $attr
+ );
+ }
+ }
}
}
return $self;
use Scalar::Util 'blessed';
use Moose::Util::TypeConstraints ();
-our $VERSION = '0.01';
+our $VERSION = '0.02';
our $AUTHORITY = 'cpan:STEVAN';
use base 'Moose::Meta::TypeConstraint';
__PACKAGE__->meta->add_attribute('class' => (
- reader => 'class',
+ reader => 'class',
));
sub new {
my ( $class, %args ) = @_;
- $args{class} = $args{name} unless exists $args{class};
-
+ $args{class} = $args{name} unless exists $args{class};
$args{parent} = Moose::Util::TypeConstraints::find_type_constraint('Object');
-
- my $self = $class->meta->new_object(%args);
+ my $self = $class->meta->new_object(%args);
$self->_create_hand_optimized_type_constraint;
-
$self->compile_type_constraint();
return $self;
sub _create_hand_optimized_type_constraint {
my $self = shift;
my $class = $self->class;
- $self->hand_optimized_type_constraint(sub { blessed( $_[0] ) && $_[0]->isa($class) });
+ $self->hand_optimized_type_constraint(
+ sub {
+ blessed( $_[0] ) && $_[0]->isa($class)
+ }
+ );
}
sub parents {
# if anybody thinks this problematic please discuss on IRC.
# a possible fix is to add by attr indexing to the type registry to find types of a certain property
# regardless of their name
- Moose::Util::TypeConstraints::find_type_constraint($_) || __PACKAGE__->new( name => $_ )
+ Moose::Util::TypeConstraints::find_type_constraint($_)
+ ||
+ __PACKAGE__->new( name => $_ )
} $self->class->meta->superclasses,
);
}
=item B<new>
+=item B<class>
+
=item B<hand_optimized_type_constraint>
=item B<has_hand_optimized_type_constraint>
-#!/usr/bin/perl
-
package Moose::Meta::TypeConstraint::Enum;
use strict;
use warnings;
use metaclass;
-our $VERSION = '0.06';
+use Moose::Util::TypeConstraints ();
+
+our $VERSION = '0.01';
our $AUTHORITY = 'cpan:STEVAN';
use base 'Moose::Meta::TypeConstraint';
__PACKAGE__->meta->add_attribute('values' => (
- accessor => 'values',
+ accessor => 'values',
));
sub new {
sub { defined($_[0]) && !ref($_[0]) && exists $values{$_[0]} };
}
-__PACKAGE__
+1;
__END__
=item B<values>
+=item B<meta>
+
=back
+=head1 BUGS
+
+All complex software has bugs lurking in it, and this module is no
+exception. If you find a bug please either email me, or add the bug
+to cpan-RT.
+
+=head1 AUTHOR
+
+Yuval Kogman E<lt>nothingmuch@cpan.orgE<gt>
+
+=head1 COPYRIGHT AND LICENSE
+
+Copyright 2006-2008 by Infinity Interactive, Inc.
+
+L<http://www.iinteractive.com>
+
+This library is free software; you can redistribute it and/or modify
+it under the same terms as Perl itself.
+
=cut
--- /dev/null
+#!/usr/bin/perl
+
+use strict;
+use warnings;
+
+use Test::More tests => 9;
+use Test::Exception;
+
+BEGIN {
+ use_ok('Moose');
+}
+
+{
+ package Fake::DateTime;
+ use Moose;
+
+ has 'string_repr' => (is => 'ro');
+
+ package Mortgage;
+ use Moose;
+ use Moose::Util::TypeConstraints;
+
+ coerce 'Fake::DateTime'
+ => from 'Str'
+ => via { Fake::DateTime->new(string_repr => $_) };
+
+ has 'closing_date' => (
+ is => 'rw',
+ isa => 'Fake::DateTime',
+ coerce => 1,
+ trigger => sub {
+ my ( $self, $val, $meta ) = @_;
+ ::pass('... trigger is being called');
+ ::isa_ok($self->closing_date, 'Fake::DateTime');
+ ::isa_ok($val, 'Fake::DateTime');
+ }
+ );
+}
+
+{
+ my $mtg = Mortgage->new( closing_date => 'yesterday' );
+ isa_ok($mtg, 'Mortgage');
+
+ # check that coercion worked
+ isa_ok($mtg->closing_date, 'Fake::DateTime');
+}
+
+Mortgage->meta->make_immutable;
+ok(Mortgage->meta->is_immutable, '... Mortgage is now immutable');
+
+{
+ my $mtg = Mortgage->new( closing_date => 'yesterday' );
+ isa_ok($mtg, 'Mortgage');
+
+ # check that coercion worked
+ isa_ok($mtg->closing_date, 'Fake::DateTime');
+}
+
+
+
+
+
+
projects / gitmo/Moose.git / commitdiff