Remove an unnecessary goto
Andy Lester [Wed, 3 May 2006 00:54:30 +0000 (19:54 -0500)]
Message-ID: <20060503055430.GA4922@petdance.com>

p4raw-id: //depot/perl@28079

op.c

diff --git a/op.c b/op.c
index 70f188e..75d1850 100644 (file)
--- a/op.c
+++ b/op.c
@@ -1152,15 +1152,14 @@ Perl_mod(pTHX_ OP *o, I32 type)
                CV *cv;
                OP *okid;
 
-               if (kid->op_type == OP_PUSHMARK)
-                   goto skip_kids;
-               if (kid->op_type != OP_NULL || kid->op_targ != OP_LIST)
-                   Perl_croak(aTHX_
-                              "panic: unexpected lvalue entersub "
-                              "args: type/targ %ld:%"UVuf,
-                              (long)kid->op_type, (UV)kid->op_targ);
-               kid = kLISTOP->op_first;
-             skip_kids:
+               if (kid->op_type != OP_PUSHMARK) {
+                   if (kid->op_type != OP_NULL || kid->op_targ != OP_LIST)
+                       Perl_croak(aTHX_
+                               "panic: unexpected lvalue entersub "
+                               "args: type/targ %ld:%"UVuf,
+                               (long)kid->op_type, (UV)kid->op_targ);
+                   kid = kLISTOP->op_first;
+               }
                while (kid->op_sibling)
                    kid = kid->op_sibling;
                if (!(kid->op_type == OP_NULL && kid->op_targ == OP_RV2CV)) {