Fix bug #17744, suggested by Andreas Jurenda,

tweaked by rgs (security hole in Safe).

p4raw-id: //depot/perl@17976

diff --git a/MANIFEST b/MANIFEST
index df57030..38e5616 100644 (file)
--- a/MANIFEST
+++ b/MANIFEST
@@ -570,6 +570,7 @@ ext/re/re.t                         see if re pragma works
 ext/re/re.xs                   re extension external subroutines
 ext/Safe/safe1.t               See if Safe works
 ext/Safe/safe2.t               See if Safe works
+ext/Safe/safe3.t               See if Safe works
 ext/SDBM_File/Makefile.PL      SDBM extension makefile writer
 ext/SDBM_File/sdbm.t           See if SDBM_File works
 ext/SDBM_File/sdbm/biblio      SDBM kit

diff --git a/ext/Opcode/Safe.pm b/ext/Opcode/Safe.pm
index e8efaa9..8d875ef 100644 (file)
--- a/ext/Opcode/Safe.pm
+++ b/ext/Opcode/Safe.pm
@@ -214,11 +214,11 @@ sub reval {
     # Create anon sub ref in root of compartment.
     # Uses a closure (on $expr) to pass in the code to be executed.
     # (eval on one line to keep line numbers as expected by caller)
-       my $evalcode = sprintf('package %s; sub { eval $expr; }', $root);
+    my $evalcode = sprintf('package %s; sub { @_ = (); eval $expr; }', $root);
     my $evalsub;
 
-       if ($strict) { use strict; $evalsub = eval $evalcode; }
-       else         {  no strict; $evalsub = eval $evalcode; }
+    if ($strict) { use strict; $evalsub = eval $evalcode; }
+    else         {  no strict; $evalsub = eval $evalcode; }
 
     return Opcode::_safe_call_sv($root, $obj->{Mask}, $evalsub);
 }

diff --git a/ext/Safe/safe3.t b/ext/Safe/safe3.t
new file mode 100644 (file)
index 0000000..c924762
--- /dev/null
+++ b/ext/Safe/safe3.t
@@ -0,0 +1,33 @@
+#!perl
+
+BEGIN {
+    if ($ENV{PERL_CORE}) {
+       chdir 't' if -d 't';
+       @INC = '../lib';
+       require Config; import Config;
+       if ($Config{'extensions'} !~ /\bOpcode\b/
+           && $Config{'extensions'} !~ /\bPOSIX\b/
+           && $Config{'osname'} ne 'VMS')
+       {
+           print "1..0\n";
+           exit 0;
+       }
+    }
+}
+
+use strict;
+use warnings;
+use POSIX qw(ceil);
+use Test::More tests => 1;
+use Safe;
+
+my $safe = new Safe;
+$safe->deny('add');
+
+# Attempt to change the opmask from within the safe compartment
+$safe->reval( qq{\$_[1] = q/\0/ x } . ceil( Opcode::opcodes / 8 ) );
+
+# Check that it didn't work
+$safe->reval( q{$x + $y} );
+like( $@, qr/^'?addition \(\+\)'? trapped by operation mask/,
+           'opmask still in place' );