projects
/
catagits/Catalyst-Runtime.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
(from parent 1:
08f8d85
)
Disallow negative counts for CaptureArgs and Args
Dagfinn Ilmari Mannsåker [Tue, 14 May 2013 07:38:23 +0000 (08:38 +0100)]
lib/Catalyst/DispatchType/Chained.pm
patch
|
blob
|
blame
|
history
t/dead_load_bad_args.t
patch
|
blob
|
blame
|
history
diff --git
a/lib/Catalyst/DispatchType/Chained.pm
b/lib/Catalyst/DispatchType/Chained.pm
index
615f5aa
..
33e23d2
100644
(file)
--- a/
lib/Catalyst/DispatchType/Chained.pm
+++ b/
lib/Catalyst/DispatchType/Chained.pm
@@
-298,7
+298,7
@@
sub _check_args_attr {
my $args = $action->attributes->{$name}->[0];
if (defined($args) and not (
Scalar::Util::looks_like_number($args) and
- int($args) == $args
+ int($args) == $args and $args >= 0
)) {
require Data::Dumper;
local $Data::Dumper::Terse = 1;
diff --git
a/t/dead_load_bad_args.t
b/t/dead_load_bad_args.t
index
8542a13
..
d80195f
100644
(file)
--- a/
t/dead_load_bad_args.t
+++ b/
t/dead_load_bad_args.t
@@
-12,6
+12,7
@@
for my $fail (
"(' ')",
"('')",
"('1.23')",
+ "(-1)",
) {
for my $type (qw(Args CaptureArgs)) {
eval <<"END";