Remove test for NUL ending in r?instr().

This test is actually harmful because we will search
for any garbage found past the empty search string.
Ref change 26509.

p4raw-id: //depot/perl@26510

diff --git a/util.c b/util.c
index a88d988..c082f5b 100644 (file)
--- a/util.c
+++ b/util.c
@@ -356,7 +356,7 @@ Perl_ninstr(pTHX_ register const char *big, register const char *bigend, const c
     register const I32 first = *little;
     register const char * const littleend = lend;
 
-    if (!first && little >= littleend)
+    if (little >= littleend)
        return (char*)big;
     if (bigend - big < littleend - little)
        return Nullch;
@@ -388,7 +388,7 @@ Perl_rninstr(pTHX_ register const char *big, const char *bigend, const char *lit
     register const I32 first = *little;
     register const char * const littleend = lend;
 
-    if (!first && little >= littleend)
+    if (little >= littleend)
        return (char*)bigend;
     bigbeg = big;
     big = bigend - (littleend - little++);