Checking in changes prior to tagging of version 0.7. Changelog diff is:

diff --git a/.gitignore b/.gitignore
index 9638bdd..b5ded40 100644 (file)
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
+Makefile.old
 MANIFEST.bak
 META.yml
 Makefile

diff --git a/Changes b/Changes
index 7d0269c..94f20c0 100644 (file)
--- a/Changes
+++ b/Changes
@@ -22,3 +22,6 @@ Revision history for Test-NoTabs
 0.6  2009-01-06
      - Remove Test::Group as a dependency as Test::Group
        currently fails its tests.
+
+0.7  2009-01-06
+     - Stop tests dumping files in temporary directory

diff --git a/lib/Test/NoTabs.pm b/lib/Test/NoTabs.pm
index 3525d1e..83fd59a 100644 (file)
--- a/lib/Test/NoTabs.pm
+++ b/lib/Test/NoTabs.pm
@@ -10,7 +10,7 @@ use File::Find;
 
 use vars qw( $VERSION $PERL $UNTAINT_PATTERN $PERL_PATTERN);
 
-$VERSION = '0.6';
+$VERSION = '0.7';
 
 $PERL    = $^X || 'perl';
 $UNTAINT_PATTERN  = qr|^([-+@\w./:\\]+)$|;
@@ -236,6 +236,10 @@ distribution.
 
 Rick Myers and Emanuele Zeppieri also provided valuable feedback.
 
+Patch to fix warnings provided by Florian Ragwitz
+
+Currently maintained by Tomas Doran C<bobtfish@bobtfish.net>
+
 =head1 SEE ALSO
 
 L<Test::More>, L<Test::Pod>. L<Test::Distribution>, L<Test:NoWarnings>

diff --git a/t/11-all.t b/t/11-all.t
index 5ab66cb..25100bc 100644 (file)
--- a/t/11-all.t
+++ b/t/11-all.t
@@ -18,10 +18,10 @@ notabs_ok( $tabbed_file2 );
 my $tabbed_file3 = make_tabbed_file3();
 notabs_ok( $tabbed_file3 );
 
+unlink foreach ( $tabbed_file1, $tabbed_file2, $tabbed_file3 );
 
 sub make_tabbed_file1 {
-  my $tmpdir = tempdir();
-  my ($fh, $filename) = tempfile( DIR => $tmpdir, SUFFIX => '.pL' );
+  my ($fh, $filename) = tempfile();
   print $fh <<'DUMMY';
 #!/usr/bin/perl -w
 
@@ -43,8 +43,7 @@ DUMMY
 }
 
 sub make_tabbed_file2 {
-  my $tmpdir = tempdir();
-  my ($fh, $filename) = tempfile( DIR => $tmpdir, SUFFIX => '.pL' );
+  my ($fh, $filename) = tempfile();
   print $fh <<'DUMMY';
 #!/usr/bin/perl -w
 
@@ -68,8 +67,7 @@ DUMMY
 }
 
 sub make_tabbed_file3 {
-  my $tmpdir = tempdir();
-  my ($fh, $filename) = tempfile( DIR => $tmpdir, SUFFIX => '.pm' );
+  my ($fh, $filename) = tempfile();
   print $fh <<'DUMMY';
 package My::Test;
 

diff --git a/t/12-fail.t b/t/12-fail.t
index 21daa75..b123f91 100644 (file)
--- a/t/12-fail.t
+++ b/t/12-fail.t
@@ -15,6 +15,8 @@ $inc = "-I $inc" if $inc;
     local $/ = undef;
     my $content = <$fh>;
     like( $content, qr/^not ok 1 - Found tabs in '[^']*' on line 4/m, 'tabs found in tmp file 1' );
+    unlink $outfile;
+    system("rm -rf $dir");
 }
 
 {
@@ -24,15 +26,19 @@ $inc = "-I $inc" if $inc;
     local $/ = undef;
     my $content = <$fh>;
     like( $content, qr/^not ok 1 - Found tabs in '[^']*' on line 12/m, 'tabs found in tmp file2 ' );
+    unlink $outfile;
+    system("rm -rf $dir");
 }
 
 {
-    my $file = make_bad_file_3();
+    my ($dir, $file) = make_bad_file_3();
     my ($fh, $outfile) = tempfile();
     ok( `$perl $inc -MTest::NoTabs -e "all_perl_files_ok( '$file' )" 2>&1 > $outfile` );
     local $/ = undef;
     my $content = <$fh>;
     like( $content, qr/^not ok 1 - Found tabs in '[^']*' on line 6/m, 'tabs found in tmp file 3' );
+    unlink $outfile;
+    system("rm -rf $dir");
 }
 
 sub make_bad_file_1 {
@@ -87,6 +93,6 @@ sub new {
 __DATA__
 nick   gerakines       software engineer       22
 DUMMY
-  return $filename;
+  return ($tmpdir, $filename);
 }