Remove with_caller from the deprecations

MX::Types uses it somewhat legitimately, and if this warns, then every module
using MX::Types warns, which is a _lot_ of modules.

diff --git a/Changes b/Changes
index 53bfcb3..5a033b5 100644 (file)
--- a/Changes
+++ b/Changes
@@ -13,7 +13,7 @@ for, noteworthy changes.
   * Removed the long-deprecated Moose::Meta::Role->alias_method metohd. (Dave
     Rolsky).
 
-  * All features which have been declared deprecated now issue a warning using
+  * Most features which have been declared deprecated now issue a warning using
     Moose::Deprecated. Warnings are issued once per calling package, not
     repeatedly. See Moose::Deprecated for information on how you can shut
     these warnings up entirely. Note that deprecated features will eventually

diff --git a/lib/Moose/Deprecated.pm b/lib/Moose/Deprecated.pm
index 485f2d9..760cada 100644 (file)
--- a/lib/Moose/Deprecated.pm
+++ b/lib/Moose/Deprecated.pm
@@ -9,7 +9,6 @@ our $AUTHORITY = 'cpan:STEVAN';
 
 use Package::DeprecationManager -deprecations => {
     'pre-0.94 MetaRole API'       => '0.93',
-    'Moose::Exporter with_caller' => '0.89',
     'Role type'                   => '0.84',
     'subtype without sugar'       => '0.72',
     'type without sugar'          => '0.72',

diff --git a/lib/Moose/Exporter.pm b/lib/Moose/Exporter.pm
index 9a74e19..fe83820 100644 (file)
--- a/lib/Moose/Exporter.pm
+++ b/lib/Moose/Exporter.pm
@@ -37,14 +37,6 @@ sub build_import_methods {
 
     my $exporting_package = $args{exporting_package} ||= caller();
 
-    if ( $args{with_caller} ) {
-        Moose::Deprecated::deprecated(
-            feature => 'Moose::Exporter with_caller',
-            message =>
-                'The with_caller argument for Moose::Exporter has been deprecated'
-        );
-    }
-
     $EXPORT_SPEC{$exporting_package} = \%args;
 
     my @exports_from = $class->_follow_also($exporting_package);