Don't dump autodie from core (was Re: Coring Variable::Magic / autodie fights with string eval in Perl 5.10.x)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
G'day Dave,
Dave Mitchell wrote:
> Okay I think you've convinced me. So basically you'll release a 2.06 which
> is 2.05 + bug documentation; 2.06 goes in 5.10.1; then the bug fix goes in
> 2.07?
Patch attached, including documentation fixes, and TODO tests.
I did slip a small code change in, which fixes a regression that was
introduced (but not spotted) around autodie 1.997ish. Many thanks to rafl
and particularly to Vincent for their help in debugging and documenting.
All the best,
Paul
- --
Paul Fenwick <pjf@perltraining.com.au> | http://perltraining.com.au/
Director of Training | Ph: +61 3 9354 6001
Perl Training Australia | Fax: +61 3 9354 2681
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
iD8DBQFKUgdnx5N6j7FHnlURAhcbAJ4zQ5WujSXK5uNpEfdOp0RMi8FxVQCghU02
Z3ZBYlXddRMOmm9SVC7UPTE=
=qf29
-----END PGP SIGNATURE-----
>From
689bc09292ba5173542d208dca85b6f514c91aba Mon Sep 17 00:00:00 2001
From: Paul Fenwick <pjf@perltraining.com.au>
Date: Tue, 7 Jul 2009 00:11:42 +1000
Subject: [PATCH] Merge autodie 2.06 with core.
NOTE: This commit is different from that on the CPAN by three lines
of POD. A documented bug was fixed, but documentation about this bug
was accidentally not removed from the CPAN release.
Significant changes in this release are:
* BUG: Explicitly documented that autodie does NOT play
nicely with string evals, especially under Perl 5.10.x.
Please avoid using string evals while autodie is in scope.
* TEST: Check for autodie leaking out of scope in the
presence of string evals. (string-eval-leak.t)
Thanks to Florian Ragwitz and Vincent Pit for identifying
this.
* BUGFIX: autodie once again correctly works when used
inside a string eval. (This was accidently broken
somewhere around 1.997-1.998).