Further tradeoffs on relationship sanity checking (augments 9e7525a2)
authorArthur Axel 'fREW' Schmidt <frioux@gmail.com>
Thu, 25 Jul 2013 15:03:58 +0000 (10:03 -0500)
committerPeter Rabbitson <ribasushi@cpan.org>
Wed, 2 Oct 2013 07:25:39 +0000 (09:25 +0200)
commit38fe1ff920de99761b02e5674e83cced61a809a2
tree7a3654fca35e3bb7bd14a6ec90584a0c753ba5c4
parent9ee23fb6415c37b55ec1dc506bd25ccb778bc623
Further tradeoffs on relationship sanity checking (augments 9e7525a2)

It turns out what we did earlier is not enough - what is truly needed is
shutting off *all* checks on non-belongs_to rels. Otherwise industrious devs
will inevitable tie themselves into a circual loading order knot.

The problem (as in 9e7525a2) is not so much that we need to bend over
backwards to support circular loads, but that these problems could very
well be masked by stable hash ordering of perl < 5.18. In other words this
commit serves to prevent perfectly working code from suffering intermittent
and hard-to-debug issues when someone upgrades their perl in 2018.
lib/DBIx/Class/Relationship/HasMany.pm
lib/DBIx/Class/Relationship/HasOne.pm
t/lib/DBICTest/DynamicForeignCols/Computer.pm [new file with mode: 0644]
t/lib/DBICTest/DynamicForeignCols/TestComputer.pm [new file with mode: 0644]
t/relationship/dynamic_foreign_columns.t [new file with mode: 0644]