X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=taint.c;h=1ce27e324f57c3e3c1f7e1a76595101d2a00371a;hb=c4fbe2471f42249bd57e1c071c99349d2331aea5;hp=2a5fedc7b1955b1166b07bbe1f351ffe497258ca;hpb=f8d4b9aa3df7268ea9f1bdecfb17864f5f71ae93;p=p5sagit%2Fp5-mst-13.2.git diff --git a/taint.c b/taint.c index 2a5fedc..1ce27e3 100644 --- a/taint.c +++ b/taint.c @@ -9,17 +9,13 @@ #include "perl.h" void -Perl_taint_proper(pTHX_ const char *f, char *s) +Perl_taint_proper(pTHX_ const char *f, const char *s) { - dTHR; /* just for taint */ char *ug; -#ifdef IV_IS_QUAD +#ifdef HAS_SETEUID DEBUG_u(PerlIO_printf(Perl_debug_log, - "%s %d %" PERL_PRId64 " %" PERL_PRId64 "\n", s, PL_tainted, (IV)PL_uid, (IV)PL_euid)); -#else - DEBUG_u(PerlIO_printf(Perl_debug_log, - "%s %d %lu %lu\n", s, PL_tainted, (unsigned long)PL_uid, (unsigned long)PL_euid)); + "%s %d %"Uid_t_f" %"Uid_t_f"\n", s, PL_tainted, (Uid_t)PL_uid, (Uid_t)PL_euid)); #endif if (PL_tainted) { @@ -67,12 +63,10 @@ Perl_taint_env(pTHX) if (!svp || *svp == &PL_sv_undef) break; if (SvTAINTED(*svp)) { - dTHR; TAINT; taint_proper("Insecure %s%s", "$ENV{DCL$PATH}"); } - if ((mg = mg_find(*svp, 'e')) && MgTAINTEDDIR(mg)) { - dTHR; + if ((mg = mg_find(*svp, PERL_MAGIC_envelem)) && MgTAINTEDDIR(mg)) { TAINT; taint_proper("Insecure directory in %s%s", "$ENV{DCL$PATH}"); } @@ -84,12 +78,10 @@ Perl_taint_env(pTHX) svp = hv_fetch(GvHVn(PL_envgv),"PATH",4,FALSE); if (svp && *svp) { if (SvTAINTED(*svp)) { - dTHR; TAINT; taint_proper("Insecure %s%s", "$ENV{PATH}"); } - if ((mg = mg_find(*svp, 'e')) && MgTAINTEDDIR(mg)) { - dTHR; + if ((mg = mg_find(*svp, PERL_MAGIC_envelem)) && MgTAINTEDDIR(mg)) { TAINT; taint_proper("Insecure directory in %s%s", "$ENV{PATH}"); } @@ -99,7 +91,6 @@ Perl_taint_env(pTHX) /* tainted $TERM is okay if it contains no metachars */ svp = hv_fetch(GvHVn(PL_envgv),"TERM",4,FALSE); if (svp && *svp && SvTAINTED(*svp)) { - dTHR; /* just for taint */ STRLEN n_a; bool was_tainted = PL_tainted; char *t = SvPV(*svp, n_a); @@ -119,7 +110,6 @@ Perl_taint_env(pTHX) for (e = misc_env; *e; e++) { svp = hv_fetch(GvHVn(PL_envgv), *e, strlen(*e), FALSE); if (svp && *svp != &PL_sv_undef && SvTAINTED(*svp)) { - dTHR; /* just for taint */ TAINT; taint_proper("Insecure $ENV{%s}%s", *e); }