X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Funit_load_catalyst_test.t;h=07cc38c25eacd7401f35c845fc404fda6de41726;hb=2824ec8ddc74ffe46554fa224fed19cf459c7d35;hp=b8ec6793b4f0330143e21d10bc297619695a6544;hpb=269194b4f9de3905430a2d1f21f68da13b2b9ed9;p=catagits%2FCatalyst-Runtime.git diff --git a/t/unit_load_catalyst_test.t b/t/unit_load_catalyst_test.t index b8ec679..07cc38c 100644 --- a/t/unit_load_catalyst_test.t +++ b/t/unit_load_catalyst_test.t @@ -5,7 +5,7 @@ use warnings; use FindBin; use lib "$FindBin::Bin/lib"; -use Test::More tests => 56; +use Test::More tests => 59; use FindBin qw/$Bin/; use lib "$Bin/lib"; use Catalyst::Utils; @@ -19,7 +19,7 @@ my $Url = 'http://localhost/'; my $Content = "root index"; my %Meth = ( - $Pkg => [qw|get request crequest|], # exported + $Pkg => [qw|get request ctx_request|], # exported $Class => [qw|local_request remote_request|], # not exported ); @@ -66,7 +66,7 @@ use_ok( $Class ); ### test exported methods again for my $meth ( @{ $Meth{$Pkg} } ) { SKIP: { - ### do a call, we should get a result and perhaps a $c if it's 'crequest'; + ### do a call, we should get a result and perhaps a $c if it's 'ctx_request'; my ($res, $c) = eval { $Pkg->can($meth)->( $Url ) }; ok( 1, " Called $Pkg->$meth( $Url )" ); @@ -78,8 +78,8 @@ use_ok( $Class ); is( $res_as_string, $Content, " Content as expected: $res_as_string" ); - ### some tests for 'crequest' - skip "Context tests skipped for '$meth'", 6 unless $meth eq 'crequest'; + ### some tests for 'ctx_request' + skip "Context tests skipped for '$meth'", 6 unless $meth eq 'ctx_request'; ok( $c, " Context object returned" ); isa_ok( $c, $App, " Object" ); @@ -92,6 +92,18 @@ use_ok( $Class ); } } } +### perl5.8.8 + cat 5.80's Cat::Test->ctx_request didn't return $c the 2nd +### time it was invoked. Without tracking the bug down all the way, it was +### clearly related to the Moose'ification of Cat::Test and a scoping issue +### with a 'my'd variable. Since the same code works fine in 5.10, a bug in +### either Moose or perl 5.8 is suspected. +{ ok( 1, "Testing consistency of ctx_request()" ); + for( 1..2 ) { + my($res, $c) = ctx_request( $Url ); + ok( $c, " Call $_: Context object returned" ); + } +} + # FIXME - These vhosts in tests tests should be somewhere else... sub customize { Catalyst::Test::_customize_request(@_) }