X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Funit_core_uri_for.t;h=4018b03d65d41c9853c2142752fc5db4620266f5;hb=68af38662275bb5259aa49d555205396d0a63fd3;hp=f90436f86b9c132d29c70d81bb9494ff5b810b67;hpb=f1fa79919e2ffd6a1f8219a9883ab3daeb725bf1;p=catagits%2FCatalyst-Runtime.git diff --git a/t/unit_core_uri_for.t b/t/unit_core_uri_for.t index f90436f..4018b03 100644 --- a/t/unit_core_uri_for.t +++ b/t/unit_core_uri_for.t @@ -1,7 +1,7 @@ use strict; use warnings; -use Test::More tests => 17; +use Test::More tests => 18; use URI; use_ok('Catalyst'); @@ -108,18 +108,22 @@ is( Catalyst::uri_for( $context, qw| / foo bar | )->as_string, 'http://127.0.0.1/foo/bar', 'uri is /foo/bar, not //foo/bar' ); -if ( 0 ) { +TODO: { + local $TODO = 'RFCs are for people who, erm - fix this test..'; # Test rfc3986 reserved characters. These characters should all be escaped # according to the RFC, but it is a very big feature change so I've removed it - is( - Catalyst::uri_for( $context, qw|! * ' ( ) ; : @ & = $ , / ? % # [ ]| )->as_string, + no warnings; # Yes, everything in qw is sane + is( + Catalyst::uri_for( $context, qw|! * ' ( ) ; : @ & = $ / ? % # [ ] ,|, )->as_string, 'http://127.0.0.1/%21/%2A/%27/%2B/%29/%3B/%3A/%40/%26/%3D/%24/%2C/%2F/%3F/%25/%23/%5B/%5D', 'rfc 3986 reserved characters' ); } -is( +# jshirley bug t0m fucked in r10097 +is( Catalyst::uri_for( $context, qw|{1} {2}| )->as_string, 'http://127.0.0.1/{1}/{2}', 'not-escaping unreserved characters' ); +