X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Fstorage%2Fdeploy.t;h=61610ba9e35f5f0790897b1aec49d9a2cf09e279;hb=4d93345c2f06a03076dcb43cb256de5c973c203b;hp=3b9435ba6cef3b6db6c8955ac6589c351d734a4f;hpb=91d0c99f913a7d2a03a159c4f14ecde89c43a1bf;p=dbsrgits%2FDBIx-Class.git

diff --git a/t/storage/deploy.t b/t/storage/deploy.t
index 3b9435b..61610ba 100644
--- a/t/storage/deploy.t
+++ b/t/storage/deploy.t
@@ -3,6 +3,7 @@ use warnings;
 
 use Test::More;
 use Test::Exception;
+use Path::Class qw/dir/;
 
 use lib qw(t/lib);
 use DBICTest;
@@ -14,9 +15,15 @@ BEGIN {
     unless DBIx::Class::Optional::Dependencies->req_ok_for ('deploy')
 }
 
-use File::Spec;
-use Path::Class qw/dir/;
-use File::Path qw/make_path remove_tree/;
+local $ENV{DBI_DSN};
+
+# this is how maint/gen_schema did it (connect() to force a storage
+# instance, but no conninfo)
+# there ought to be more code like this in the wild
+like(
+  DBICTest::Schema->connect->deployment_statements('SQLite'),
+  qr/\bCREATE TABLE artist\b/i  # ensure quoting *is* disabled
+);
 
 lives_ok( sub {
     my $parse_schema = DBICTest->init_schema(no_deploy => 1);
@@ -24,23 +31,49 @@ lives_ok( sub {
     $parse_schema->resultset("Artist")->all();
 }, 'artist table deployed correctly' );
 
-my $schema = DBICTest->init_schema();
+my $schema = DBICTest->init_schema( quote_names => 1 );
 
-my $var = dir (qw| t var create_ddl_dir |);
--d $var
-    or make_path( "$var" )
-    or die "can't create $var: $!";
+my $var = dir ("t/var/ddl_dir-$$");
+$var->mkpath unless -d $var;
 
 my $test_dir_1 = $var->subdir ('test1', 'foo', 'bar' );
-remove_tree( "$test_dir_1" ) if -d $test_dir_1;
-$schema->create_ddl_dir( undef, undef, $test_dir_1 );
+$test_dir_1->rmtree if -d $test_dir_1;
+$schema->create_ddl_dir( [qw(SQLite MySQL)], 1, $test_dir_1 );
 
 ok( -d $test_dir_1, 'create_ddl_dir did a make_path on its target dir' );
 ok( scalar( glob $test_dir_1.'/*.sql' ), 'there are sql files in there' );
 
-TODO: {
-    local $TODO = 'we should probably add some tests here for actual deployability of the DDL?';
-    ok( 0 );
+my $less = $schema->clone;
+$less->unregister_source('BindType');
+$less->create_ddl_dir( [qw(SQLite MySQL)], 2, $test_dir_1, 1 );
+
+for (
+  [ SQLite => '"' ],
+  [ MySQL => '`' ],
+) {
+  my $type = $_->[0];
+  my $q = quotemeta($_->[1]);
+
+  for my $f (map { $test_dir_1->file("DBICTest-Schema-${_}-$type.sql") } qw(1 2) ) {
+    like scalar $f->slurp, qr/CREATE TABLE ${q}track${q}/, "Proper quoting in $f";
+  }
+
+  {
+    local $TODO = 'SQLT::Producer::MySQL has no knowledge of the mythical beast of quoting...'
+      if $type eq 'MySQL';
+
+    my $f = $test_dir_1->file("DBICTest-Schema-1-2-$type.sql");
+    like scalar $f->slurp, qr/DROP TABLE ${q}bindtype_test${q}/, "Proper quoting in diff $f";
+  }
+}
+
+{
+  local $TODO = 'we should probably add some tests here for actual deployability of the DDL?';
+  ok( 0 );
+}
+
+END {
+  $var->rmtree;
 }
 
 done_testing;