X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Fplugin_new_method_backcompat.t;h=c0cb13a6bb6450ba12cb7b75ef993a9bb572e49a;hb=9b1db775e21c29d58957aa1eb7f1446c83b4967a;hp=7aaef8bb6571d0bedc440e34a792349c68f043f8;hpb=eb7d1369a13ed9a451972f256d1ded95966753aa;p=catagits%2FCatalyst-Runtime.git diff --git a/t/plugin_new_method_backcompat.t b/t/plugin_new_method_backcompat.t index 7aaef8b..c0cb13a 100644 --- a/t/plugin_new_method_backcompat.t +++ b/t/plugin_new_method_backcompat.t @@ -1,17 +1,29 @@ # Test that plugins with their own new method don't break applications. -# 5.70 creates all of the request/response structure itself in prepare, +# 5.70 creates all of the request/response structure itself in prepare, # and as the new method in our plugin just blesses our args, that works nicely. -# In 5.80, we rely on the new method to appropriately initialise data +# In 5.80, we rely on the new method to appropriately initialise data # structures, and therefore we need to inline a new method on MyApp to ensure # that plugins don't get it wrong for us. # Also tests method modifiers and etc in MyApp.pm still work as expected. - +use Test::More tests => 8; +use Test::Exception; +use Moose::Util qw/find_meta/; use FindBin; -use lib "$FindBin::Bin/lib";use Test::More tests => 3; +use lib "$FindBin::Bin/lib"; + +use Catalyst::Test qw/TestAppPluginWithConstructor/; +ok find_meta('TestAppPluginWithConstructor')->is_immutable, + 'Am immutable after use'; + +ok request('/foo')->is_success, 'Can get /foo'; +is $TestAppPluginWithConstructor::MODIFIER_FIRED, 1, 'Before modifier was fired correctly.'; + +my $warning; +local $SIG{__WARN__} = sub { $warning = $_[0] }; +eval "use TestAppBadlyImmutable;"; +like $warning, qr/\QYou made your application class (TestAppBadlyImmutable) immutable/, + 'An application class that is already immutable but does not inline the constructor warns at ->setup'; -use Catalyst::Test qw/TestAppPluginWithNewMethod/; # 1 test for adding a modifer not throwing. -ok request('/foo')->is_success; -is $TestAppPluginWithNewMethod::MODIFIER_FIRED, 1, 'Before modifier was fired correctly.';