X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Foverloaded-coderefs.t;h=058db1115bebf2dff187e21edec6ae9446882d5e;hb=350f2de6ebd85fd6fc5699c0773e6737756bac36;hp=5e59ae8f9061019729ca04f8bd23068c614ba247;hpb=235b63fc17ce97b0d16c5cb7f81a4423ce1427b5;p=gitmo%2FMoo.git

diff --git a/t/overloaded-coderefs.t b/t/overloaded-coderefs.t
index 5e59ae8..058db11 100644
--- a/t/overloaded-coderefs.t
+++ b/t/overloaded-coderefs.t
@@ -2,30 +2,31 @@ use strict;
 use warnings;
 use Test::More;
 
+my $codified = 0;
 {
-	package Dark::Side;
-	use overload
-		q[&{}]   => sub { shift->to_code },
-		fallback => 1;
-	sub new {
-		my $class = shift;
-		my $code = shift;
-		bless \$code, $class;
-	}
-	sub to_code {
-		my $self = shift;
-		eval "sub { $$self }";
-	}
+  package Dark::Side;
+  use overload
+    q[&{}]   => sub { $codified++; shift->to_code },
+    fallback => 1;
+  sub new {
+    my $class = shift;
+    my $code = shift;
+    bless \$code, $class;
+  }
+  sub to_code {
+    my $self = shift;
+    eval "sub { $$self }";
+  }
 }
 
 {
-	package The::Force;
-	use Sub::Quote;
-	use base 'Dark::Side';
-	sub to_code {
-		my $self = shift;
-		return quote_sub $$self;
-	}
+  package The::Force;
+  use Sub::Quote;
+  use base 'Dark::Side';
+  sub to_code {
+    my $self = shift;
+    return quote_sub $$self;
+  }
 }
 
 my $darkside = Dark::Side->new('my $dummy = "join the dark side"; $_[0] * 2');
@@ -34,16 +35,20 @@ is($darkside->(6), 12, 'check Dark::Side coderef');
 my $theforce = The::Force->new('my $dummy = "use the force Luke"; $_[0] * 2');
 is($theforce->(6), 12, 'check The::Force coderef');
 
+my $luke = The::Force->new('my $z = "I am your father"');
 {
-	package Doubleena;
-	use Moo;
-	has a => (is => "ro", coerce => $darkside, isa => sub { 1 });
-	has b => (is => "ro", coerce => $theforce, isa => The::Force->new('my $z = "I am your father"'));
+  package Doubleena;
+  use Moo;
+  has a => (is => "rw", coerce => $darkside, isa => sub { 1 });
+  has b => (is => "rw", coerce => $theforce, isa => $luke);
 }
 
 my $o = Doubleena->new(a => 11, b => 12);
 is($o->a, 22, 'non-Sub::Quoted inlined coercion overload works');
 is($o->b, 24, 'Sub::Quoted inlined coercion overload works');
+my $codified_before = $codified;
+$o->a(5);
+is($codified_before, $codified, "repeated calls to accessor don't re-trigger overload");
 
 use B::Deparse;
 my $constructor = B::Deparse->new->coderef2text(Doubleena->can('new'));
@@ -52,4 +57,20 @@ like($constructor, qr{use the force Luke}, 'Sub::Quoted coercion got inlined');
 unlike($constructor, qr{join the dark side}, 'non-Sub::Quoted coercion was not inlined');
 like($constructor, qr{I am your father}, 'Sub::Quoted isa got inlined');
 
+require Scalar::Util;
+is(
+  Scalar::Util::refaddr($luke),
+  Scalar::Util::refaddr(
+    Moo->_constructor_maker_for("Doubleena")->all_attribute_specs->{"b"}{"isa"}
+  ),
+  '$spec->{isa} reference is not mutated',
+);
+is(
+  Scalar::Util::refaddr($theforce),
+  Scalar::Util::refaddr(
+    Moo->_constructor_maker_for("Doubleena")->all_attribute_specs->{"b"}{"coerce"}
+  ),
+  '$spec->{coerce} reference is not mutated',
+);
+
 done_testing;