X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Fop%2Fpack.t;h=53f44c117975e52d17d87677c4cfbf9ff759ace9;hb=71f93cb90a7a9a642b3934238bdb85ce8183854f;hp=75ddd1e5a905d30c539b40127837df731a222e18;hpb=3020ec7a966d29011d9714679eba0b8797d51b1e;p=p5sagit%2Fp5-mst-13.2.git diff --git a/t/op/pack.t b/t/op/pack.t index 75ddd1e..53f44c1 100755 --- a/t/op/pack.t +++ b/t/op/pack.t @@ -6,7 +6,7 @@ BEGIN { require './test.pl'; } -plan tests => 1470; +plan tests => 5852; use strict; use warnings; @@ -15,24 +15,8 @@ use Config; my $Is_EBCDIC = (defined $Config{ebcdic} && $Config{ebcdic} eq 'define'); my $Perl = which_perl(); -sub encode { - my @result = @_; - foreach (@result) { - s/([[:cntrl:]\177 ])/sprintf "\\%03o", ord $1/ge if defined; - } - @result; -} - sub encode_list { - my @result = @_; - foreach (@result) { - if (defined) { - s/([[:cntrl:]\177])/sprintf "\\%03o", ord $1/ge; - $_ = qq("$_"); - } else { - $_ = 'undef'; - } - } + my @result = map {_qq($_)} @_; if (@result == 1) { return @result; } @@ -42,12 +26,12 @@ sub encode_list { sub list_eq ($$) { my ($l, $r) = @_; - return unless @$l == @$r; + return 0 unless @$l == @$r; for my $i (0..$#$l) { if (defined $l->[$i]) { - return unless defined ($r->[$i]) && $l->[$i] eq $r->[$i]; + return 0 unless defined ($r->[$i]) && $l->[$i] eq $r->[$i]; } else { - return if defined $r->[$i] + return 0 if defined $r->[$i] } } return 1; @@ -132,11 +116,51 @@ sub list_eq ($$) { is(scalar(@y), 2); is($y[1], 130); + $x = pack('w*', 5000000000); $y = ''; + eval { + use Math::BigInt; + $y = pack('w*', Math::BigInt::->new(5000000000)); + }; + is($x, $y); + + $x = pack 'w', ~0; + $y = pack 'w', (~0).''; + is($x, $y); + is(unpack ('w',$x), ~0); + is(unpack ('w',$y), ~0); + + $x = pack 'w', ~0 - 1; + $y = pack 'w', (~0) - 2; + + if (~0 - 1 == (~0) - 2) { + is($x, $y, "NV arithmetic"); + } else { + isnt($x, $y, "IV/NV arithmetic"); + } + cmp_ok(unpack ('w',$x), '==', ~0 - 1); + cmp_ok(unpack ('w',$y), '==', ~0 - 2); + + # These should spot that pack 'w' is using NV, not double, on platforms + # where IVs are smaller than doubles, and harmlessly pass elsewhere. + # (tests for change 16861) + my $x0 = 2**54+3; + my $y0 = 2**54-2; + + $x = pack 'w', $x0; + $y = pack 'w', $y0; + + if ($x0 == $y0) { + is($x, $y, "NV arithmetic"); + } else { + isnt($x, $y, "IV/NV arithmetic"); + } + cmp_ok(unpack ('w',$x), '==', $x0); + cmp_ok(unpack ('w',$y), '==', $y0); } { - # test exeptions + # test exceptions my $x; eval { $x = unpack 'w', pack 'C*', 0xff, 0xff}; like($@, qr/^Unterminated compressed integer/); @@ -146,6 +170,56 @@ sub list_eq ($$) { eval { $x = unpack 'w', pack 'C*', 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; like($@, qr/^Unterminated compressed integer/); + + eval { $x = pack 'w', -1 }; + like ($@, qr/^Cannot compress negative numbers/); + + eval { $x = pack 'w', '1'x(1 + length ~0) . 'e0' }; + like ($@, qr/^Can only compress unsigned integers/); + + SKIP: { + # Is this a stupid thing to do on VMS, VOS and other unusual platforms? + + skip "-- the IEEE infinity model is unavailable in this configuration." + if (($^O eq 'VMS') && !defined($Config{useieee})); + + my $inf = eval '2**10000'; + + skip "Couldn't generate infinity - got error '$@'" + unless defined $inf and $inf == $inf / 2 and $inf + 1 == $inf; + + local our $TODO; + $TODO = "VOS needs a fix for posix-1022 to pass this test." + if ($^O eq 'vos'); + + eval { $x = pack 'w', $inf }; + like ($@, qr/^Cannot compress integer/, "Cannot compress integer"); + } + + SKIP: { + + skip "-- the full range of an IEEE double may not be available in this configuration." + if (($^O eq 'VMS') && !defined($Config{useieee})); + + # This should be about the biggest thing possible on an IEEE double + my $big = eval '2**1023'; + + skip "Couldn't generate 2**1023 - got error '$@'", 3 + unless defined $big and $big != $big / 2; + + eval { $x = pack 'w', $big }; + is ($@, '', "Should be able to pack 'w', $big # 2**1023"); + + my $y = eval {unpack 'w', $x}; + is ($@, '', + "Should be able to unpack 'w' the result of pack 'w', $big # 2**1023"); + + # I'm getting about 1e-16 on FreeBSD + my $quotient = int (100 * ($y - $big) / $big); + ok($quotient < 2 && $quotient > -2, + "Round trip pack, unpack 'w' of $big is withing 1% ($quotient%)"); + } + } # @@ -201,7 +275,7 @@ foreach my $t (@templates) { my @t = eval { unpack("$t*", pack("$t*", 12, 34)) }; # quads not supported everywhere - skip "Quads not supported", 4 if $@ =~ /Invalid type in pack/; + skip "Quads not supported", 4 if $@ =~ /Invalid type/; is( $@, '' ); is(scalar @t, 2); @@ -284,9 +358,9 @@ foreach ( my ($what, $template, $in, $out) = @$_; my $got = $what eq 'u' ? (unpack $template, $in) : (pack $template, $in); unless (is($got, $out)) { - ($in, $out, $got) = encode ($in, $out, $got); my $un = $what eq 'u' ? 'un' : ''; - print "# ${un}pack ('$template', \"$in\") gave $out not $got\n"; + print "# ${un}pack ('$template', "._qq($in).') gave '._qq($out). + ' not '._qq($got)."\n"; } } @@ -316,7 +390,7 @@ sub numbers_with_total { SKIP: { my $out = eval {unpack($format, pack($format, $_))}; skip "cannot pack '$format' on this perl", 2 if - $@ =~ /Invalid type in pack: '$format'/; + $@ =~ /Invalid type '$format'/; is($@, ''); is($out, $_); @@ -329,14 +403,14 @@ sub numbers_with_total { # UVs (in which case ~0 is NV, ~0-1 will be the same NV) then we can't # correctly in perl calculate UV totals for long checksums, as pp_unpack # is using UV maths, and we've only got NVs. - $skip_if_longer_than = $Config{d_nv_preserves_uv_bits}; + $skip_if_longer_than = $Config{nv_preserves_uv_bits}; } foreach ('', 1, 2, 3, 15, 16, 17, 31, 32, 33, 53, 54, 63, 64, 65) { SKIP: { my $sum = eval {unpack "%$_$format*", pack "$format*", @_}; skip "cannot pack '$format' on this perl", 3 - if $@ =~ /Invalid type in pack: '$format'/; + if $@ =~ /Invalid type '$format'/; is($@, ''); ok(defined $sum); @@ -385,14 +459,13 @@ sub numbers_with_total { $calc_sum = 0; } - if (is( $calc_sum, $sum)) { - print "# unpack '%$_$format' gave $sum\n"; + if ($calc_sum == $sum) { # HAS to be ==, not eq (so no is()). + ok ("unpack '%$_$format' gave $sum"); } else { my $delta = 1.000001; if ($format =~ tr /dDfF// && ($calc_sum <= $sum * $delta && $calc_sum >= $sum / $delta)) { - pass; - print "# unpack '%$_$format' gave $sum, expected $calc_sum\n"; + pass ("unpack '%$_$format' gave $sum, expected $calc_sum"); } else { my $text = ref $total ? &$total($len) : $total; fail; @@ -458,26 +531,41 @@ is(pack("V", 0xdeadbeef), "\xef\xbe\xad\xde"); my ($x, $y, $z); eval { ($x) = unpack '/a*','hello' }; - like($@, qr!/ must follow a numeric type!); + like($@, qr!'/' must follow a numeric type!); + undef $x; + eval { $x = unpack '/a*','hello' }; + like($@, qr!'/' must follow a numeric type!); + undef $x; eval { ($z,$x,$y) = unpack 'a3/A C/a* C/Z', "003ok \003yes\004z\000abc" }; is($@, ''); is($z, 'ok'); is($x, 'yes'); is($y, 'z'); + undef $z; + eval { $z = unpack 'a3/A C/a* C/Z', "003ok \003yes\004z\000abc" }; + is($@, ''); + is($z, 'ok'); + + undef $x; eval { ($x) = pack '/a*','hello' }; - like($@, qr!Invalid type in pack: '/'!); + like($@, qr!Invalid type '/'!); + undef $x; + eval { $x = pack '/a*','hello' }; + like($@, qr!Invalid type '/'!); $z = pack 'n/a* N/Z* w/A*','string','hi there ','etc'; my $expect = "\000\006string\0\0\0\012hi there \000\003etc"; is($z, $expect); + undef $x; $expect = 'hello world'; eval { ($x) = unpack ("w/a", chr (11) . "hello world!")}; is($x, $expect); is($@, ''); + undef $x; # Doing this in scalar context used to fail. eval { $x = unpack ("w/a", chr (11) . "hello world!")}; is($@, ''); @@ -490,12 +578,14 @@ is(pack("V", 0xdeadbeef), "\xef\xbe\xad\xde"); ) { my ($pat, $in, $expect) = @$_; + undef $x; eval { ($x) = unpack $pat, $in }; is($@, ''); is($x, $expect) || printf "# list unpack ('$pat', '$in') gave %s, expected '$expect'\n", encode_list ($x); + undef $x; eval { $x = unpack $pat, $in }; is($@, ''); is($x, $expect) || @@ -505,29 +595,39 @@ is(pack("V", 0xdeadbeef), "\xef\xbe\xad\xde"); # / with # - eval { ($z,$x,$y) = unpack < 'AAA', b => 'BBB' ); + my $env = pack( 'S(S/A*S/A*)*', @Env/2, @Env ); + + # unpack full length - ok + my @pup = unpack( 'S/(S/A* S/A*)', $env ); + is( "@pup", "@Env" ); + + # warn when count/code goes beyond end of string + # \0002 \0001 a \0003 AAA \0001 b \0003 BBB + # 2 4 5 7 10 1213 + eval { @pup = unpack( 'S/(S/A* S/A*)', substr( $env, 0, 13 ) ) }; + like( $@, qr{length/code after end of string} ); + + # postfix repeat count + $env = pack( '(S/A* S/A*)' . @Env/2, @Env ); + + # warn when count/code goes beyond end of string + # \0001 a \0003 AAA \0001 b \0003 BBB + # 2 3c 5 8 10 11 13 16 + eval { @pup = unpack( '(S/A* S/A*)' . @Env/2, substr( $env, 0, 11 ) ) }; + like( $@, qr{length/code after end of string} ); + + # catch stack overflow/segfault + eval { $_ = pack( ('(' x 105) . 'A' . (')' x 105) ); }; + like( $@, qr{Too deeply nested \(\)-groups} ); +} + +{ # syntax checks (W.Laun) + use warnings; + my @warning; + local $SIG{__WARN__} = sub { + push( @warning, $_[0] ); + }; + eval { my $s = pack( 'Ax![4c]A', 1..5 ); }; + like( $@, qr{Malformed integer in \[\]} ); + + eval { my $buf = pack( '(c/*a*)', 'AAA', 'BB' ); }; + like( $@, qr{'/' does not take a repeat count} ); + + eval { my @inf = unpack( 'c/1a', "\x03AAA\x02BB" ); }; + like( $@, qr{'/' does not take a repeat count} ); + + eval { my @inf = unpack( 'c/*a', "\x03AAA\x02BB" ); }; + like( $@, qr{'/' does not take a repeat count} ); + + # white space where possible + my @Env = ( a => 'AAA', b => 'BBB' ); + my $env = pack( ' S ( S / A* S / A* )* ', @Env/2, @Env ); + my @pup = unpack( ' S / ( S / A* S / A* ) ', $env ); + is( "@pup", "@Env" ); + + # white space in 4 wrong places + for my $temp ( 'A ![4]', 'A [4]', 'A *', 'A 4' ){ + eval { my $s = pack( $temp, 'B' ); }; + like( $@, qr{Invalid type } ); + } + + # warning for commas + @warning = (); + my $x = pack( 'I,A', 4, 'X' ); + like( $warning[0], qr{Invalid type ','} ); + + # comma warning only once + @warning = (); + $x = pack( 'C(C,C)C,C', 65..71 ); + like( scalar @warning, 1 ); + + # forbidden code in [] + eval { my $x = pack( 'A[@4]', 'XXXX' ); }; + like( $@, qr{Within \[\]-length '\@' not allowed} ); + + # @ repeat default 1 + my $s = pack( 'AA@A', 'A', 'B', 'C' ); + my @c = unpack( 'AA@A', $s ); + is( $s, 'AC' ); + is( "@c", "A C C" ); + + # no unpack code after / + eval { my @a = unpack( "C/", "\3" ); }; + like( $@, qr{Code missing after '/'} ); + +} + +{ # Repeat count [SUBEXPR] + my @codes = qw( x A Z a c C B b H h s v n S i I l V N L p P f F d + s! S! i! I! l! L! j J); + my $G; + if (eval { pack 'q', 1 } ) { + push @codes, qw(q Q); + } else { + push @codes, qw(c C); # Keep the count the same + } + if (eval { pack 'D', 1 } ) { + push @codes, 'D'; + } else { + push @codes, 'd'; # Keep the count the same + } + + my %val; + @val{@codes} = map { / [Xx] (?{ undef }) + | [AZa] (?{ 'something' }) + | C (?{ 214 }) + | c (?{ 114 }) + | [Bb] (?{ '101' }) + | [Hh] (?{ 'b8' }) + | [svnSiIlVNLqQjJ] (?{ 10111 }) + | [FfDd] (?{ 1.36514538e67 }) + | [pP] (?{ "try this buffer" }) + /x; $^R } @codes; + my @end = (0x12345678, 0x23456781, 0x35465768, 0x15263748); + my $end = "N4"; + + for my $type (@codes) { + my @list = $val{$type}; + @list = () unless defined $list[0]; + for my $count ('', '3', '[11]') { + my $c = 1; + $c = $1 if $count =~ /(\d+)/; + my @list1 = @list; + @list1 = (@list1) x $c unless $type =~ /[XxAaZBbHhP]/; + for my $groupend ('', ')2', ')[8]') { + my $groupbegin = ($groupend ? '(' : ''); + $c = 1; + $c = $1 if $groupend =~ /(\d+)/; + my @list2 = (@list1) x $c; + + my $junk1 = "$groupbegin $type$count $groupend"; + # print "# junk1=$junk1\n"; + my $p = pack $junk1, @list2; + my $half = int( (length $p)/2 ); + for my $move ('', "X$half", "X!$half", 'x1', 'x!8', "x$half") { + my $junk = "$junk1 $move"; + # print "# junk='$junk', list=(@list2)\n"; + $p = pack "$junk $end", @list2, @end; + my @l = unpack "x[$junk] $end", $p; + is(scalar @l, scalar @end); + is("@l", "@end", "skipping x[$junk]"); + } + } + } + } +} + +# / is recognized after spaces in scalar context +# XXXX no spaces are allowed in pack... In pack only before the slash... +is(scalar unpack('A /A Z20', pack 'A/A* Z20', 'bcde', 'xxxxx'), 'bcde'); +is(scalar unpack('A /A /A Z20', '3004bcde'), 'bcde'); + +{ # X! and x! + my $t = 'C[3] x!8 C[2]'; + my @a = (0x73..0x77); + my $p = pack($t, @a); + is($p, "\x73\x74\x75\0\0\0\0\0\x76\x77"); + my @b = unpack $t, $p; + is(scalar @b, scalar @a); + is("@b", "@a", 'x!8'); + $t = 'x[5] C[6] X!8 C[2]'; + @a = (0x73..0x7a); + $p = pack($t, @a); + is($p, "\0\0\0\0\0\x73\x74\x75\x79\x7a"); + @b = unpack $t, $p; + @a = (0x73..0x75, 0x79, 0x7a, 0x79, 0x7a); + is(scalar @b, scalar @a); + is("@b", "@a"); +} + +{ # struct {char c1; double d; char cc[2];} + my $t = 'C x![d] d C[2]'; + my @a = (173, 1.283476517e-45, 42, 215); + my $p = pack $t, @a; + ok( length $p); + my @b = unpack "$t X[$t] $t", $p; # Extract, step back, extract again + is(scalar @b, 2 * scalar @a); + $b = "@b"; + $b =~ s/(?:17000+|16999+)\d+(e-45) /17$1 /gi; # stringification is gamble + is($b, "@a @a"); + + my $warning; + local $SIG{__WARN__} = sub { + $warning = $_[0]; + }; + @b = unpack "x[C] x[$t] X[$t] X[C] $t", "$p\0"; + + is($warning, undef); + is(scalar @b, scalar @a); + $b = "@b"; + $b =~ s/(?:17000+|16999+)\d+(e-45) /17$1 /gi; # stringification is gamble + is($b, "@a"); +} + +is(length(pack("j", 0)), $Config{ivsize}); +is(length(pack("J", 0)), $Config{uvsize}); +is(length(pack("F", 0)), $Config{nvsize}); + +numbers ('j', -2147483648, -1, 0, 1, 2147483647); +numbers ('J', 0, 1, 2147483647, 2147483648, 4294967295); +numbers ('F', -(2**34), -1, 0, 1, 2**34); +SKIP: { + my $t = eval { unpack("D*", pack("D", 12.34)) }; + + skip "Long doubles not in use", 56 if $@ =~ /Invalid type/; + + is(length(pack("D", 0)), $Config{longdblsize}); + numbers ('D', -(2**34), -1, 0, 1, 2**34); +} + +# Maybe this knowledge needs to be "global" for all of pack.t +# Or a "can checksum" which would effectively be all the number types" +my %cant_checksum = map {$_=> 1} qw(A Z u w); +# not a b B h H +foreach my $template (qw(A Z c C s S i I l L n N v V q Q j J f d F D u U w)) { + SKIP: { + my $packed = eval {pack "${template}4", 1, 4, 9, 16}; + if ($@) { + die unless $@ =~ /Invalid type '$template'/; + skip ("$template not supported on this perl", + $cant_checksum{$template} ? 4 : 8); + } + my @unpack4 = unpack "${template}4", $packed; + my @unpack = unpack "${template}*", $packed; + my @unpack1 = unpack "${template}", $packed; + my @unpack1s = scalar unpack "${template}", $packed; + my @unpack4s = scalar unpack "${template}4", $packed; + my @unpacks = scalar unpack "${template}*", $packed; + + my @tests = ( ["${template}4 vs ${template}*", \@unpack4, \@unpack], + ["scalar ${template} ${template}", \@unpack1s, \@unpack1], + ["scalar ${template}4 vs ${template}", \@unpack4s, \@unpack1], + ["scalar ${template}* vs ${template}", \@unpacks, \@unpack1], + ); + + unless ($cant_checksum{$template}) { + my @unpack4_c = unpack "\%${template}4", $packed; + my @unpack_c = unpack "\%${template}*", $packed; + my @unpack1_c = unpack "\%${template}", $packed; + my @unpack1s_c = scalar unpack "\%${template}", $packed; + my @unpack4s_c = scalar unpack "\%${template}4", $packed; + my @unpacks_c = scalar unpack "\%${template}*", $packed; + + push @tests, + ( ["% ${template}4 vs ${template}*", \@unpack4_c, \@unpack_c], + ["% scalar ${template} ${template}", \@unpack1s_c, \@unpack1_c], + ["% scalar ${template}4 vs ${template}*", \@unpack4s_c, \@unpack_c], + ["% scalar ${template}* vs ${template}*", \@unpacks_c, \@unpack_c], + ); + } + foreach my $test (@tests) { + ok (list_eq ($test->[1], $test->[2]), $test->[0]) || + printf "# unpack gave %s expected %s\n", + encode_list (@{$test->[1]}), encode_list (@{$test->[2]}); + } + } +} + +ok(pack('u2', 'AA'), "[perl #8026]"); # used to hang and eat RAM in perl 5.7.2 + +$_ = pack('c', 65); # 'A' would not be EBCDIC-friendly +is(unpack('c'), 65, "one-arg unpack (change #18751)"); # defaulting to $_ + +{ + my $a = "X\t01234567\n" x 100; + my @a = unpack("(a1 c/a)*", $a); + is(scalar @a, 200, "[perl #15288]"); + is($a[-1], "01234567\n", "[perl #15288]"); + is($a[-2], "X", "[perl #15288]"); }