X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Fop%2Fgroups.t;h=6110fb8c4f589da9813e275ca6d13aeea38927d4;hb=3ab3c9b49fb213f2b1d4cda8797de17be82b2b15;hp=78a748fddd3e6b16586d0e5f6b4c8693cb72e531;hpb=f62c0cf247ab0260b680faf6bc722682ba662635;p=p5sagit%2Fp5-mst-13.2.git

diff --git a/t/op/groups.t b/t/op/groups.t
index 78a748f..6110fb8 100755
--- a/t/op/groups.t
+++ b/t/op/groups.t
@@ -1,6 +1,33 @@
 #!./perl
 
-$ENV{PATH} = '/bin:/usr/bin:/usr/xpg4/bin:/usr/ucb';
+$ENV{PATH} ="/bin:/usr/bin:/usr/xpg4/bin:/usr/ucb" .
+    exists $ENV{PATH} ? ":$ENV{PATH}" : "";
+$ENV{LC_ALL} = "C"; # so that external utilities speak English
+$ENV{LANGUAGE} = 'C'; # GNU locale extension
+
+BEGIN {
+    chdir 't';
+    @INC = '../lib';
+
+    require Config;
+    if ($@) {
+	print "1..0 # Skip: no Config\n";
+    } else {
+	Config->import;
+    }
+}
+
+sub quit {
+    print "1..0 # Skip: no `id` or `groups`\n";
+    exit 0;
+}
+
+unless (eval { getgrgid(0); 1 }) {
+    print "1..0 # Skip: getgrgid() not implemented\n";
+    exit 0;
+}
+
+quit() if (($^O eq 'MSWin32' || $^O eq 'NetWare') or $^O =~ /lynxos/i);
 
 # We have to find a command that prints all (effective
 # and real) group names (not ids).  The known commands are:
@@ -11,6 +38,7 @@ $ENV{PATH} = '/bin:/usr/bin:/usr/xpg4/bin:/usr/ucb';
 # Beware 2: id -Gn or id -a format might be id(name) or name(id).
 # Beware 3: the groups= might be anywhere in the id output.
 # Beware 4: groups can have spaces ('id -a' being the only defense against this)
+# Beware 5: id -a might not contain the groups= part.
 #
 # That is, we might meet the following:
 #
@@ -28,7 +56,7 @@ GROUPS: {
     if (($groups = `id -a 2>/dev/null`) ne '') {
 	# $groups is of the form:
 	# uid=39957(gsar) gid=22(users) groups=33536,39181,22(users),0(root),1067(dev)
-	last GROUPS;
+	last GROUPS if $groups =~ /groups=/;
     }
     if (($groups = `id -Gn 2>/dev/null`) ne '') {
 	# $groups could be of the form:
@@ -45,16 +73,19 @@ GROUPS: {
 #
 # If these tests fail, report the particular incantation you use
 # on this platform to find *all* the groups that an arbitrary
-# luser may belong to, using the 'perlbug' program.
+# user may belong to, using the 'perlbug' program.
 EOM
 	}
 	last GROUPS;
     }
     # Okay, not today.
-    print "1..0\n";
-    exit 0;
+    quit();
 }
 
+chomp($groups);
+
+print "# groups = $groups\n";
+
 # Remember that group names can contain whitespace, '-', et cetera.
 # That is: do not \w, do not \S.
 if ($groups =~ /groups=(.+)( [ug]id=|$)/) {
@@ -64,11 +95,11 @@ if ($groups =~ /groups=(.+)( [ug]id=|$)/) {
     # prefer names over numbers
     for (@g0) {
         # 42(zot me)
-	if (/^(\d+)(?:\(([^)]+)\))?$/) {
+	if (/^(\d+)(?:\(([^)]+)\))?/) {
 	    push @g1, ($2 || $1);
 	}
         # zot me(42)
-	elsif (/^([^(]*)\((\d+)\)$/) {
+	elsif (/^([^(]*)\((\d+)\)/) {
 	    push @g1, ($1 || $2);
 	}
 	else {
@@ -85,13 +116,13 @@ print "1..2\n";
 
 $pwgid = $( + 0;
 ($pwgnam) = getgrgid($pwgid);
-@basegroup{$pwgid,$pwgnam} = (1,1);
-
 $seen{$pwgid}++;
 
+print "# pwgid = $pwgid, pwgnam = $pwgnam\n";
+
 for (split(' ', $()) {
-    next if $seen{$_}++;
     ($group) = getgrgid($_);
+    next if (! defined $group or ! grep { $_ eq $group } @gr) and $seen{$_}++;
     if (defined $group) {
 	push(@gr, $group);
     }
@@ -100,18 +131,37 @@ for (split(' ', $()) {
     }
 } 
 
-if ($^O eq "uwin") { # Or anybody else who can have spaces in group names.
+print "# gr = @gr\n";
+
+if ($^O =~ /^(?:uwin|cygwin|interix|solaris)$/) {
+	# Or anybody else who can have spaces in group names.
 	$gr1 = join(' ', grep(!$did{$_}++, sort split(' ', join(' ', @gr))));
 } else {
 	$gr1 = join(' ', sort @gr);
 }
 
+if ($Config{myuname} =~ /^cygwin_nt/i) { # basegroup on CYGWIN_NT has id = 0.
+    @basegroup{$pwgid,$pwgnam} = (0,0);
+} else {
+    @basegroup{$pwgid,$pwgnam} = (1,1);
+}
 $gr2 = join(' ', grep(!$basegroup{$_}++, sort split(' ',$groups)));
 
-if ($gr1 eq $gr2) {
+my $ok1 = 0;
+if ($gr1 eq $gr2 || ($gr1 eq '' && $gr2 eq $pwgid)) {
     print "ok 1\n";
+    $ok1++;
 }
-else {
+elsif ($Config{myuname} =~ /^cygwin_nt/i) { # basegroup on CYGWIN_NT has id = 0.
+    # Retry in default unix mode
+    %basegroup = ( $pwgid => 1, $pwgnam => 1 );
+    $gr2 = join(' ', grep(!$basegroup{$_}++, sort split(' ',$groups)));
+    if ($gr1 eq $gr2 || ($gr1 eq '' && $gr2 eq $pwgid)) {
+	print "ok 1 # This Cygwin behaves like Unix (Win2k?)\n";
+	$ok1++;
+    }
+}
+unless ($ok1) {
     print "#gr1 is <$gr1>\n";
     print "#gr2 is <$gr2>\n";
     print "not ok 1\n";