X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Flib%2Fdbixcsl_common_tests.pm;h=ad4005767733ed0e1c25da5a39e1209b8a4c6aa1;hb=0da287c87626b38a802fda7b8ca324dd62634851;hp=d8dc3f58b07732e55d5b8e1c64fd1884a996ef1c;hpb=53ef681d0209e2c85ddd60e049e3c8510fb27bb5;p=dbsrgits%2FDBIx-Class-Schema-Loader.git diff --git a/t/lib/dbixcsl_common_tests.pm b/t/lib/dbixcsl_common_tests.pm index d8dc3f5..ad40057 100644 --- a/t/lib/dbixcsl_common_tests.pm +++ b/t/lib/dbixcsl_common_tests.pm @@ -4,6 +4,7 @@ use strict; use warnings; use Test::More; +use Test::Exception; use DBIx::Class::Schema::Loader; use Class::Unload; use File::Path; @@ -11,9 +12,31 @@ use DBI; use Digest::MD5; use File::Find 'find'; use Class::Unload (); +use DBIx::Class::Schema::Loader::Utils 'dumper_squashed'; +use List::MoreUtils 'apply'; +use DBIx::Class::Schema::Loader::Optional::Dependencies (); +use Try::Tiny; +use File::Slurp 'read_file'; +use File::Spec::Functions 'catfile'; +use File::Basename 'basename'; +use namespace::clean; -my $DUMP_DIR = './t/_common_dump'; -rmtree $DUMP_DIR; +use dbixcsl_test_dir qw/$tdir/; + +use constant DUMP_DIR => "$tdir/common_dump"; + +rmtree DUMP_DIR; + +use constant RESCAN_WARNINGS => qr/(?i:loader_test|LoaderTest)\d+s? has no primary key|^Dumping manual schema|^Schema dump completed|collides with an inherited method|invalidates \d+ active statement|^Bad table or view/; + +# skip schema-qualified tables in the Pg tests +use constant SOURCE_DDL => qr/CREATE (?:TABLE|VIEW) (?!"dbicsl[.-]test")/i; + +use constant SCHEMA_CLASS => 'DBIXCSL_Test::Schema'; + +use constant RESULT_NAMESPACE => [ 'MyResult', 'MyResultTwo' ]; + +use constant RESULTSET_NAMESPACE => [ 'MyResultSet', 'MyResultSetTwo' ]; sub new { my $class = shift; @@ -39,13 +62,23 @@ sub new { # Optional extra tables and tests $self->{extra} ||= {}; - $self->{date_datatype} ||= 'DATE'; + $self->{basic_date_datatype} ||= 'DATE'; # Not all DBS do SQL-standard CURRENT_TIMESTAMP - $self->{default_function} ||= "CURRENT_TIMESTAMP"; - $self->{default_function_def} ||= "TIMESTAMP DEFAULT $self->{default_function}"; + $self->{default_function} ||= "current_timestamp"; + $self->{default_function_def} ||= "timestamp default $self->{default_function}"; + + $self = bless $self, $class; + + $self->{preserve_case_tests_table_names} = [qw/LoaderTest40 LoaderTest41/]; + + if (lc($self->{vendor}) eq 'mysql' && $^O =~ /^(?:MSWin32|cygwin)\z/) { + $self->{preserve_case_tests_table_names} = [qw/Loader_Test40 Loader_Test41/]; + } - return bless $self => $class; + $self->setup_data_type_tests; + + return $self; } sub skip_tests { @@ -73,8 +106,21 @@ sub run_tests { push @connect_info, [ @{$info}{qw/dsn user password connect_info_opts/ } ]; } } + + if ($ENV{SCHEMA_LOADER_TESTS_EXTRA_ONLY}) { + $self->run_only_extra_tests(\@connect_info); + return; + } - plan tests => @connect_info * (171 + ($self->{extra}->{count} || 0)); + my $extra_count = $self->{extra}{count} || 0; + + my $col_accessor_map_tests = 5; + my $num_rescans = 5; + $num_rescans++ if $self->{vendor} eq 'mssql'; + $num_rescans++ if $self->{vendor} eq 'Firebird'; + + plan tests => @connect_info * + (209 + $num_rescans * $col_accessor_map_tests + $extra_count + ($self->{data_type_tests}{test_count} || 0)); foreach my $info_idx (0..$#connect_info) { my $info = $connect_info[$info_idx]; @@ -83,113 +129,192 @@ sub run_tests { $self->create(); - my $schema_class = $self->setup_schema(@$info); + my $schema_class = $self->setup_schema($info); $self->test_schema($schema_class); - rmtree $DUMP_DIR + rmtree DUMP_DIR unless $ENV{SCHEMA_LOADER_TESTS_NOCLEANUP} && $info_idx == $#connect_info; } } +sub run_only_extra_tests { + my ($self, $connect_info) = @_; + + plan tests => @$connect_info * (3 + ($self->{extra}{count} || 0) + ($self->{data_type_tests}{test_count} || 0)); + + rmtree DUMP_DIR; + + foreach my $info_idx (0..$#$connect_info) { + my $info = $connect_info->[$info_idx]; + + @{$self}{qw/dsn user password connect_info_opts/} = @$info; + + $self->drop_extra_tables_only; + + my $dbh = $self->dbconnect(1); + $dbh->do($_) for @{ $self->{pre_create} || [] }; + $dbh->do($_) for @{ $self->{extra}{create} || [] }; + + if (not ($self->{vendor} eq 'mssql' && $dbh->{Driver}{Name} eq 'Sybase')) { + $dbh->do($_) for @{ $self->{data_type_tests}{ddl} || []}; + } + + $self->{_created} = 1; + + my $file_count = grep $_ =~ SOURCE_DDL, @{ $self->{extra}{create} || [] }; + $file_count++; # schema + + if (not ($self->{vendor} eq 'mssql' && $dbh->{Driver}{Name} eq 'Sybase')) { + $file_count++ for @{ $self->{data_type_tests}{table_names} || [] }; + } + + my $schema_class = $self->setup_schema($info, $file_count); + my ($monikers, $classes) = $self->monikers_and_classes($schema_class); + my $conn = $schema_class->clone; + + $self->test_data_types($conn); + $self->{extra}{run}->($conn, $monikers, $classes, $self) if $self->{extra}{run}; + + if (not ($ENV{SCHEMA_LOADER_TESTS_NOCLEANUP} && $info_idx == $#$connect_info)) { + $self->drop_extra_tables_only; + rmtree DUMP_DIR; + } + } +} + +sub drop_extra_tables_only { + my $self = shift; + + my $dbh = $self->dbconnect(0); + + local $^W = 0; # for ADO + + $dbh->do($_) for @{ $self->{extra}{pre_drop_ddl} || [] }; + $self->drop_table($dbh, $_) for @{ $self->{extra}{drop} || [] }; + + if (not ($self->{vendor} eq 'mssql' && $dbh->{Driver}{Name} eq 'Sybase')) { + foreach my $data_type_table (@{ $self->{data_type_tests}{table_names} || [] }) { + $self->drop_table($dbh, $data_type_table); + } + } +} + # defined in sub create my (@statements, @statements_reltests, @statements_advanced, @statements_advanced_sqlite, @statements_inline_rels, @statements_implicit_rels); sub setup_schema { - my $self = shift; - my @connect_info = @_; - - my $schema_class = 'DBIXCSL_Test::Schema'; + my ($self, $connect_info, $expected_count) = @_; my $debug = ($self->{verbose} > 1) ? 1 : 0; + if ($ENV{SCHEMA_LOADER_TESTS_USE_MOOSE}) { + if (not DBIx::Class::Schema::Loader::Optional::Dependencies->req_ok_for('use_moose')) { + die sprintf ("Missing dependencies for SCHEMA_LOADER_TESTS_USE_MOOSE: %s\n", + DBIx::Class::Schema::Loader::Optional::Dependencies->req_missing_for('use_moose')); + } + + $self->{use_moose} = 1; + } + my %loader_opts = ( constraint => - qr/^(?:\S+\.)?(?:(?:$self->{vendor}|extra)_)?loader_test[0-9]+(?!.*_)/i, - relationships => 1, + qr/^(?:\S+\.)?(?:(?:$self->{vendor}|extra)[_-]?)?loader[_-]?test[0-9]+(?!.*_)/i, + result_namespace => RESULT_NAMESPACE, + resultset_namespace => RESULTSET_NAMESPACE, additional_classes => 'TestAdditional', additional_base_classes => 'TestAdditionalBase', left_base_classes => [ qw/TestLeftBase/ ], - components => [ qw/TestComponent/ ], - resultset_components => [ qw/TestRSComponent/ ], - inflect_plural => { loader_test4 => 'loader_test4zes' }, + components => [ qw/TestComponent +TestComponentFQN/ ], + inflect_plural => { loader_test4_fkid => 'loader_test4zes' }, inflect_singular => { fkid => 'fkid_singular' }, moniker_map => \&_monikerize, custom_column_info => \&_custom_column_info, debug => $debug, - use_namespaces => 0, - dump_directory => $DUMP_DIR, + dump_directory => DUMP_DIR, datetime_timezone => 'Europe/Berlin', datetime_locale => 'de_DE', + $self->{use_moose} ? ( + use_moose => 1, + result_roles => 'TestRole', + result_roles_map => { LoaderTest2X => 'TestRoleForMap' }, + ) : (), + col_collision_map => { '^(can)\z' => 'caught_collision_%s' }, + rel_collision_map => { '^(set_primary_key)\z' => 'caught_rel_collision_%s' }, + col_accessor_map => \&test_col_accessor_map, + result_components_map => { LoaderTest2X => 'TestComponentForMap', LoaderTest1 => '+TestComponentForMapFQN' }, + uniq_to_primary => 1, %{ $self->{loader_options} || {} }, ); $loader_opts{db_schema} = $self->{db_schema} if $self->{db_schema}; - Class::Unload->unload($schema_class); + Class::Unload->unload(SCHEMA_CLASS); my $file_count; - my $expected_count = 36; { - my @loader_warnings; - local $SIG{__WARN__} = sub { push(@loader_warnings, $_[0]); }; - eval qq{ - package $schema_class; - use base qw/DBIx::Class::Schema::Loader/; - - __PACKAGE__->loader_options(\%loader_opts); - __PACKAGE__->connection(\@connect_info); - }; - - ok(!$@, "Loader initialization") or diag $@; - - find sub { return if -d; $file_count++ }, $DUMP_DIR; + my @loader_warnings; + local $SIG{__WARN__} = sub { push(@loader_warnings, @_); }; + eval qq{ + package @{[SCHEMA_CLASS]}; + use base qw/DBIx::Class::Schema::Loader/; + + __PACKAGE__->loader_options(\%loader_opts); + __PACKAGE__->connection(\@\$connect_info); + }; + + ok(!$@, "Loader initialization") or diag $@; - $expected_count += grep /CREATE (?:TABLE|VIEW)/i, - @{ $self->{extra}{create} || [] }; + find sub { return if -d; $file_count++ }, DUMP_DIR; - $expected_count -= grep /CREATE TABLE/, @statements_inline_rels - if $self->{skip_rels} || $self->{no_inline_rels}; + my $standard_sources = not defined $expected_count; - $expected_count -= grep /CREATE TABLE/, @statements_implicit_rels - if $self->{skip_rels} || $self->{no_implicit_rels}; + if ($standard_sources) { + $expected_count = 37; - $expected_count -= grep /CREATE TABLE/, ($self->{vendor} =~ /sqlite/ ? @statements_advanced_sqlite : @statements_advanced), @statements_reltests - if $self->{skip_rels}; + if (not ($self->{vendor} eq 'mssql' && $connect_info->[0] =~ /Sybase/)) { + $expected_count++ for @{ $self->{data_type_tests}{table_names} || [] }; + } - is $file_count, $expected_count, 'correct number of files generated'; + $expected_count += grep $_ =~ SOURCE_DDL, + @{ $self->{extra}{create} || [] }; + + $expected_count -= grep /CREATE TABLE/, @statements_inline_rels + if $self->{skip_rels} || $self->{no_inline_rels}; + + $expected_count -= grep /CREATE TABLE/, @statements_implicit_rels + if $self->{skip_rels} || $self->{no_implicit_rels}; + + $expected_count -= grep /CREATE TABLE/, ($self->{vendor} =~ /sqlite/ ? @statements_advanced_sqlite : @statements_advanced), @statements_reltests + if $self->{skip_rels}; + } + + is $file_count, $expected_count, 'correct number of files generated'; + + my $warn_count = 2; + + $warn_count++ for grep /^Bad table or view/, @loader_warnings; + + $warn_count++ for grep /renaming \S+ relation/, @loader_warnings; + + $warn_count++ for grep /\b(?!loader_test9)\w+ has no primary key/i, @loader_warnings; - my $warn_count = 2; - $warn_count++ if grep /ResultSetManager/, @loader_warnings; + $warn_count++ for grep /^Column '\w+' in table '\w+' collides with an inherited method\./, @loader_warnings; - $warn_count++ for grep /^Bad table or view/, @loader_warnings; + $warn_count++ for grep /^Relationship '\w+' in source '\w+' for columns '[^']+' collides with an inherited method\./, @loader_warnings; - $warn_count++ for grep /renaming \S+ relation/, @loader_warnings; + $warn_count++ for grep { my $w = $_; grep $w =~ $_, @{ $self->{warnings} || [] } } @loader_warnings; - my $vendor = $self->{vendor}; - $warn_count++ for grep /${vendor}_\S+ has no primary key/, - @loader_warnings; + $warn_count-- for grep { my $w = $_; grep $w =~ $_, @{ $self->{failtrigger_warnings} || [] } } @loader_warnings; - if($self->{skip_rels}) { - SKIP: { - is(scalar(@loader_warnings), $warn_count, "No loader warnings") - or diag @loader_warnings; - skip "No missing PK warnings without rels", 1; - } - } - else { - $warn_count++; - is(scalar(@loader_warnings), $warn_count, "Expected loader warning") - or diag @loader_warnings; - is(grep(/loader_test9 has no primary key/i, @loader_warnings), 1, - "Missing PK warning"); - } + is scalar(@loader_warnings), $warn_count, 'Correct number of warnings' + or diag @loader_warnings; } - exit if $file_count != $expected_count; - - return $schema_class; + exit if ($file_count||0) != $expected_count; + + return SCHEMA_CLASS; } sub test_schema { @@ -200,20 +325,7 @@ sub test_schema { ($self->{before_tests_run} || sub {})->($conn); - my $monikers = {}; - my $classes = {}; - foreach my $source_name ($schema_class->sources) { - my $table_name = $schema_class->source($source_name)->from; - - $table_name = $$table_name if ref $table_name; - - $monikers->{$table_name} = $source_name; - $classes->{$table_name} = $schema_class . q{::} . $source_name; - - # some DBs (Firebird) uppercase everything - $monikers->{lc $table_name} = $source_name; - $classes->{lc $table_name} = $schema_class . q{::} . $source_name; - } + my ($monikers, $classes) = $self->monikers_and_classes($schema_class); my $moniker1 = $monikers->{loader_test1s}; my $class1 = $classes->{loader_test1s}; @@ -225,8 +337,8 @@ sub test_schema { my $rsobj2 = $conn->resultset($moniker2); check_no_duplicate_unique_constraints($class2); - my $moniker23 = $monikers->{LOADER_TEST23} || $monikers->{loader_test23}; - my $class23 = $classes->{LOADER_TEST23} || $classes->{loader_test23}; + my $moniker23 = $monikers->{LOADER_test23} || $monikers->{loader_test23}; + my $class23 = $classes->{LOADER_test23} || $classes->{loader_test23}; my $rsobj23 = $conn->resultset($moniker1); my $moniker24 = $monikers->{LoAdEr_test24} || $monikers->{loader_test24}; @@ -237,14 +349,86 @@ sub test_schema { my $class35 = $classes->{loader_test35}; my $rsobj35 = $conn->resultset($moniker35); + my $moniker50 = $monikers->{loader_test50}; + my $class50 = $classes->{loader_test50}; + my $rsobj50 = $conn->resultset($moniker50); + isa_ok( $rsobj1, "DBIx::Class::ResultSet" ); isa_ok( $rsobj2, "DBIx::Class::ResultSet" ); isa_ok( $rsobj23, "DBIx::Class::ResultSet" ); isa_ok( $rsobj24, "DBIx::Class::ResultSet" ); isa_ok( $rsobj35, "DBIx::Class::ResultSet" ); + isa_ok( $rsobj50, "DBIx::Class::ResultSet" ); + + # check result_namespace + my @schema_dir = split /::/, SCHEMA_CLASS; + my $result_dir = ref RESULT_NAMESPACE ? ${RESULT_NAMESPACE()}[0] : RESULT_NAMESPACE; + + my $schema_files = [ sort map basename($_), glob catfile(DUMP_DIR, @schema_dir, '*') ]; + + is_deeply $schema_files, [ $result_dir ], + 'first entry in result_namespace exists as a directory'; + + my $result_file_count =()= glob catfile(DUMP_DIR, @schema_dir, $result_dir, '*.pm'); + + ok $result_file_count, + 'Result files dumped to first entry in result_namespace'; + + # parse out the resultset_namespace + my $schema_code = read_file($conn->_loader->get_dump_filename(SCHEMA_CLASS), binmode => ':encoding(UTF-8)'); + + my ($schema_resultset_namespace) = $schema_code =~ /\bresultset_namespace => (.*)/; + $schema_resultset_namespace = eval $schema_resultset_namespace; + die $@ if $@; + + is_deeply $schema_resultset_namespace, RESULTSET_NAMESPACE, + 'resultset_namespace set correctly on Schema'; my @columns_lt2 = $class2->columns; - is_deeply( \@columns_lt2, [ qw/id dat dat2/ ], "Column Ordering" ); + is_deeply( \@columns_lt2, [ qw/id dat dat2 set_primary_key can dbix_class_testcomponent dbix_class_testcomponentmap testcomponent_fqn meta test_role_method test_role_for_map_method crumb_crisp_coating/ ], "Column Ordering" ); + + is $class2->column_info('can')->{accessor}, 'caught_collision_can', + 'accessor for column name that conflicts with a UNIVERSAL method renamed based on col_collision_map'; + + ok (exists $class2->column_info('set_primary_key')->{accessor} + && (not defined $class2->column_info('set_primary_key')->{accessor}), + 'accessor for column name that conflicts with a result base class method removed'); + + ok (exists $class2->column_info('dbix_class_testcomponent')->{accessor} + && (not defined $class2->column_info('dbix_class_testcomponent')->{accessor}), + 'accessor for column name that conflicts with a component class method removed'); + + ok (exists $class2->column_info('dbix_class_testcomponentmap')->{accessor} + && (not defined $class2->column_info('dbix_class_testcomponentmap')->{accessor}), + 'accessor for column name that conflicts with a component class method removed'); + + ok (exists $class2->column_info('testcomponent_fqn')->{accessor} + && (not defined $class2->column_info('testcomponent_fqn')->{accessor}), + 'accessor for column name that conflicts with a fully qualified component class method removed'); + + if ($self->{use_moose}) { + ok (exists $class2->column_info('meta')->{accessor} + && (not defined $class2->column_info('meta')->{accessor}), + 'accessor for column name that conflicts with Moose removed'); + + ok (exists $class2->column_info('test_role_for_map_method')->{accessor} + && (not defined $class2->column_info('test_role_for_map_method')->{accessor}), + 'accessor for column name that conflicts with a Result role removed'); + + ok (exists $class2->column_info('test_role_method')->{accessor} + && (not defined $class2->column_info('test_role_method')->{accessor}), + 'accessor for column name that conflicts with a Result role removed'); + } + else { + ok ((not exists $class2->column_info('meta')->{accessor}), + "not removing 'meta' accessor with use_moose disabled"); + + ok ((not exists $class2->column_info('test_role_for_map_method')->{accessor}), + 'no role method conflicts with use_moose disabled'); + + ok ((not exists $class2->column_info('test_role_method')->{accessor}), + 'no role method conflicts with use_moose disabled'); + } my %uniq1 = $class1->unique_constraints; my $uniq1_test = 0; @@ -272,6 +456,11 @@ sub test_schema { } ok($uniq2_test, "Multi-col unique constraint"); + my %uniq3 = $class50->unique_constraints; + + is_deeply $uniq3{primary}, ['id1', 'id2'], + 'unique constraint promoted to primary key with uniq_to_primary'; + is($moniker2, 'LoaderTest2X', "moniker_map testing"); SKIP: { @@ -304,12 +493,31 @@ sub test_schema { 'Additional Component' ); } + is try { $class2->dbix_class_testcomponentmap }, 'dbix_class_testcomponentmap works', + 'component from result_component_map'; + + isnt try { $class1->dbix_class_testcomponentmap }, 'dbix_class_testcomponentmap works', + 'component from result_component_map not added to not mapped Result'; + + is try { $class1->testcomponent_fqn }, 'TestComponentFQN works', + 'fully qualified component class'; + + is try { $class1->testcomponentformap_fqn }, 'TestComponentForMapFQN works', + 'fully qualified component class from result_component_map'; + + isnt try { $class2->testcomponentformap_fqn }, 'TestComponentForMapFQN works', + 'fully qualified component class from result_component_map not added to not mapped Result'; + SKIP: { - can_ok($rsobj1, 'dbix_class_testrscomponent') - or skip "Pre-requisite test failed", 1; - is( $rsobj1->dbix_class_testrscomponent, - 'dbix_class_testrscomponent works', - 'ResultSet component' ); + skip 'not testing role methods with use_moose disabled', 2 + unless $self->{use_moose}; + + is try { $class1->test_role_method }, 'test_role_method works', + 'role from result_roles applied'; + + is try { $class2->test_role_for_map_method }, + 'test_role_for_map_method works', + 'role from result_roles_map applied'; } SKIP: { @@ -318,17 +526,12 @@ sub test_schema { is( $class1->loader_test1_classmeth, 'all is well', 'Class method' ); } - SKIP: { - can_ok( $rsobj1, 'loader_test1_rsmeth' ) - or skip "Pre-requisite test failed"; - is( $rsobj1->loader_test1_rsmeth, 'all is still well', 'Result set method' ); - } - ok( $class1->column_info('id')->{is_auto_increment}, 'is_auto_increment detection' ); - my $obj = $rsobj1->find(1); - is( $obj->id, 1, "Find got the right row" ); - is( $obj->dat, "foo", "Column value" ); + my $obj = try { $rsobj1->find(1) }; + + is( try { $obj->id }, 1, "Find got the right row" ); + is( try { $obj->dat }, "foo", "Column value" ); is( $rsobj2->count, 4, "Count" ); my $saved_id; eval { @@ -345,31 +548,54 @@ sub test_schema { my ($obj2) = $rsobj2->search({ dat => 'bbb' })->first; is( $obj2->id, 2 ); - is( - $class35->column_info('a_varchar')->{default_value}, 'foo', - 'constant character default', - ); + SKIP: { + skip 'no DEFAULT on Access', 7 if $self->{vendor} eq 'Access'; - is( - $class35->column_info('an_int')->{default_value}, 42, - 'constant integer default', - ); + is( + $class35->column_info('a_varchar')->{default_value}, 'foo', + 'constant character default', + ); - is( - $class35->column_info('a_double')->{default_value}, 10.555, - 'constant numeric default', - ); + is( + $class35->column_info('an_int')->{default_value}, 42, + 'constant integer default', + ); + + is( + $class35->column_info('a_negative_int')->{default_value}, -42, + 'constant negative integer default', + ); - my $function_default = $class35->column_info('a_function')->{default_value}; + is( + sprintf("%.3f", $class35->column_info('a_double')->{default_value}), '10.555', + 'constant numeric default', + ); - isa_ok( $function_default, 'SCALAR', 'default_value for function default' ); - is_deeply( - $function_default, \$self->{default_function}, - 'default_value for function default is correct' - ); + is( + sprintf("%.3f", $class35->column_info('a_negative_double')->{default_value}), -10.555, + 'constant negative numeric default', + ); + + my $function_default = $class35->column_info('a_function')->{default_value}; + + isa_ok( $function_default, 'SCALAR', 'default_value for function default' ); + is_deeply( + $function_default, \$self->{default_function}, + 'default_value for function default is correct' + ); + } + + is( $class2->column_info('crumb_crisp_coating')->{accessor}, 'trivet', + 'col_accessor_map is being run' ); + + is $class1->column_info('dat')->{is_nullable}, 0, + 'is_nullable=0 detection'; + + is $class2->column_info('set_primary_key')->{is_nullable}, 1, + 'is_nullable=1 detection'; SKIP: { - skip $self->{skip_rels}, 113 if $self->{skip_rels}; + skip $self->{skip_rels}, 131 if $self->{skip_rels}; my $moniker3 = $monikers->{loader_test3}; my $class3 = $classes->{loader_test3}; @@ -493,14 +719,23 @@ sub test_schema { isa_ok( $rsobj36, "DBIx::Class::ResultSet" ); # basic rel test - my $obj4 = $rsobj4->find(123); - isa_ok( $obj4->fkid_singular, $class3); + my $obj4 = try { $rsobj4->find(123) } || $rsobj4->search({ id => 123 })->first; + isa_ok( try { $obj4->fkid_singular }, $class3); + + # test renaming rel that conflicts with a class method + ok ($obj4->has_relationship('belongs_to_rel'), 'relationship name that conflicts with a method renamed'); + + isa_ok( try { $obj4->belongs_to_rel }, $class3); + + ok ($obj4->has_relationship('caught_rel_collision_set_primary_key'), + 'relationship name that conflicts with a method renamed based on rel_collision_map'); + isa_ok( try { $obj4->caught_rel_collision_set_primary_key }, $class3); ok($class4->column_info('fkid')->{is_foreign_key}, 'Foreign key detected'); - my $obj3 = $rsobj3->find(1); - my $rs_rel4 = $obj3->search_related('loader_test4zes'); - isa_ok( $rs_rel4->first, $class4); + my $obj3 = try { $rsobj3->find(1) } || $rsobj3->search({ id => 1 })->first; + my $rs_rel4 = try { $obj3->search_related('loader_test4zes') }; + isa_ok( try { $rs_rel4->first }, $class4); # check rel naming with prepositions ok ($rsobj4->result_source->has_relationship('loader_test5s_to'), @@ -510,87 +745,131 @@ sub test_schema { "rel with preposition 'from' pluralized correctly"); # check default relationship attributes - is $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{cascade_delete}, 0, + is try { $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{cascade_delete} }, 0, 'cascade_delete => 0 on has_many by default'; - is $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{cascade_copy}, 0, + is try { $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{cascade_copy} }, 0, 'cascade_copy => 0 on has_many by default'; - ok ((not exists $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{on_delete}), + ok ((not try { exists $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{on_delete} }), 'has_many does not have on_delete'); - ok ((not exists $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{on_update}), + ok ((not try { exists $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{on_update} }), 'has_many does not have on_update'); - is $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{on_delete}, 'CASCADE', + ok ((not try { exists $rsobj3->result_source->relationship_info('loader_test4zes')->{attrs}{is_deferrable} }), + 'has_many does not have is_deferrable'); + + is try { $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{on_delete} }, 'CASCADE', "on_delete => 'CASCADE' on belongs_to by default"; - is $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{on_update}, 'CASCADE', + is try { $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{on_update} }, 'CASCADE', "on_update => 'CASCADE' on belongs_to by default"; - ok ((not exists $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{cascade_delete}), + is try { $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{is_deferrable} }, 1, + "is_deferrable => 1 on belongs_to by default"; + + ok ((not try { exists $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{cascade_delete} }), 'belongs_to does not have cascade_delete'); - ok ((not exists $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{cascade_copy}), + ok ((not try { exists $rsobj4->result_source->relationship_info('fkid_singular')->{attrs}{cascade_copy} }), 'belongs_to does not have cascade_copy'); - is $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{cascade_delete}, 0, + is try { $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{cascade_delete} }, 0, 'cascade_delete => 0 on might_have by default'; - is $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{cascade_copy}, 0, + is try { $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{cascade_copy} }, 0, 'cascade_copy => 0 on might_have by default'; - ok ((not exists $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{on_delete}), + ok ((not try { exists $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{on_delete} }), 'might_have does not have on_delete'); - ok ((not exists $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{on_update}), + ok ((not try { exists $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{on_update} }), 'might_have does not have on_update'); - # find on multi-col pk - my $obj5 = - eval { $rsobj5->find({id1 => 1, iD2 => 1}) } || - eval { $rsobj5->find({id1 => 1, id2 => 1}) }; - die $@ if $@; + ok ((not try { exists $rsobj27->result_source->relationship_info('loader_test28')->{attrs}{is_deferrable} }), + 'might_have does not have is_deferrable'); - is( $obj5->id2, 1, "Find on multi-col PK" ); + # find on multi-col pk + if ($conn->_loader->preserve_case) { + my $obj5 = $rsobj5->find({id1 => 1, iD2 => 1}); + is $obj5->i_d2, 1, 'Find on multi-col PK'; + } + else { + my $obj5 = $rsobj5->find({id1 => 1, id2 => 1}); + is $obj5->id2, 1, 'Find on multi-col PK'; + } # mulit-col fk def - my $obj6 = $rsobj6->find(1); - isa_ok( $obj6->loader_test2, $class2); - isa_ok( $obj6->loader_test5, $class5); + my $obj6 = try { $rsobj6->find(1) } || $rsobj6->search({ id => 1 })->first; + isa_ok( try { $obj6->loader_test2 }, $class2); + isa_ok( try { $obj6->loader_test5 }, $class5); ok($class6->column_info('loader_test2_id')->{is_foreign_key}, 'Foreign key detected'); ok($class6->column_info('id')->{is_foreign_key}, 'Foreign key detected'); - my $id2_info = eval { $class6->column_info('id2') } || + my $id2_info = try { $class6->column_info('id2') } || $class6->column_info('Id2'); ok($id2_info->{is_foreign_key}, 'Foreign key detected'); + unlike read_file($conn->_loader->get_dump_filename($class6), binmode => ':encoding(UTF-8)'), +qr/\n__PACKAGE__->(?:belongs_to|has_many|might_have|has_one|many_to_many)\( + \s+ "(\w+?)" + .*? + \n__PACKAGE__->(?:belongs_to|has_many|might_have|has_one|many_to_many)\( + \s+ "\1"/xs, +'did not create two relationships with the same name'; + + unlike read_file($conn->_loader->get_dump_filename($class8), binmode => ':encoding(UTF-8)'), +qr/\n__PACKAGE__->(?:belongs_to|has_many|might_have|has_one|many_to_many)\( + \s+ "(\w+?)" + .*? + \n__PACKAGE__->(?:belongs_to|has_many|might_have|has_one|many_to_many)\( + \s+ "\1"/xs, +'did not create two relationships with the same name'; + + # check naming of ambiguous relationships + my $rel_info = $class6->relationship_info('lovely_loader_test7') || {}; + + ok (($class6->has_relationship('lovely_loader_test7') + && $rel_info->{cond}{'foreign.lovely_loader_test6'} eq 'self.id' + && $rel_info->{class} eq $class7 + && $rel_info->{attrs}{accessor} eq 'single'), + 'ambiguous relationship named correctly'); + + $rel_info = $class8->relationship_info('active_loader_test16') || {}; + + ok (($class8->has_relationship('active_loader_test16') + && $rel_info->{cond}{'foreign.loader_test8_id'} eq 'self.id' + && $rel_info->{class} eq $class16 + && $rel_info->{attrs}{accessor} eq 'single'), + 'ambiguous relationship named correctly'); + # fk that references a non-pk key (UNIQUE) - my $obj8 = $rsobj8->find(1); - isa_ok( $obj8->loader_test7, $class7); + my $obj8 = try { $rsobj8->find(1) } || $rsobj8->search({ id => 1 })->first; + isa_ok( try { $obj8->loader_test7 }, $class7); ok($class8->column_info('loader_test7')->{is_foreign_key}, 'Foreign key detected'); # test double-fk 17 ->-> 16 - my $obj17 = $rsobj17->find(33); + my $obj17 = try { $rsobj17->find(33) } || $rsobj17->search({ id => 33 })->first; - my $rs_rel16_one = $obj17->loader16_one; + my $rs_rel16_one = try { $obj17->loader16_one }; isa_ok($rs_rel16_one, $class16); - is($rs_rel16_one->dat, 'y16', "Multiple FKs to same table"); + is(try { $rs_rel16_one->dat }, 'y16', "Multiple FKs to same table"); ok($class17->column_info('loader16_one')->{is_foreign_key}, 'Foreign key detected'); - my $rs_rel16_two = $obj17->loader16_two; + my $rs_rel16_two = try { $obj17->loader16_two }; isa_ok($rs_rel16_two, $class16); - is($rs_rel16_two->dat, 'z16', "Multiple FKs to same table"); + is(try { $rs_rel16_two->dat }, 'z16', "Multiple FKs to same table"); ok($class17->column_info('loader16_two')->{is_foreign_key}, 'Foreign key detected'); - my $obj16 = $rsobj16->find(2); - my $rs_rel17 = $obj16->search_related('loader_test17_loader16_ones'); - isa_ok($rs_rel17->first, $class17); - is($rs_rel17->first->id, 3, "search_related with multiple FKs from same table"); + my $obj16 = try { $rsobj16->find(2) } || $rsobj16->search({ id => 2 })->first; + my $rs_rel17 = try { $obj16->search_related('loader_test17_loader16_ones') }; + isa_ok(try { $rs_rel17->first }, $class17); + is(try { $rs_rel17->first->id }, 3, "search_related with multiple FKs from same table"); # XXX test m:m 18 <- 20 -> 19 ok($class20->column_info('parent')->{is_foreign_key}, 'Foreign key detected'); @@ -601,42 +880,42 @@ sub test_schema { ok($class22->column_info('child')->{is_foreign_key}, 'Foreign key detected'); # test double multi-col fk 26 -> 25 - my $obj26 = $rsobj26->find(33); + my $obj26 = try { $rsobj26->find(33) } || $rsobj26->search({ id => 33 })->first; - my $rs_rel25_one = $obj26->loader_test25_id_rel1; + my $rs_rel25_one = try { $obj26->loader_test25_id_rel1 }; isa_ok($rs_rel25_one, $class25); - is($rs_rel25_one->dat, 'x25', "Multiple multi-col FKs to same table"); + is(try { $rs_rel25_one->dat }, 'x25', "Multiple multi-col FKs to same table"); ok($class26->column_info('id')->{is_foreign_key}, 'Foreign key detected'); ok($class26->column_info('rel1')->{is_foreign_key}, 'Foreign key detected'); ok($class26->column_info('rel2')->{is_foreign_key}, 'Foreign key detected'); - my $rs_rel25_two = $obj26->loader_test25_id_rel2; + my $rs_rel25_two = try { $obj26->loader_test25_id_rel2 }; isa_ok($rs_rel25_two, $class25); - is($rs_rel25_two->dat, 'y25', "Multiple multi-col FKs to same table"); + is(try { $rs_rel25_two->dat }, 'y25', "Multiple multi-col FKs to same table"); - my $obj25 = $rsobj25->find(3,42); - my $rs_rel26 = $obj25->search_related('loader_test26_id_rel1s'); - isa_ok($rs_rel26->first, $class26); - is($rs_rel26->first->id, 3, "search_related with multiple multi-col FKs from same table"); + my $obj25 = try { $rsobj25->find(3,42) } || $rsobj25->search({ id1 => 3, id2 => 42 })->first; + my $rs_rel26 = try { $obj25->search_related('loader_test26_id_rel1s') }; + isa_ok(try { $rs_rel26->first }, $class26); + is(try { $rs_rel26->first->id }, 3, "search_related with multiple multi-col FKs from same table"); # test one-to-one rels - my $obj27 = $rsobj27->find(1); - my $obj28 = $obj27->loader_test28; + my $obj27 = try { $rsobj27->find(1) } || $rsobj27->search({ id => 1 })->first; + my $obj28 = try { $obj27->loader_test28 }; isa_ok($obj28, $class28); - is($obj28->get_column('id'), 1, "One-to-one relationship with PRIMARY FK"); + is(try { $obj28->get_column('id') }, 1, "One-to-one relationship with PRIMARY FK"); ok($class28->column_info('id')->{is_foreign_key}, 'Foreign key detected'); - my $obj29 = $obj27->loader_test29; + my $obj29 = try { $obj27->loader_test29 }; isa_ok($obj29, $class29); - is($obj29->id, 1, "One-to-one relationship with UNIQUE FK"); + is(try { $obj29->id }, 1, "One-to-one relationship with UNIQUE FK"); ok($class29->column_info('fk')->{is_foreign_key}, 'Foreign key detected'); - $obj27 = $rsobj27->find(2); - is($obj27->loader_test28, undef, "Undef for missing one-to-one row"); - is($obj27->loader_test29, undef, "Undef for missing one-to-one row"); + $obj27 = try { $rsobj27->find(2) } || $rsobj27->search({ id => 2 })->first; + is(try { $obj27->loader_test28 }, undef, "Undef for missing one-to-one row"); + is(try { $obj27->loader_test29 }, undef, "Undef for missing one-to-one row"); # test outer join for nullable referring columns: is $class32->column_info('rel2')->{is_nullable}, 1, @@ -645,10 +924,15 @@ sub test_schema { ok($class32->column_info('rel1')->{is_foreign_key}, 'Foreign key detected'); ok($class32->column_info('rel2')->{is_foreign_key}, 'Foreign key detected'); - my $obj32 = $rsobj32->find(1,{prefetch=>[qw/rel1 rel2/]}); - my $obj34 = $rsobj34->find( - 1,{prefetch=>[qw/loader_test33_id_rel1 loader_test33_id_rel2/]} - ); + my $obj32 = try { $rsobj32->find(1, { prefetch => [qw/rel1 rel2/] }) } + || try { $rsobj32->search({ id => 1 }, { prefetch => [qw/rel1 rel2/] })->first } + || $rsobj32->search({ id => 1 })->first; + + my $obj34 = eval { $rsobj34->find(1, { prefetch => [qw/loader_test33_id_rel1 loader_test33_id_rel2/] }) } + || eval { $rsobj34->search({ id => 1 }, { prefetch => [qw/loader_test33_id_rel1 loader_test33_id_rel2/] })->first } + || $rsobj34->search({ id => 1 })->first; + diag $@ if $@; + isa_ok($obj32,$class32); isa_ok($obj34,$class34); @@ -656,16 +940,16 @@ sub test_schema { ok($class34->column_info('rel1')->{is_foreign_key}, 'Foreign key detected'); ok($class34->column_info('rel2')->{is_foreign_key}, 'Foreign key detected'); - my $rs_rel31_one = $obj32->rel1; - my $rs_rel31_two = $obj32->rel2; + my $rs_rel31_one = try { $obj32->rel1 }; + my $rs_rel31_two = try { $obj32->rel2 }; isa_ok($rs_rel31_one, $class31); is($rs_rel31_two, undef); - my $rs_rel33_one = $obj34->loader_test33_id_rel1; - my $rs_rel33_two = $obj34->loader_test33_id_rel2; + my $rs_rel33_one = try { $obj34->loader_test33_id_rel1 }; + my $rs_rel33_two = try { $obj34->loader_test33_id_rel2 }; - isa_ok($rs_rel33_one,$class33); - is($rs_rel33_two, undef); + isa_ok($rs_rel33_one, $class33); + isa_ok($rs_rel33_two, $class33); # from Chisel's tests... my $moniker10 = $monikers->{loader_test10}; @@ -687,7 +971,7 @@ sub test_schema { $obj10->update(); ok( defined $obj10, 'Create row' ); - my $obj11 = $rsobj11->create({ loader_test10 => $obj10->id() }); + my $obj11 = $rsobj11->create({ loader_test10 => (try { $obj10->id() } || $obj10->id10) }); $obj11->update(); ok( defined $obj11, 'Create related row' ); @@ -729,15 +1013,44 @@ sub test_schema { ok($class13->column_info('loader_test12')->{is_foreign_key}, 'Foreign key detected'); ok($class13->column_info('dat')->{is_foreign_key}, 'Foreign key detected'); - my $obj13 = $rsobj13->find(1); + my $obj13 = try { $rsobj13->find(1) } || $rsobj13->search({ id => 1 })->first; isa_ok( $obj13->id, $class12 ); isa_ok( $obj13->loader_test12, $class12); isa_ok( $obj13->dat, $class12); - my $obj12 = $rsobj12->find(1); - isa_ok( $obj12->loader_test13, $class13 ); + my $obj12 = try { $rsobj12->find(1) } || $rsobj12->search({ id => 1 })->first; + isa_ok( try { $obj12->loader_test13 }, $class13 ); } + # relname is preserved when another fk is added + { + local $SIG{__WARN__} = sub { warn @_ unless $_[0] =~ /invalidates \d+ active statement/ }; + $conn->storage->disconnect; # for mssql and access + } + + isa_ok try { $rsobj3->find(1)->loader_test4zes }, 'DBIx::Class::ResultSet'; + + $conn->storage->disconnect; # for access + + if (lc($self->{vendor}) !~ /^(?:sybase|mysql)\z/) { + $conn->storage->dbh->do('ALTER TABLE loader_test4 ADD fkid2 INTEGER REFERENCES loader_test3 (id)'); + } + else { + $conn->storage->dbh->do(<<"EOF"); + ALTER TABLE loader_test4 ADD fkid2 INTEGER $self->{null} +EOF + $conn->storage->dbh->do(<<"EOF"); + ALTER TABLE loader_test4 ADD CONSTRAINT loader_test4_to_3_fk FOREIGN KEY (fkid2) REFERENCES loader_test3 (id) +EOF + } + + $conn->storage->disconnect; # for firebird + + $self->rescan_without_warnings($conn); + + isa_ok try { $rsobj3->find(1)->loader_test4zes }, 'DBIx::Class::ResultSet', + 'relationship name preserved when another foreign key is added in remote table'; + SKIP: { skip 'This vendor cannot do out-of-line implicit rel defs', 4 if $self->{no_implicit_rels}; @@ -754,7 +1067,7 @@ sub test_schema { ok($class15->column_info('loader_test14')->{is_foreign_key}, 'Foreign key detected'); - my $obj15 = $rsobj15->find(1); + my $obj15 = try { $rsobj15->find(1) } || $rsobj15->search({ id => 1 })->first; isa_ok( $obj15->loader_test14, $class14 ); } } @@ -779,7 +1092,7 @@ sub test_schema { } # rescan and norewrite test - SKIP: { + { my @statements_rescan = ( qq{ CREATE TABLE loader_test30 ( @@ -797,44 +1110,38 @@ sub test_schema { my $find_cb = sub { return if -d; - return if $_ eq 'LoaderTest30.pm'; + return if /^(?:LoaderTest30|LoaderTest1|LoaderTest2X)\.pm\z/; open my $fh, '<', $_ or die "Could not open $_ for reading: $!"; binmode $fh; $digest->addfile($fh); }; - find $find_cb, $DUMP_DIR; - - my $before_digest = $digest->digest; - - my $dbh = $self->dbconnect(1); + find $find_cb, DUMP_DIR; - { - # Silence annoying but harmless postgres "NOTICE: CREATE TABLE..." - local $SIG{__WARN__} = sub { - my $msg = shift; - print STDERR $msg unless $msg =~ m{^NOTICE:\s+CREATE TABLE}; - }; +# system "rm -rf /tmp/before_rescan /tmp/after_rescan"; +# system "mkdir /tmp/before_rescan"; +# system "mkdir /tmp/after_rescan"; +# system "cp -a @{[DUMP_DIR]} /tmp/before_rescan"; - $dbh->do($_) for @statements_rescan; - } + my $before_digest = $digest->b64digest; + $conn->storage->disconnect; # needed for Firebird and Informix + my $dbh = $self->dbconnect(1); + $dbh->do($_) for @statements_rescan; $dbh->disconnect; - $conn->storage->disconnect; # needed for Firebird sleep 1; - my @new = do { - # kill the 'Dumping manual schema' warnings - local $SIG{__WARN__} = sub {}; - $conn->rescan; - }; + my @new = $self->rescan_without_warnings($conn); + is_deeply(\@new, [ qw/LoaderTest30/ ], "Rescan"); +# system "cp -a @{[DUMP_DIR]} /tmp/after_rescan"; + $digest = Digest::MD5->new; - find $find_cb, $DUMP_DIR; - my $after_digest = $digest->digest; + find $find_cb, DUMP_DIR; + my $after_digest = $digest->b64digest; is $before_digest, $after_digest, 'dumped files are not rewritten when there is no modification'; @@ -842,22 +1149,143 @@ sub test_schema { my $rsobj30 = $conn->resultset('LoaderTest30'); isa_ok($rsobj30, 'DBIx::Class::ResultSet'); - skip 'no rels', 2 if $self->{skip_rels}; + SKIP: { + skip 'no rels', 2 if $self->{skip_rels}; + + my $obj30 = try { $rsobj30->find(123) } || $rsobj30->search({ id => 123 })->first; + isa_ok( $obj30->loader_test2, $class2); - my $obj30 = $rsobj30->find(123); - isa_ok( $obj30->loader_test2, $class2); + ok($rsobj30->result_source->column_info('loader_test2')->{is_foreign_key}, + 'Foreign key detected'); + } - ok($rsobj30->result_source->column_info('loader_test2')->{is_foreign_key}, - 'Foreign key detected'); + $conn->storage->disconnect; # for Firebird + $self->drop_table($conn->storage->dbh, 'loader_test30'); + + @new = $self->rescan_without_warnings($conn); + + is_deeply(\@new, [], 'no new tables on rescan'); + + throws_ok { $conn->resultset('LoaderTest30') } + qr/Can't find source/, + 'source unregistered for dropped table after rescan'; } - $self->{extra}->{run}->($conn, $monikers, $classes) if $self->{extra}->{run}; + $self->test_data_types($conn); + + # run extra tests + $self->{extra}{run}->($conn, $monikers, $classes, $self) if $self->{extra}{run}; + + $self->test_preserve_case($conn); $self->drop_tables unless $ENV{SCHEMA_LOADER_TESTS_NOCLEANUP}; $conn->storage->disconnect; } +sub test_data_types { + my ($self, $conn) = @_; + + SKIP: { + if (my $test_count = $self->{data_type_tests}{test_count}) { + if ($self->{vendor} eq 'mssql' && $conn->storage->dbh->{Driver}{Name} eq 'Sybase') { + skip 'DBD::Sybase does not work with the data_type tests on latest SQL Server', $test_count; + } + + my $data_type_tests = $self->{data_type_tests}; + + foreach my $moniker (@{ $data_type_tests->{table_monikers} }) { + my $columns = $data_type_tests->{columns}{$moniker}; + + my $rsrc = $conn->resultset($moniker)->result_source; + + while (my ($col_name, $expected_info) = each %$columns) { + my %info = %{ $rsrc->column_info($col_name) }; + delete @info{qw/is_nullable timezone locale sequence/}; + + my $text_col_def = dumper_squashed \%info; + + my $text_expected_info = dumper_squashed $expected_info; + + is_deeply \%info, $expected_info, + "test column $col_name has definition: $text_col_def expecting: $text_expected_info"; + } + } + } + } +} + +sub test_preserve_case { + my ($self, $conn) = @_; + + my ($oqt, $cqt) = $self->get_oqt_cqt(always => 1); # open quote, close quote + + my $dbh = $self->dbconnect; + + my ($table40_name, $table41_name) = @{ $self->{preserve_case_tests_table_names} }; + + $dbh->do($_) for ( +qq| + CREATE TABLE ${oqt}${table40_name}${cqt} ( + ${oqt}Id${cqt} INTEGER NOT NULL PRIMARY KEY, + ${oqt}Foo3Bar${cqt} VARCHAR(100) NOT NULL + ) $self->{innodb} +|, +qq| + CREATE TABLE ${oqt}${table41_name}${cqt} ( + ${oqt}Id${cqt} INTEGER NOT NULL PRIMARY KEY, + ${oqt}LoaderTest40Id${cqt} INTEGER, + FOREIGN KEY (${oqt}LoaderTest40Id${cqt}) REFERENCES ${oqt}${table40_name}${cqt} (${oqt}Id${cqt}) + ) $self->{innodb} +|, +qq| INSERT INTO ${oqt}${table40_name}${cqt} VALUES (1, 'foo') |, +qq| INSERT INTO ${oqt}${table41_name}${cqt} VALUES (1, 1) |, + ); + $conn->storage->disconnect; + + local $conn->_loader->{preserve_case} = 1; + $conn->_loader->_setup; + + $self->rescan_without_warnings($conn); + + if (not $self->{skip_rels}) { + ok my $row = try { $conn->resultset('LoaderTest41')->find(1) }, + 'row in mixed-case table'; + ok my $related_row = try { $row->loader_test40 }, + 'rel in mixed-case table'; + is try { $related_row->foo3_bar }, 'foo', + 'accessor for mixed-case column name in mixed case table'; + } + else { + SKIP: { skip 'not testing mixed-case rels with skip_rels', 2 } + + is try { $conn->resultset('LoaderTest40')->find(1)->foo3_bar }, 'foo', + 'accessor for mixed-case column name in mixed case table'; + } +} + +sub monikers_and_classes { + my ($self, $schema_class) = @_; + my ($monikers, $classes); + + foreach my $source_name ($schema_class->sources) { + my $table_name = $schema_class->source($source_name)->from; + + $table_name = $$table_name if ref $table_name; + + my $result_class = $schema_class->source($source_name)->result_class; + + $monikers->{$table_name} = $source_name; + $classes->{$table_name} = $result_class; + + # some DBs (Firebird) uppercase everything + $monikers->{lc $table_name} = $source_name; + $classes->{lc $table_name} = $result_class; + } + + return ($monikers, $classes); +} + sub check_no_duplicate_unique_constraints { my ($class) = @_; @@ -890,7 +1318,7 @@ sub dbconnect { }, ]); - my $dbh = eval { $storage->dbh }; + my $dbh = $storage->dbh; die "Failed to connect to database: $@" if !$dbh; $self->{storage} = $storage; # storage DESTROY disconnects @@ -898,11 +1326,33 @@ sub dbconnect { return $dbh; } +sub get_oqt_cqt { + my $self = shift; + my %opts = @_; + + if ((not $opts{always}) && $self->{preserve_case_mode_is_exclusive}) { + return ('', ''); + } + + # XXX should get quote_char from the storage of an initialized loader. + my ($oqt, $cqt); # open quote, close quote + if (ref $self->{quote_char}) { + ($oqt, $cqt) = @{ $self->{quote_char} }; + } + else { + $oqt = $cqt = $self->{quote_char} || ''; + } + + return ($oqt, $cqt); +} + sub create { my $self = shift; $self->{_created} = 1; + $self->drop_tables; + my $make_auto_inc = $self->{auto_inc_cb} || sub {}; @statements = ( qq{ @@ -917,11 +1367,22 @@ sub create { q{ INSERT INTO loader_test1s (dat) VALUES('bar') }, q{ INSERT INTO loader_test1s (dat) VALUES('baz') }, + # also test method collision + # crumb_crisp_coating is for col_accessor_map tests qq{ CREATE TABLE loader_test2 ( id $self->{auto_inc_pk}, dat VARCHAR(32) NOT NULL, dat2 VARCHAR(32) NOT NULL, + set_primary_key INTEGER $self->{null}, + can INTEGER $self->{null}, + dbix_class_testcomponent INTEGER $self->{null}, + dbix_class_testcomponentmap INTEGER $self->{null}, + testcomponent_fqn INTEGER $self->{null}, + meta INTEGER $self->{null}, + test_role_method INTEGER $self->{null}, + test_role_for_map_method INTEGER $self->{null}, + crumb_crisp_coating VARCHAR(32) $self->{null}, UNIQUE (dat2, dat) ) $self->{innodb} }, @@ -933,7 +1394,7 @@ sub create { q{ INSERT INTO loader_test2 (dat, dat2) VALUES('ddd', 'www') }, qq{ - CREATE TABLE LOADER_TEST23 ( + CREATE TABLE LOADER_test23 ( ID INTEGER NOT NULL PRIMARY KEY, DAT VARCHAR(32) NOT NULL UNIQUE ) $self->{innodb} @@ -946,26 +1407,55 @@ sub create { ) $self->{innodb} }, - qq{ +# Access does not support DEFAULT + $self->{vendor} ne 'Access' ? qq{ CREATE TABLE loader_test35 ( id INTEGER NOT NULL PRIMARY KEY, a_varchar VARCHAR(100) DEFAULT 'foo', an_int INTEGER DEFAULT 42, + a_negative_int INTEGER DEFAULT -42, a_double DOUBLE PRECISION DEFAULT 10.555, + a_negative_double DOUBLE PRECISION DEFAULT -10.555, a_function $self->{default_function_def} ) $self->{innodb} + } : qq{ + CREATE TABLE loader_test35 ( + id INTEGER NOT NULL PRIMARY KEY, + a_varchar VARCHAR(100), + an_int INTEGER, + a_negative_int INTEGER, + a_double DOUBLE, + a_negative_double DOUBLE, + a_function DATETIME + ) }, qq{ CREATE TABLE loader_test36 ( id INTEGER NOT NULL PRIMARY KEY, - a_date $self->{date_datatype}, + a_date $self->{basic_date_datatype}, b_char_as_data VARCHAR(100), c_char_as_data VARCHAR(100) ) $self->{innodb} }, + qq{ + CREATE TABLE loader_test50 ( + id INTEGER NOT NULL UNIQUE, + id1 INTEGER NOT NULL, + id2 INTEGER NOT NULL, + @{[ $self->{vendor} !~ /^(?:DB2|SQLAnywhere)\z/i ? " + id3 INTEGER $self->{null}, + id4 INTEGER NOT NULL, + UNIQUE (id3, id4), + " : '' ]} + UNIQUE (id1, id2) + ) $self->{innodb} + }, ); + # some DBs require mixed case identifiers to be quoted + my ($oqt, $cqt) = $self->get_oqt_cqt; + @statements_reltests = ( qq{ CREATE TABLE loader_test3 ( @@ -984,53 +1474,73 @@ sub create { id INTEGER NOT NULL PRIMARY KEY, fkid INTEGER NOT NULL, dat VARCHAR(32), - FOREIGN KEY( fkid ) REFERENCES loader_test3 (id) + belongs_to INTEGER $self->{null}, + set_primary_key INTEGER $self->{null}, + FOREIGN KEY( fkid ) REFERENCES loader_test3 (id), + FOREIGN KEY( belongs_to ) REFERENCES loader_test3 (id), + FOREIGN KEY( set_primary_key ) REFERENCES loader_test3 (id) ) $self->{innodb} }, - q{ INSERT INTO loader_test4 (id,fkid,dat) VALUES(123,1,'aaa') }, - q{ INSERT INTO loader_test4 (id,fkid,dat) VALUES(124,2,'bbb') }, - q{ INSERT INTO loader_test4 (id,fkid,dat) VALUES(125,3,'ccc') }, - q{ INSERT INTO loader_test4 (id,fkid,dat) VALUES(126,4,'ddd') }, + q{ INSERT INTO loader_test4 (id,fkid,dat,belongs_to,set_primary_key) VALUES(123,1,'aaa',1,1) }, + q{ INSERT INTO loader_test4 (id,fkid,dat,belongs_to,set_primary_key) VALUES(124,2,'bbb',2,2) }, + q{ INSERT INTO loader_test4 (id,fkid,dat,belongs_to,set_primary_key) VALUES(125,3,'ccc',3,3) }, + q{ INSERT INTO loader_test4 (id,fkid,dat,belongs_to,set_primary_key) VALUES(126,4,'ddd',4,4) }, - qq{ + qq| CREATE TABLE loader_test5 ( id1 INTEGER NOT NULL, - iD2 INTEGER NOT NULL, + ${oqt}iD2${cqt} INTEGER NOT NULL, dat VARCHAR(8), from_id INTEGER $self->{null}, to_id INTEGER $self->{null}, - PRIMARY KEY (id1,iD2), + PRIMARY KEY (id1,${oqt}iD2${cqt}), FOREIGN KEY (from_id) REFERENCES loader_test4 (id), FOREIGN KEY (to_id) REFERENCES loader_test4 (id) ) $self->{innodb} - }, + |, - q{ INSERT INTO loader_test5 (id1,iD2,dat) VALUES (1,1,'aaa') }, + qq| INSERT INTO loader_test5 (id1,${oqt}iD2${cqt},dat) VALUES (1,1,'aaa') |, - qq{ + qq| CREATE TABLE loader_test6 ( id INTEGER NOT NULL PRIMARY KEY, - Id2 INTEGER, + ${oqt}Id2${cqt} INTEGER, loader_test2_id INTEGER, dat VARCHAR(8), FOREIGN KEY (loader_test2_id) REFERENCES loader_test2 (id), - FOREIGN KEY(id,Id2) REFERENCES loader_test5 (id1,iD2) + FOREIGN KEY(id,${oqt}Id2${cqt}) REFERENCES loader_test5 (id1,${oqt}iD2${cqt}) ) $self->{innodb} - }, + |, - (q{ INSERT INTO loader_test6 (id, Id2,loader_test2_id,dat) } . + (qq| INSERT INTO loader_test6 (id, ${oqt}Id2${cqt},loader_test2_id,dat) | . q{ VALUES (1, 1,1,'aaa') }), + # here we are testing adjective detection + qq{ CREATE TABLE loader_test7 ( id INTEGER NOT NULL PRIMARY KEY, id2 VARCHAR(8) NOT NULL UNIQUE, - dat VARCHAR(8) + dat VARCHAR(8), + lovely_loader_test6 INTEGER NOT NULL UNIQUE, + FOREIGN KEY (lovely_loader_test6) REFERENCES loader_test6 (id) ) $self->{innodb} }, - q{ INSERT INTO loader_test7 (id,id2,dat) VALUES (1,'aaa','bbb') }, + q{ INSERT INTO loader_test7 (id,id2,dat,lovely_loader_test6) VALUES (1,'aaa','bbb',1) }, + + # for some DBs we need a named FK to drop later + ($self->{vendor} =~ /^(mssql|sybase|access|mysql)\z/i ? ( + (q{ ALTER TABLE loader_test6 ADD } . + qq{ loader_test7_id INTEGER $self->{null} }), + (q{ ALTER TABLE loader_test6 ADD CONSTRAINT loader_test6_to_7_fk } . + q{ FOREIGN KEY (loader_test7_id) } . + q{ REFERENCES loader_test7 (id) }) + ) : ( + (q{ ALTER TABLE loader_test6 ADD } . + qq{ loader_test7_id INTEGER $self->{null} REFERENCES loader_test7 (id) }), + )), qq{ CREATE TABLE loader_test8 ( @@ -1041,8 +1551,9 @@ sub create { ) $self->{innodb} }, - (q{ INSERT INTO loader_test8 (id,loader_test7,dat) } . - q{ VALUES (1,'aaa','bbb') }), + (q{ INSERT INTO loader_test8 (id,loader_test7,dat) VALUES (1,'aaa','bbb') }), + (q{ INSERT INTO loader_test8 (id,loader_test7,dat) VALUES (2,'aaa','bbb') }), + (q{ INSERT INTO loader_test8 (id,loader_test7,dat) VALUES (3,'aaa','bbb') }), qq{ CREATE TABLE loader_test9 ( @@ -1053,13 +1564,27 @@ sub create { qq{ CREATE TABLE loader_test16 ( id INTEGER NOT NULL PRIMARY KEY, - dat VARCHAR(8) + dat VARCHAR(8), + loader_test8_id INTEGER NOT NULL UNIQUE, + FOREIGN KEY (loader_test8_id) REFERENCES loader_test8 (id) ) $self->{innodb} }, - qq{ INSERT INTO loader_test16 (id,dat) VALUES (2,'x16') }, - qq{ INSERT INTO loader_test16 (id,dat) VALUES (4,'y16') }, - qq{ INSERT INTO loader_test16 (id,dat) VALUES (6,'z16') }, + qq{ INSERT INTO loader_test16 (id,dat,loader_test8_id) VALUES (2,'x16',1) }, + qq{ INSERT INTO loader_test16 (id,dat,loader_test8_id) VALUES (4,'y16',2) }, + qq{ INSERT INTO loader_test16 (id,dat,loader_test8_id) VALUES (6,'z16',3) }, + + # for some DBs we need a named FK to drop later + ($self->{vendor} =~ /^(mssql|sybase|access|mysql)\z/i ? ( + (q{ ALTER TABLE loader_test8 ADD } . + qq{ loader_test16_id INTEGER $self->{null} }), + (q{ ALTER TABLE loader_test8 ADD CONSTRAINT loader_test8_to_16_fk } . + q{ FOREIGN KEY (loader_test16_id) } . + q{ REFERENCES loader_test16 (id) }) + ) : ( + (q{ ALTER TABLE loader_test8 ADD } . + qq{ loader_test16_id INTEGER $self->{null} REFERENCES loader_test16 (id) }), + )), qq{ CREATE TABLE loader_test17 ( @@ -1226,7 +1751,7 @@ sub create { FOREIGN KEY (id,rel2) REFERENCES loader_test33(id1,id2) ) $self->{innodb} }, - q{ INSERT INTO loader_test34 (id,rel1) VALUES (1,2) }, + q{ INSERT INTO loader_test34 (id,rel1,rel2) VALUES (1,2,2) }, ); @statements_advanced = ( @@ -1239,19 +1764,27 @@ sub create { }, $make_auto_inc->(qw/loader_test10 id10/), +# Access does not support DEFAULT. qq{ CREATE TABLE loader_test11 ( id11 $self->{auto_inc_pk}, - a_message VARCHAR(8) DEFAULT 'foo', + a_message VARCHAR(8) @{[ $self->{vendor} ne 'Access' ? "DEFAULT 'foo'" : '' ]}, loader_test10 INTEGER $self->{null}, FOREIGN KEY (loader_test10) REFERENCES loader_test10 (id10) ) $self->{innodb} }, $make_auto_inc->(qw/loader_test11 id11/), - (q{ ALTER TABLE loader_test10 ADD CONSTRAINT } . - q{ loader_test11_fk FOREIGN KEY (loader_test11) } . - q{ REFERENCES loader_test11 (id11) }), + (lc($self->{vendor}) ne 'informix' ? + (q{ ALTER TABLE loader_test10 ADD CONSTRAINT loader_test11_fk } . + q{ FOREIGN KEY (loader_test11) } . + q{ REFERENCES loader_test11 (id11) }) + : + (q{ ALTER TABLE loader_test10 ADD CONSTRAINT } . + q{ FOREIGN KEY (loader_test11) } . + q{ REFERENCES loader_test11 (id11) } . + q{ CONSTRAINT loader_test11_fk }) + ), ); @statements_advanced_sqlite = ( @@ -1326,18 +1859,27 @@ sub create { my $dbh = $self->dbconnect(1); - # Silence annoying but harmless postgres "NOTICE: CREATE TABLE..." - local $SIG{__WARN__} = sub { - my $msg = shift; - print STDERR $msg unless $msg =~ m{^NOTICE:\s+CREATE TABLE}; - }; + $dbh->do($_) for @{ $self->{pre_create} || [] }; - $dbh->do($_) for (@statements); - unless($self->{skip_rels}) { + $dbh->do($_) foreach (@statements); + + if (not ($self->{vendor} eq 'mssql' && $dbh->{Driver}{Name} eq 'Sybase')) { + $dbh->do($_) foreach (@{ $self->{data_type_tests}{ddl} || [] }); + } + + unless ($self->{skip_rels}) { # hack for now, since DB2 doesn't like inline comments, and we need # to test one for mysql, which works on everyone else... # this all needs to be refactored anyways. - $dbh->do($_) for (@statements_reltests); + + for my $stmt (@statements_reltests) { + try { + $dbh->do($stmt); + } + catch { + die "Error executing '$stmt': $_\n"; + }; + } if($self->{vendor} =~ /sqlite/i) { $dbh->do($_) for (@statements_advanced_sqlite); } @@ -1360,12 +1902,14 @@ sub drop_tables { my $self = shift; my @tables = qw/ + loader_test1 loader_test1s loader_test2 - LOADER_TEST23 + LOADER_test23 LoAdEr_test24 loader_test35 loader_test36 + loader_test50 /; my @tables_auto_inc = ( @@ -1421,45 +1965,93 @@ sub drop_tables { my @tables_rescan = qw/ loader_test30 /; - my $drop_fk_mysql = - q{ALTER TABLE loader_test10 DROP FOREIGN KEY loader_test11_fk}; + my @tables_preserve_case_tests = @{ $self->{preserve_case_tests_table_names} }; - my $drop_fk = - q{ALTER TABLE loader_test10 DROP CONSTRAINT loader_test11_fk}; + my %drop_columns = ( + loader_test6 => 'loader_test7_id', + loader_test7 => 'lovely_loader_test6', + loader_test8 => 'loader_test16_id', + loader_test16 => 'loader_test8_id', + ); - my $dbh = $self->dbconnect(0); + my %drop_constraints = ( + loader_test10 => 'loader_test11_fk', + loader_test6 => 'loader_test6_to_7_fk', + loader_test8 => 'loader_test8_to_16_fk', + ); - $dbh->do($_) for @{ $self->{extra}{pre_drop_ddl} || [] }; - $dbh->do("DROP TABLE $_") for @{ $self->{extra}{drop} || [] }; + # For some reason some tests do this twice (I guess dependency issues?) + # do it twice for all drops + for (1,2) { + local $^W = 0; # for ADO - my $drop_auto_inc = $self->{auto_inc_drop_cb} || sub {}; + my $dbh = $self->dbconnect(0); - unless($self->{skip_rels}) { - $dbh->do("DROP TABLE $_") for (@tables_reltests); - if($self->{vendor} =~ /mysql/i) { - $dbh->do($drop_fk_mysql); - } - else { - $dbh->do($drop_fk); - } - $dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_advanced_auto_inc; - $dbh->do("DROP TABLE $_") for (@tables_advanced); + $dbh->do($_) for @{ $self->{extra}{pre_drop_ddl} || [] }; - unless($self->{no_inline_rels}) { - $dbh->do("DROP TABLE $_") for (@tables_inline_rels); + $self->drop_table($dbh, $_) for @{ $self->{extra}{drop} || [] }; + + my $drop_auto_inc = $self->{auto_inc_drop_cb} || sub {}; + + unless ($self->{skip_rels}) { + # drop the circular rel columns if possible, this + # doesn't work on all DBs + foreach my $table (keys %drop_columns) { + $dbh->do("ALTER TABLE $table DROP $drop_columns{$table}"); + $dbh->do("ALTER TABLE $table DROP COLUMN $drop_columns{$table}"); + } + + foreach my $table (keys %drop_constraints) { + # for MSSQL + $dbh->do("ALTER TABLE $table DROP $drop_constraints{$table}"); + # for Sybase and Access + $dbh->do("ALTER TABLE $table DROP CONSTRAINT $drop_constraints{$table}"); + # for MySQL + $dbh->do("ALTER TABLE $table DROP FOREIGN KEY $drop_constraints{$table}"); + } + + $self->drop_table($dbh, $_) for (@tables_reltests); + $self->drop_table($dbh, $_) for (@tables_reltests); + + $dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_advanced_auto_inc; + + $self->drop_table($dbh, $_) for (@tables_advanced); + + unless($self->{no_inline_rels}) { + $self->drop_table($dbh, $_) for (@tables_inline_rels); + } + unless($self->{no_implicit_rels}) { + $self->drop_table($dbh, $_) for (@tables_implicit_rels); + } } - unless($self->{no_implicit_rels}) { - $dbh->do("DROP TABLE $_") for (@tables_implicit_rels); + $dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_auto_inc; + $self->drop_table($dbh, $_) for (@tables, @tables_rescan); + + if (not ($self->{vendor} eq 'mssql' && $dbh->{Driver}{Name} eq 'Sybase')) { + foreach my $data_type_table (@{ $self->{data_type_tests}{table_names} || [] }) { + $self->drop_table($dbh, $data_type_table); + } } + + $self->drop_table($dbh, $_) for @tables_preserve_case_tests; + + $dbh->disconnect; } - $dbh->do($_) for map { $drop_auto_inc->(@$_) } @tables_auto_inc; - $dbh->do("DROP TABLE $_") for (@tables, @tables_rescan); - $dbh->disconnect; - -# fixup for Firebird - $dbh = $self->dbconnect(0); - $dbh->do('DROP TABLE loader_test2'); - $dbh->disconnect; +} + +sub drop_table { + my ($self, $dbh, $table) = @_; + + local $^W = 0; # for ADO + + try { $dbh->do("DROP TABLE $table CASCADE CONSTRAINTS") }; # oracle + try { $dbh->do("DROP TABLE $table CASCADE") }; # postgres and ? + try { $dbh->do("DROP TABLE $table") }; + + # if table name is case sensitive + my ($oqt, $cqt) = $self->get_oqt_cqt(always => 1); + + try { $dbh->do("DROP TABLE ${oqt}${table}${cqt}") }; } sub _custom_column_info { @@ -1485,12 +2077,128 @@ sub _custom_column_info { return; } +my %DATA_TYPE_MULTI_TABLE_OVERRIDES = ( + oracle => qr/\blong\b/i, + mssql => qr/\b(?:timestamp|rowversion)\b/i, + informix => qr/\b(?:bigserial|serial8)\b/i, +); + +sub setup_data_type_tests { + my $self = shift; + + return unless my $types = $self->{data_types}; + + my $tests = $self->{data_type_tests} = {}; + + # split types into tables based on overrides + my (@types, @split_off_types, @first_table_types); + { + my $split_off_re = $DATA_TYPE_MULTI_TABLE_OVERRIDES{lc($self->{vendor})} || qr/(?!)/; + + @types = keys %$types; + @split_off_types = grep /$split_off_re/, @types; + @first_table_types = grep !/$split_off_re/, @types; + } + + @types = +{ map +($_, $types->{$_}), @first_table_types }, + map +{ $_, $types->{$_} }, @split_off_types; + + my $test_count = 0; + my $table_num = 10000; + + foreach my $types (@types) { + my $table_name = "loader_test$table_num"; + push @{ $tests->{table_names} }, $table_name; + + my $table_moniker = "LoaderTest$table_num"; + push @{ $tests->{table_monikers} }, $table_moniker; + + $table_num++; + + my $cols = $tests->{columns}{$table_moniker} = {}; + + my $ddl = "CREATE TABLE $table_name (\n id INTEGER NOT NULL PRIMARY KEY,\n"; + + my %seen_col_names; + + while (my ($col_def, $expected_info) = each %$types) { + (my $type_alias = $col_def) =~ s/\( ([^)]+) \)//xg; + + my $size = $1; + $size = '' unless defined $size; + $size =~ s/\s+//g; + my @size = split /,/, $size; + + # some DBs don't like very long column names + if ($self->{vendor} =~ /^(?:firebird|sqlanywhere|oracle|db2|mysql)\z/i) { + my ($col_def, $default) = $type_alias =~ /^(.*)(default.*)?\z/i; + + $type_alias = substr $col_def, 0, 15; + + $type_alias .= '_with_dflt' if $default; + } + + $type_alias =~ s/\s/_/g; + $type_alias =~ s/\W//g; + + my $col_name = 'col_' . $type_alias; + + if (@size) { + my $size_name = join '_', apply { s/\W//g } @size; + + $col_name .= "_sz_$size_name"; + } + + # XXX would be better to check _loader->preserve_case + $col_name = lc $col_name; + + $col_name .= '_' . $seen_col_names{$col_name} if $seen_col_names{$col_name}++; + + $ddl .= " $col_name $col_def,\n"; + + $cols->{$col_name} = $expected_info; + + $test_count++; + } + + $ddl =~ s/,\n\z/\n)/; + + push @{ $tests->{ddl} }, $ddl; + } + + $tests->{test_count} = $test_count; + + return $test_count; +} + +sub rescan_without_warnings { + my ($self, $conn) = @_; + + local $SIG{__WARN__} = sub { warn @_ unless $_[0] =~ RESCAN_WARNINGS }; + return $conn->rescan; +} + +sub test_col_accessor_map { + my ( $column_name, $default_name, $context ) = @_; + if( lc($column_name) eq 'crumb_crisp_coating' ) { + + is( $default_name, 'crumb_crisp_coating', 'col_accessor_map was passed the default name' ); + ok( $context->{$_}, "col_accessor_map func was passed the $_" ) + for qw( table_name table_class table_moniker schema_class ); + + return 'trivet'; + } else { + return $default_name; + } +} + sub DESTROY { my $self = shift; unless ($ENV{SCHEMA_LOADER_TESTS_NOCLEANUP}) { - $self->drop_tables if $self->{_created}; - rmtree $DUMP_DIR + $self->drop_tables if $self->{_created}; + rmtree DUMP_DIR } } 1; +# vim:et sts=4 sw=4 tw=0: