X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Fconstructor.t;h=810f3f91f4e5768dc5260c9a43aff5ac435505cb;hb=74effc7cd0df7b40594266643196c4ed387eb610;hp=90e8ea1327a46dff51a9d33767049d074ba82e2c;hpb=64c572f8a67500716757f45975103d58b9324e8c;p=gitmo%2FMooseX-UndefTolerant.git

diff --git a/t/constructor.t b/t/constructor.t
index 90e8ea1..810f3f9 100644
--- a/t/constructor.t
+++ b/t/constructor.t
@@ -1,140 +1,15 @@
-use Test::More;
-use Test::Fatal;
-
-{
-    package Foo;
-    use Moose;
-
-    has 'attr1' => (
-        traits => [ qw(MooseX::UndefTolerant::Attribute)],
-        is => 'ro',
-        isa => 'Num',
-        predicate => 'has_attr1',
-    );
-    has 'attr2' => (
-        is => 'ro',
-        isa => 'Num',
-        predicate => 'has_attr2',
-    );
-    has 'attr3' => (
-        is => 'ro',
-        isa => 'Maybe[Num]',
-        predicate => 'has_attr3',
-    );
-}
-
-{
-    package Bar;
-    use Moose;
-    use MooseX::UndefTolerant;
-
-    has 'attr1' => (
-        is => 'ro',
-        isa => 'Num',
-        predicate => 'has_attr1',
-    );
-    has 'attr2' => (
-        is => 'ro',
-        isa => 'Num',
-        predicate => 'has_attr2',
-    );
-    has 'attr3' => (
-        is => 'ro',
-        isa => 'Maybe[Num]',
-        predicate => 'has_attr3',
-    );
-}
-
-package main;
-
-sub do_tests
-{
-    note 'Testing class with a single UndefTolerant attribute';
-    {
-        my $obj = Foo->new;
-        ok(!$obj->has_attr1, 'attr1 has no value before it is assigned');
-        ok(!$obj->has_attr2, 'attr2 has no value before it is assigned');
-        ok(!$obj->has_attr3, 'attr3 has no value before it is assigned');
-    }
-
-    {
-        my $obj = Foo->new(attr1 => undef);
-        ok(!$obj->has_attr1, 'UT attr1 has no value when assigned undef in constructor');
-        like(
-            exception { $obj = Foo->new(attr2 => undef) },
-            qr/\QAttribute (attr2) does not pass the type constraint because: Validation failed for 'Num' with value undef\E/,
-            'But assigning undef to attr2 generates a type constraint error');
-
-        is (exception { $obj = Foo->new(attr3 => undef) }, undef,
-            'assigning undef to attr3 is acceptable');
-        ok($obj->has_attr3, 'attr3 retains its undef value when assigned undef in constructor');
-    }
-
-    {
-        my $obj = Foo->new(attr1 => 1234, attr2 => 5678, attr3 => 9012);
-        is($obj->attr1, 1234, 'assigning a defined value during construction works as normal');
-        ok($obj->has_attr1, '...and the predicate returns true as normal');
-
-        is($obj->attr2, 5678, 'assigning a defined value during construction works as normal');
-        ok($obj->has_attr2, '...and the predicate returns true as normal');
-
-        is($obj->attr3, 9012, 'assigning a defined value during construction works as normal');
-        ok($obj->has_attr3, '...and the predicate returns true as normal');
-    }
-
-
-    note '';
-    note 'Testing class with the entire class being UndefTolerant';
-    {
-        my $obj = Bar->new;
-        ok(!$obj->has_attr1, 'attr1 has no value before it is assigned');
-        ok(!$obj->has_attr2, 'attr2 has no value before it is assigned');
-        ok(!$obj->has_attr3, 'attr3 has no value before it is assigned');
-    }
-
-    {
-        my $obj = Bar->new(attr1 => undef);
-        ok(!$obj->has_attr1, 'attr1 has no value when assigned undef in constructor');
-        # note this test differs from the Foo case above
-        is (exception { $obj = Bar->new(attr2 => undef) }, undef,
-            'assigning undef to attr2 does not produce an error');
-        ok(!$obj->has_attr2, 'attr2 has no value when assigned undef in constructor');
-
-        is( exception { $obj = Foo->new(attr3 => undef) }, undef,
-            'assigning undef to attr3 is acceptable');
-        ok($obj->has_attr3, 'attr3 retains its undef value when assigned undef in constructor');
-    }
-
-    {
-        my $obj = Bar->new(attr1 => 1234, attr2 => 5678, attr3 => 9012);
-        is($obj->attr1, 1234, 'assigning a defined value during construction works as normal');
-        ok($obj->has_attr1, '...and the predicate returns true as normal');
-
-        is($obj->attr2, 5678, 'assigning a defined value during construction works as normal');
-        ok($obj->has_attr2, '...and the predicate returns true as normal');
-
-        is($obj->attr3, 9012, 'assigning a defined value during construction works as normal');
-        ok($obj->has_attr3, '...and the predicate returns true as normal');
-    }
-}
+use strict;
+use warnings;
 
+use Test::More;
+use Test::Moose;
 
-note 'Constructor behaviour: mutable classes';
-note '';
-do_tests;
+use lib 't/lib';
+use ConstructorTests;
 
-note '';
-note 'Constructor behaviour: immutable classes';
-note '';
-Foo->meta->make_immutable;
-Bar->meta->make_immutable;
-TODO: {
-    local $TODO = 'some immutable cases are not handled yet';
-    # for now, catch errors
-    is(exception { do_tests }, undef, 'tests do not die');
+with_immutable { ConstructorTests::do_tests() } qw(Foo Bar);
 
-    is(Test::More->builder->current_test, 28, 'if we got here, we can declare victory!');
-}
+note 'Ran ', Test::More->builder->current_test, ' tests - should have run 56';
 
 done_testing;