X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Fbasic.t;h=576f0ee6177b2e709283c3ff2c765d10ad693eec;hb=f512614eabefb07d227d03e9416b8ec8d7502a20;hp=65aef05e4dc30f7484642375ffeae5c2e5022e2b;hpb=a83dec4353207816d24e09f0f3a7afc2200369c4;p=gitmo%2FMooseX-StrictConstructor.git diff --git a/t/basic.t b/t/basic.t index 65aef05..576f0ee 100644 --- a/t/basic.t +++ b/t/basic.t @@ -1,7 +1,7 @@ use strict; use warnings; -use Test::More tests => 12; +use Test::More tests => 15; { @@ -56,6 +56,18 @@ use Test::More tests => 12; } { + package ImmutableInitArg; + + use MooseX::StrictConstructor; + + has 'thing' => ( is => 'rw', 'init_arg' => 'other' ); + has 'size' => ( is => 'rw', 'init_arg' => undef ); + + no Moose; + __PACKAGE__->meta()->make_immutable(); +} + +{ package Immutable; use MooseX::StrictConstructor; @@ -92,6 +104,9 @@ is( $@, '', 'standard Moose class ignores unknown params' ); eval { Stricter->new( thing => 1, bad => 99 ) }; like( $@, qr/unknown attribute.+: bad/, 'strict constructor blows up on unknown params' ); +eval { Subclass->new( thing => 1, size => 'large' ) }; +is( $@, '', 'subclass constructor handles known attributes correctly' ); + eval { Tricky->new( thing => 1, spy => 99 ) }; is( $@, '', 'can work around strict constructor by deleting params in BUILD()' ); @@ -101,8 +116,29 @@ like( $@, qr/unknown attribute.+: agent/, 'Tricky still blows up on unknown para eval { Subclass->new( thing => 1, bad => 99 ) }; like( $@, qr/unknown attribute.+: bad/, 'subclass constructor blows up on unknown params' ); -eval { Subclass->new( thing => 1, size => 'large' ) }; -is( $@, '', 'subclass constructor handles known attributes correctly' ); +eval { InitArg->new( thing => 1 ) }; +like( $@, qr/unknown attribute.+: thing/, + 'InitArg blows up with attribute name' ); + +eval { InitArg->new( size => 1 ) }; +like( $@, qr/unknown attribute.+: size/, + 'InitArg blows up when given attribute with undef init_arg' ); + +eval { InitArg->new( other => 1 ) }; +is( $@, '', + 'InitArg works when given proper init_arg' ); + +eval { ImmutableInitArg->new( thing => 1 ) }; +like( $@, qr/unknown attribute.+: thing/, + 'ImmutableInitArg blows up with attribute name' ); + +eval { ImmutableInitArg->new( size => 1 ) }; +like( $@, qr/unknown attribute.+: size/, + 'ImmutableInitArg blows up when given attribute with undef init_arg' ); + +eval { ImmutableInitArg->new( other => 1 ) }; +is( $@, '', + 'ImmutableInitArg works when given proper init_arg' ); eval { Immutable->new( thing => 1, bad => 99 ) }; like( $@, qr/unknown attribute.+: bad/, @@ -115,15 +151,3 @@ is( $@, '', eval { ImmutableTricky->new( thing => 1, agent => 99 ) }; like( $@, qr/unknown attribute.+: agent/, 'ImmutableTricky still blows up on unknown params other than spy' ); - -eval { InitArg->new( thing => 1 ) }; -like( $@, qr/unknown attribute.+: thing/, - 'InitArg blows up with attribute name' ); - -eval { InitArg->new( size => 1 ) }; -like( $@, qr/unknown attribute.+: size/, - 'InitArg blows up when given attribute with undef init_arg' ); - -eval { InitArg->new( other => 1 ) }; -is( $@, '', - 'InitArg works when given proper init_arg' );