X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Faccessors_ro.t;h=33d3f38a3dfd96a6b6e69ce5c528ff058bcd0198;hb=76427bb1ddcfc2374ae9eb615855adf19069a55b;hp=79413ffa7d0a18e2997977f0589c3a6a3a5456e6;hpb=8443030080ecfca256b68ce0d26df9e6a79b1a37;p=p5sagit%2FClass-Accessor-Grouped.git

diff --git a/t/accessors_ro.t b/t/accessors_ro.t
index 79413ff..33d3f38 100644
--- a/t/accessors_ro.t
+++ b/t/accessors_ro.t
@@ -1,7 +1,8 @@
-use Test::More tests => 48;
+use Test::More;
 use Test::Exception;
 use strict;
 use warnings;
+no warnings 'once';
 use lib 't/lib';
 
 # we test the pure-perl versions only, but allow overrides
@@ -10,10 +11,10 @@ use lib 't/lib';
 # things
 my $use_xs;
 BEGIN {
-    $Class::Accessor::Grouped::USE_XS = 0
-        unless defined $Class::Accessor::Grouped::USE_XS;
-    $ENV{CAG_USE_XS} = 1;
-    $use_xs = $Class::Accessor::Grouped::USE_XS;
+  $Class::Accessor::Grouped::USE_XS = 0
+    unless defined $Class::Accessor::Grouped::USE_XS;
+  $ENV{CAG_USE_XS} = 1;
+  $use_xs = $Class::Accessor::Grouped::USE_XS;
 };
 
 use AccessorGroupsRO;
@@ -21,76 +22,87 @@ use AccessorGroupsRO;
 my $obj = AccessorGroupsRO->new;
 
 {
-    my $warned = 0;
+  my $warned = 0;
 
-    local $SIG{__WARN__} = sub {
-        if  (shift =~ /DESTROY/i) {
-            $warned++;
-        };
+  local $SIG{__WARN__} = sub {
+    if  (shift =~ /DESTROY/i) {
+      $warned++;
     };
+  };
 
-    no warnings qw/once/;
-    local *AccessorGroupsRO::DESTROY = sub {};
+  no warnings qw/once/;
+  local *AccessorGroupsRO::DESTROY = sub {};
 
-    $obj->mk_group_ro_accessors('warnings', 'DESTROY');
+  $obj->mk_group_ro_accessors('warnings', 'DESTROY');
 
-    ok($warned);
+  ok($warned);
 };
 
 my $test_accessors = {
-    singlefield => {
-        is_xs => $use_xs,
-    },
-    multiple1 => {
-    },
-    multiple2 => {
-    },
-    lr1name => {
-        custom_field => 'lr1;field',
-    },
-    lr2name => {
-        custom_field => "lr2'field",
-    },
+  singlefield => {
+    is_xs => $use_xs,
+  },
+  multiple1 => {
+  },
+  multiple2 => {
+  },
+  lr1name => {
+    custom_field => 'lr1;field',
+  },
+  lr2name => {
+    custom_field => "lr2'field",
+  },
+  fieldname_torture => {
+    custom_field => join ('', map { chr($_) } (0..255) ),
+    is_xs => $use_xs,
+  },
 };
 
 for my $name (sort keys %$test_accessors) {
 
-    my $alias = "_${name}_accessor";
-    my $field = $test_accessors->{$name}{custom_field} || $name;
+  my $alias = "_${name}_accessor";
+  my $field = $test_accessors->{$name}{custom_field} || $name;
 
-    can_ok($obj, $name, $alias);
+  can_ok($obj, $name, $alias);
 
-    ok(!$obj->can($field))
-      if $field ne $name;
+  ok(!$obj->can($field))
+    if $field ne $name;
 
-    is($obj->$name, undef);
-    is($obj->$alias, undef);
+  is($obj->$name, undef);
+  is($obj->$alias, undef);
 
-    # get via name
-    $obj->{$field} = 'a';
-    is($obj->$name, 'a');
+  # get via name
+  $obj->{$field} = 'a';
+  is($obj->$name, 'a');
 
-    # alias gets same as name
-    is($obj->$alias, 'a');
+  # alias gets same as name
+  is($obj->$alias, 'a');
 
-    my $ro_regex = $test_accessors->{$name}{is_xs}
-        ? qr/Usage\:.+$name.*\(self\)/
-        : qr/cannot alter the value of '\Q$field\E'/
-    ;
+  my $ro_regex = $test_accessors->{$name}{is_xs}
+    ? qr/Usage\:.+$name.*\(self\)/
+    : qr/$name(:?_accessor)?\Q' cannot alter its value (read-only attribute of class AccessorGroupsRO)/
+  ;
+
+  SKIP: {
+    skip "Class::XSAccessor emits broken error messages on 5.10 and earlier", 1 if (
+      $test_accessors->{$name}{is_xs}
+        and
+      $] < '5.011'
+    );
 
     # die on set via name/alias
     throws_ok {
-        $obj->$name('b');
+      $obj->$name('b');
     } $ro_regex;
 
     throws_ok {
-        $obj->$alias('b');
+      $obj->$alias('b');
     } $ro_regex;
+  }
 
-    # value should be unchanged
-    is($obj->$name, 'a');
-    is($obj->$alias, 'a');
+  # value should be unchanged
+  is($obj->$name, 'a');
+  is($obj->$alias, 'a');
 };
 
-#important
-1;
+done_testing unless $::SUBTESTING;