X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2Faccessors.t;h=41130710e1462ba5c3716846da91b204e526e9be;hb=6c6bc8c2ab1a427010501b54b2959c9e2ba23515;hp=e10f1022c892fa772fee140a42fe76a2dbcbc151;hpb=fee7c68b86e9fde5f67765fe221c384ac649b5e8;p=p5sagit%2FClass-Accessor-Grouped.git

diff --git a/t/accessors.t b/t/accessors.t
index e10f102..4113071 100644
--- a/t/accessors.t
+++ b/t/accessors.t
@@ -1,8 +1,8 @@
-use Test::More tests => 62;
+use Test::More tests => 136;
 use strict;
 use warnings;
 use lib 't/lib';
-use Sub::Identify qw/sub_name sub_fullname/;
+use B qw/svref_2object/;
 
 # we test the pure-perl versions only, but allow overrides
 # from the accessor_xs test-umbrella
@@ -10,91 +10,86 @@ use Sub::Identify qw/sub_name sub_fullname/;
 # things
 my $use_xs;
 BEGIN {
-    $Class::Accessor::Grouped::USE_XS = 0
-        unless defined $Class::Accessor::Grouped::USE_XS;
-    $ENV{CAG_USE_XS} = 1;
-    $use_xs = $Class::Accessor::Grouped::USE_XS;
+  $Class::Accessor::Grouped::USE_XS = 0
+    unless defined $Class::Accessor::Grouped::USE_XS;
+  $ENV{CAG_USE_XS} = 1;
+  $use_xs = $Class::Accessor::Grouped::USE_XS;
 };
 
-use AccessorGroups;
-
-my $class = AccessorGroups->new;
-
-{
-    my $warned = 0;
-
-    local $SIG{__WARN__} = sub {
-        if  (shift =~ /DESTROY/i) {
-            $warned++;
-        };
-    };
-
-    $class->mk_group_accessors('warnings', 'DESTROY');
-
-    ok($warned);
-
-    # restore non-accessorized DESTROY
-    no warnings;
-    *AccessorGroups::DESTROY = sub {};
-};
-
-{
-  my $class_name = ref $class;
-  my $name = 'multiple1';
-  my $alias = "_${name}_accessor";
-  my $accessor = $class->can($name);
-  my $alias_accessor = $class->can($alias);
-  isnt(sub_name($accessor), '__ANON__', 'accessor is named');
-  isnt(sub_name($alias_accessor), '__ANON__', 'alias is named');
-  is(sub_fullname($accessor), join('::',$class_name,$name), 'accessor FQ name');
-  is(sub_fullname($alias_accessor), join('::',$class_name,$alias), 'alias FQ name');
-}
+use AccessorGroupsSubclass;
+my $obj = AccessorGroupsSubclass->new;
 
 my $test_accessors = {
-    singlefield => {
-        is_xs => $use_xs,
-        has_extra => 1,
-    },
-    multiple1 => {
-    },
-    multiple2 => {
-    },
-    lr1name => {
-        custom_field => 'lr1;field',
-    },
-    lr2name => {
-        custom_field => "lr2'field",
-    },
+  singlefield => {
+    is_xs => $use_xs,
+    has_extra => 1,
+  },
+  runtime_around => {
+    # even though this accessor is simple it will *not* be XSified
+    # due to the runtime 'around'
+    is_xs => 0,
+    has_extra => 1,
+  },
+  multiple1 => {
+  },
+  multiple2 => {
+  },
+  lr1name => {
+    custom_field => 'lr1;field',
+  },
+  lr2name => {
+    custom_field => "lr2'field",
+  },
+  fieldname_torture => {
+    custom_field => join ('', map { chr($_) } (0..255) ),
+    is_xs => $use_xs,
+  },
 };
 
-
 for my $name (sort keys %$test_accessors) {
-    my $alias = "_${name}_accessor";
-    my $field = $test_accessors->{$name}{custom_field} || $name;
-    my $extra = $test_accessors->{$name}{has_extra};
-
-    can_ok($class, $name, $alias);
-    ok(!$class->can($field))
-      if $field ne $name;
-
-    is($class->$name, undef);
-    is($class->$alias, undef);
-
-    # get/set via name
-    is($class->$name('a'), 'a');
-    is($class->$name, 'a');
-    is($class->{$field}, $extra ? 'a Extra tackled on' : 'a');
-
-    # alias gets same as name
-    is($class->$alias, 'a');
-
-    # get/set via alias
-    is($class->$alias('b'), 'b');
-    is($class->$alias, 'b');
-    is($class->{$field}, $extra ? 'b Extra tackled on' : 'b');
-
-    # alias gets same as name
-    is($class->$name, 'b');
+  my $alias = "_${name}_accessor";
+  my $field = $test_accessors->{$name}{custom_field} || $name;
+  my $extra = $test_accessors->{$name}{has_extra};
+
+  can_ok($obj, $name, $alias);
+  ok(!$obj->can($field))
+    if $field ne $name;
+
+  for my $meth ($name, $alias) {
+    my $cv = svref_2object( $obj->can($meth) );
+    is($cv->GV->NAME, $meth, "$meth accessor is named");
+    is($cv->GV->STASH->NAME, 'AccessorGroups', "$meth class correct");
+  }
+
+  is($obj->$name, undef);
+  is($obj->$alias, undef);
+
+  # get/set via name
+  is($obj->$name('a'), 'a');
+  is($obj->$name, 'a');
+  is($obj->{$field}, $extra ? 'a Extra tackled on' : 'a');
+
+  # alias gets same as name
+  is($obj->$alias, 'a');
+
+  # get/set via alias
+  is($obj->$alias('b'), 'b');
+  is($obj->$alias, 'b');
+  is($obj->{$field}, $extra ? 'b Extra tackled on' : 'b');
+
+  # alias gets same as name
+  is($obj->$name, 'b');
+
+  for my $meth ($name, $alias) {
+    my $cv = svref_2object( $obj->can($meth) );
+    is($cv->GV->NAME, $meth, "$meth accessor is named after operations");
+    is(
+      $cv->GV->STASH->NAME,
+      # XS lazyinstalls install into each caller, not into the original parent
+      $test_accessors->{$name}{is_xs} ? 'AccessorGroupsSubclass' :'AccessorGroups',
+      "$meth class correct after operations",
+    );
+  }
 };
 
 # important