X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F96multi_create.t;h=9cd754f2a808359d2c72bf43173a95e8466ddbf1;hb=40f751811e773082d1cc654f15f06ef65749a9e9;hp=d54deba01ce0634516d362b84dbd85a76ecebfc3;hpb=43483f3027581fc07e4def9af611d88db4f73e1f;p=dbsrgits%2FDBIx-Class.git diff --git a/t/96multi_create.t b/t/96multi_create.t index d54deba..9cd754f 100644 --- a/t/96multi_create.t +++ b/t/96multi_create.t @@ -6,12 +6,11 @@ use Test::Exception; use lib qw(t/lib); use DBICTest; -plan tests => 97; +plan tests => 93; my $schema = DBICTest->init_schema(); -# simple create + parent (the stuff $rs belongs_to) -eval { +lives_ok ( sub { my $cd = $schema->resultset('CD')->create({ artist => { name => 'Fred Bloggs' @@ -23,12 +22,9 @@ eval { isa_ok($cd, 'DBICTest::CD', 'Created CD object'); isa_ok($cd->artist, 'DBICTest::Artist', 'Created related Artist'); is($cd->artist->name, 'Fred Bloggs', 'Artist created correctly'); -}; -diag $@ if $@; +}, 'simple create + parent (the stuff $rs belongs_to) ok'); -# same as above but the child and parent have no values, -# except for an explicit parent pk -eval { +lives_ok ( sub { my $bm_rs = $schema->resultset('Bookmark'); my $bookmark = $bm_rs->create({ link => { @@ -46,11 +42,9 @@ eval { 1, 'Bookmark and link made it to the DB', ); -}; -diag $@ if $@; +}, 'simple create where the child and parent have no values, except for an explicit parent pk ok'); -# create over > 1 levels of has_many create (A => { has_many => { B => has_many => C } } ) -eval { +lives_ok ( sub { my $artist = $schema->resultset('Artist')->first; my $cd = $artist->create_related (cds => { title => 'Music to code by', @@ -65,8 +59,7 @@ eval { is($cd->tags->count, 1, 'One tag created for CD'); is($cd->tags->first->tag, 'rock', 'Tag created correctly'); -}; -diag $@ if $@; +}, 'create over > 1 levels of has_many create (A => { has_many => { B => has_many => C } } )'); throws_ok ( sub { @@ -83,8 +76,7 @@ throws_ok ( 'create via update of multi relationships throws an exception' ); -# Create m2m while originating in the linker table -eval { +lives_ok ( sub { my $artist = $schema->resultset('Artist')->first; my $c2p = $schema->resultset('CD_to_Producer')->create ({ cd => { @@ -92,9 +84,9 @@ eval { title => 'Bad investment', year => 2008, tracks => [ - { position => 1, title => 'Just buy' }, - { position => 2, title => 'Why did we do it' }, - { position => 3, title => 'Burn baby burn' }, + { title => 'Just buy' }, + { title => 'Why did we do it' }, + { title => 'Burn baby burn' }, ], }, producer => { @@ -109,21 +101,17 @@ eval { my $cd = $prod->cds->first; is ($cd->title, 'Bad investment', 'CD created correctly'); is ($cd->tracks->count, 3, 'CD has 3 tracks'); +}, 'Create m2m while originating in the linker table'); -}; -diag $@ if $@; - -# create over > 1 levels of might_have with multiple has_many and multiple m2m -# but starting at a has_many level -# (A => { might_have => { B => has_many => C <= has_many D} } ) or -# CD -> has_many -> Tracks -> might have -> Single -> has_many -> Tracks -# \ -# \-> has_many \ -# --> CD2Producer -# /-> has_many / -# / -# Producer -eval { + +#CD -> has_many -> Tracks -> might have -> Single -> has_many -> Tracks +# \ +# \-> has_many \ +# --> CD2Producer +# /-> has_many / +# / +# Producer +lives_ok ( sub { my $artist = $schema->resultset('Artist')->first; my $cd = $schema->resultset('CD')->create ({ artist => $artist, @@ -131,19 +119,17 @@ eval { year => 2008, tracks => [ { - position => 1, # some day me might test this with Ordered title => 'Off by one again', }, { - position => 2, title => 'The dereferencer', cd_single => { artist => $artist, year => 2008, title => 'Was that a null (Single)', tracks => [ - { title => 'The dereferencer', position => 1 }, - { title => 'The dereferencer II', position => 2 }, + { title => 'The dereferencer' }, + { title => 'The dereferencer II' }, ], cd_to_producer => [ { @@ -183,31 +169,28 @@ eval { ['Don Knuth', 'K&R'], 'Producers named correctly', ); -}; -diag $@ if $@; +}, 'Create over > 1 levels of might_have with multiple has_many and multiple m2m but starting at a has_many level'); -# Same as above but starting at the might_have directly -# Track -> might have -> Single -> has_many -> Tracks +#Track -> might have -> Single -> has_many -> Tracks # \ # \-> has_many \ # --> CD2Producer # /-> has_many / # / # Producer -eval { +lives_ok ( sub { my $cd = $schema->resultset('CD')->first; my $track = $schema->resultset('Track')->create ({ cd => $cd, - position => 77, # some day me might test this with Ordered title => 'Multicreate rocks', cd_single => { artist => $cd->artist, year => 2008, title => 'Disemboweling MultiCreate', tracks => [ - { title => 'Why does mst write this way', position => 1 }, - { title => 'Chainsaw celebration', position => 2 }, - { title => 'Purl cleans up', position => 3 }, + { title => 'Why does mst write this way' }, + { title => 'Chainsaw celebration' }, + { title => 'Purl cleans up' }, ], cd_to_producer => [ { @@ -245,11 +228,9 @@ eval { ['castaway', 'mst', 'theorbtwo'], 'Producers named correctly', ); -}; -diag $@ if $@; +}, 'Create over > 1 levels of might_have with multiple has_many and multiple m2m but starting at the might_have directly'); -# test might_have again but with a PK == FK in the middle (obviously not specified) -eval { +lives_ok ( sub { my $artist = $schema->resultset('Artist')->first; my $cd = $schema->resultset('CD')->create ({ artist => $artist, @@ -277,7 +258,6 @@ eval { 'Images named correctly in objects', ); - my $artwork = $schema->resultset('Artwork')->search ( { 'cd.title' => 'Music to code by at twilight' }, { join => 'cd' }, @@ -290,15 +270,12 @@ eval { [ 'recursive descent', 'tail packing' ], 'Images named correctly after search', ); -}; -diag $@ if $@; +}, 'Test might_have again but with a PK == FK in the middle (obviously not specified)'); -# test might_have again but with just a PK and FK (neither specified) in the mid-table -eval { +lives_ok ( sub { my $cd = $schema->resultset('CD')->first; my $track = $schema->resultset ('Track')->create ({ cd => $cd, - position => 66, title => 'Black', lyrics => { lyric_versions => [ @@ -336,11 +313,9 @@ eval { [ 'The color black', 'The colour black' ], 'Lyrics text via search matches', ); -}; -diag $@ if $@; +}, 'Test might_have again but with just a PK and FK (neither specified) in the mid-table'); -# nested find_or_create -eval { +lives_ok ( sub { my $newartist2 = $schema->resultset('Artist')->find_or_create({ name => 'Fred 3', cds => [ @@ -351,11 +326,9 @@ eval { ], }); is($newartist2->name, 'Fred 3', 'Created new artist with cds via find_or_create'); -}; -diag $@ if $@; +}, 'Nested find_or_create'); -# multiple same level has_many create -eval { +lives_ok ( sub { my $artist2 = $schema->resultset('Artist')->create({ name => 'Fred 4', cds => [ @@ -373,11 +346,9 @@ eval { }); is($artist2->in_storage, 1, 'artist with duplicate rels inserted okay'); -}; -diag $@ if $@; +}, 'Multiple same level has_many create'); -# first create_related pass -eval { +lives_ok ( sub { my $artist = $schema->resultset('Artist')->first; my $cd_result = $artist->create_related('cds', { @@ -385,33 +356,26 @@ eval { title => 'TestOneCD1', year => 2007, tracks => [ - - { position=>111, - title => 'TrackOne', - }, - { position=>112, - title => 'TrackTwo', - } + { title => 'TrackOne' }, + { title => 'TrackTwo' }, ], }); - ok( $cd_result && ref $cd_result eq 'DBICTest::CD', "Got Good CD Class"); + isa_ok( $cd_result, 'DBICTest::CD', "Got Good CD Class"); ok( $cd_result->title eq "TestOneCD1", "Got Expected Title"); my $tracks = $cd_result->tracks; - ok( ref $tracks eq "DBIx::Class::ResultSet", "Got Expected Tracks ResultSet"); + isa_ok( $tracks, 'DBIx::Class::ResultSet', 'Got Expected Tracks ResultSet'); foreach my $track ($tracks->all) { - ok( $track && ref $track eq 'DBICTest::Track', 'Got Expected Track Class'); + isa_ok( $track, 'DBICTest::Track', 'Got Expected Track Class'); } -}; -diag $@ if $@; +}, 'First create_related pass'); -# second create_related with same arguments -eval { +lives_ok ( sub { my $artist = $schema->resultset('Artist')->first; my $cd_result = $artist->create_related('cds', { @@ -419,46 +383,37 @@ eval { title => 'TestOneCD2', year => 2007, tracks => [ - - { position=>111, - title => 'TrackOne', - }, - { position=>112, - title => 'TrackTwo', - } + { title => 'TrackOne' }, + { title => 'TrackTwo' }, ], liner_notes => { notes => 'I can haz liner notes?' }, }); - ok( $cd_result && ref $cd_result eq 'DBICTest::CD', "Got Good CD Class"); + isa_ok( $cd_result, 'DBICTest::CD', "Got Good CD Class"); ok( $cd_result->title eq "TestOneCD2", "Got Expected Title"); ok( $cd_result->notes eq 'I can haz liner notes?', 'Liner notes'); my $tracks = $cd_result->tracks; - ok( ref $tracks eq "DBIx::Class::ResultSet", "Got Expected Tracks ResultSet"); + isa_ok( $tracks, 'DBIx::Class::ResultSet', "Got Expected Tracks ResultSet"); foreach my $track ($tracks->all) { - ok( $track && ref $track eq 'DBICTest::Track', 'Got Expected Track Class'); + isa_ok( $track, 'DBICTest::Track', 'Got Expected Track Class'); } -}; -diag $@ if $@; +}, 'second create_related with same arguments'); -# create of parents of a record linker table -eval { +lives_ok ( sub { my $cdp = $schema->resultset('CD_to_Producer')->create({ cd => { artist => 1, title => 'foo', year => 2000 }, producer => { name => 'jorge' } }); ok($cdp, 'join table record created ok'); -}; -diag $@ if $@; +}, 'create of parents of a record linker table'); -#SPECIAL_CASE -eval { +lives_ok ( sub { my $kurt_cobain = { name => 'Kurt Cobain' }; my $in_utero = $schema->resultset('CD')->new({ @@ -475,29 +430,11 @@ eval { is($a->name, 'Kurt Cobain', 'Artist insertion ok'); is($a->cds && $a->cds->first && $a->cds->first->title, 'In Utero', 'CD insertion ok'); -}; -diag $@ if $@; - -#SPECIAL_CASE2 -eval { - my $pink_floyd = { name => 'Pink Floyd' }; - - my $the_wall = { title => 'The Wall', year => 1979 }; - - $pink_floyd->{cds} = [ $the_wall ]; - - - $schema->resultset('Artist')->populate([ $pink_floyd ]); # %) - $a = $schema->resultset('Artist')->find({name => 'Pink Floyd'}); - - is($a->name, 'Pink Floyd', 'Artist insertion ok'); - is($a->cds && $a->cds->first->title, 'The Wall', 'CD insertion ok'); -}; -diag $@ if $@; +}, 'populate'); ## Create foreign key col obj including PK ## See test 20 in 66relationships.t -eval { +lives_ok ( sub { my $new_cd_hashref = { cdid => 27, title => 'Boogie Woogie', @@ -511,30 +448,25 @@ eval { my $new_cd = $schema->resultset("CD")->create($new_cd_hashref); is($new_cd->artist->id, 17, 'new id retained okay'); -}; -diag $@ if $@; +}, 'Create foreign key col obj including PK'); -eval { +lives_ok ( sub { $schema->resultset("CD")->create({ cdid => 28, title => 'Boogie Wiggle', year => '2007', artist => { artistid => 18, name => 'larry' } }); -}; -is($@, '', 'new cd created without clash on related artist'); +}, 'new cd created without clash on related artist'); -# Make sure exceptions from errors in created rels propogate -eval { +throws_ok ( sub { my $t = $schema->resultset("Track")->new({ cd => { artist => undef } }); #$t->cd($t->new_related('cd', { artist => undef } ) ); #$t->{_rel_in_storage} = 0; $t->insert; -}; -like($@, qr/cd.artist may not be NULL/, "Exception propogated properly"); +}, qr/cd.artist may not be NULL/, "Exception propogated properly"); -# Test multi create over many_to_many -eval { +lives_ok ( sub { $schema->resultset('CD')->create ({ artist => { name => 'larry', # should already exist @@ -550,219 +482,6 @@ eval { is ($m2m_cd->count, 1, 'One CD row created via M2M create'); is ($m2m_cd->first->producers->count, 1, 'CD row created with one producer'); is ($m2m_cd->first->producers->first->name, 'Cowboy Neal', 'Correct producer row created'); -}; - -# and some insane multicreate -# (should work, despite the fact that no one will probably use it this way) - -# first count how many rows do we initially have -my $counts; -$counts->{$_} = $schema->resultset($_)->count for qw/Artist CD Genre Producer Tag/; - -# do the crazy create -eval { - $schema->resultset('CD')->create ({ - artist => { - name => 'james', - }, - title => 'Greatest hits 1', - year => '2012', - genre => { - name => '"Greatest" collections', - }, - tags => [ - { tag => 'A' }, - { tag => 'B' }, - ], - cd_to_producer => [ - { - producer => { - name => 'bob', - producer_to_cd => [ - { - cd => { - artist => { - name => 'lars', - cds => [ - { - title => 'Greatest hits 2', - year => 2012, - genre => { - name => '"Greatest" collections', - }, - tags => [ - { tag => 'A' }, - { tag => 'B' }, - ], - # This cd is created via artist so it doesn't know about producers - cd_to_producer => [ - # if we specify 'bob' here things bomb - # as the producer attached to Greatest Hits 1 is - # already created, but not yet inserted. - # Maybe this can be fixed, but things are hairy - # enough already. - # - #{ producer => { name => 'bob' } }, - { producer => { name => 'paul' } }, - { producer => { - name => 'flemming', - producer_to_cd => [ - { cd => { - artist => { - name => 'kirk', - cds => [ - { - title => 'Greatest hits 3', - year => 2012, - genre => { - name => '"Greatest" collections', - }, - tags => [ - { tag => 'A' }, - { tag => 'B' }, - ], - }, - { - title => 'Greatest hits 4', - year => 2012, - genre => { - name => '"Greatest" collections2', - }, - tags => [ - { tag => 'A' }, - { tag => 'B' }, - ], - }, - ], - }, - title => 'Greatest hits 5', - year => 2013, - genre => { - name => '"Greatest" collections2', - }, - }}, - ], - }}, - ], - }, - ], - }, - title => 'Greatest hits 6', - year => 2012, - genre => { - name => '"Greatest" collections', - }, - tags => [ - { tag => 'A' }, - { tag => 'B' }, - ], - }, - }, - { - cd => { - artist => { - name => 'lars', # should already exist - # even though the artist 'name' is not uniquely constrained - # find_or_create will arguably DWIM - }, - title => 'Greatest hits 7', - year => 2013, - }, - }, - ], - }, - }, - ], - }); - - is ($schema->resultset ('Artist')->count, $counts->{Artist} + 3, '3 new artists created'); - is ($schema->resultset ('Genre')->count, $counts->{Genre} + 2, '2 additional genres created'); - is ($schema->resultset ('Producer')->count, $counts->{Producer} + 3, '3 new producer'); - is ($schema->resultset ('CD')->count, $counts->{CD} + 7, '7 new CDs'); - is ($schema->resultset ('Tag')->count, $counts->{Tag} + 10, '10 new Tags'); - - my $cd_rs = $schema->resultset ('CD') - ->search ({ title => { -like => 'Greatest hits %' }}, { order_by => 'title'} ); - is ($cd_rs->count, 7, '7 greatest hits created'); - - my $cds_2012 = $cd_rs->search ({ year => 2012}); - is ($cds_2012->count, 5, '5 CDs created in 2012'); - - is ( - $cds_2012->search( - { 'tags.tag' => { -in => [qw/A B/] } }, - { join => 'tags', group_by => 'me.cdid' } - ), - 5, - 'All 10 tags were pairwise distributed between 5 year-2012 CDs' - ); - - my $paul_prod = $cd_rs->search ( - { 'producer.name' => 'paul'}, - { join => { cd_to_producer => 'producer' } } - ); - is ($paul_prod->count, 1, 'Paul had 1 production'); - my $pauls_cd = $paul_prod->single; - is ($pauls_cd->cd_to_producer->count, 2, 'Paul had one co-producer'); - is ( - $pauls_cd->search_related ('cd_to_producer', - { 'producer.name' => 'flemming'}, - { join => 'producer' } - )->count, - 1, - 'The second producer is flemming', - ); - - my $kirk_cds = $cd_rs->search ({ 'artist.name' => 'kirk' }, { join => 'artist' }); - is ($kirk_cds, 3, 'Kirk had 3 CDs'); - is ( - $kirk_cds->search ( - { 'cd_to_producer.cd' => { '!=', undef } }, - { join => 'cd_to_producer' }, - ), - 1, - 'Kirk had a producer only on one cd', - ); - - my $lars_cds = $cd_rs->search ({ 'artist.name' => 'lars' }, { join => 'artist' }); - is ($lars_cds->count, 3, 'Lars had 3 CDs'); - is ( - $lars_cds->search ( - { 'cd_to_producer.cd' => undef }, - { join => 'cd_to_producer' }, - ), - 0, - 'Lars always had a producer', - ); - is ( - $lars_cds->search_related ('cd_to_producer', - { 'producer.name' => 'flemming'}, - { join => 'producer' } - )->count, - 1, - 'Lars produced 1 CD with flemming', - ); - is ( - $lars_cds->search_related ('cd_to_producer', - { 'producer.name' => 'bob'}, - { join => 'producer' } - )->count, - 2, - 'Lars produced 2 CDs with bob', - ); - - my $bob_prod = $cd_rs->search ( - { 'producer.name' => 'bob'}, - { join => { cd_to_producer => 'producer' } } - ); - is ($bob_prod->count, 3, 'Bob produced a total of 3 CDs'); - - is ( - $bob_prod->search ({ 'artist.name' => 'james' }, { join => 'artist' })->count, - 1, - "Bob produced james' only CD", - ); -}; -diag $@ if $@; +}, 'Test multi create over many_to_many'); 1;