X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F90join_torture.t;h=cd7d2ef70e68158e2bb5185e239f2730c998ab85;hb=faeb2407c49717d38874b21749659ac2c632bad7;hp=7c66799e507e5c04d33bc6b259f21d7071145fdc;hpb=b25e9fa0e642e100b461592dbf52c668377a5a70;p=dbsrgits%2FDBIx-Class.git diff --git a/t/90join_torture.t b/t/90join_torture.t index 7c66799..cd7d2ef 100644 --- a/t/90join_torture.t +++ b/t/90join_torture.t @@ -1,13 +1,36 @@ use strict; -use warnings; +use warnings; use Test::More; +use Test::Exception; use lib qw(t/lib); use DBICTest; -use Data::Dumper; +use DBIC::SqlMakerTest; my $schema = DBICTest->init_schema(); -plan tests => 19; + { + my $rs = $schema->resultset( 'CD' )->search( + { + 'producer.name' => 'blah', + 'producer_2.name' => 'foo', + }, + { + 'join' => [ + { cd_to_producer => 'producer' }, + { cd_to_producer => 'producer' }, + ], + 'prefetch' => [ + 'artist', + { cd_to_producer => 'producer' }, + ], + } + ); + + lives_ok { + my @rows = $rs->all(); + }; + } + my @rs1a_results = $schema->resultset("Artist")->search_related('cds', {title => 'Forkful of bees'}, {order_by => 'title'}); is($rs1a_results[0]->title, 'Forkful of bees', "bare field conditions okay after search related"); @@ -16,15 +39,15 @@ my @artists = $rs1->all; cmp_ok(@artists, '==', 2, "Two artists returned"); my $rs2 = $rs1->search({ artistid => '1' }, { join => {'cds' => {'cd_to_producer' => 'producer'} } }); - my @artists2 = $rs2->search({ 'producer.name' => 'Matt S Trout' }); my @cds = $artists2[0]->cds; cmp_ok(scalar @cds, '==', 1, "condition based on inherited join okay"); -#this is wrong, should accept me.title really my $rs3 = $rs2->search_related('cds'); -cmp_ok(scalar($rs3->all), '==', 27, "All cds for artist returned"); -cmp_ok($rs3->count, '==', 27, "All cds for artist returned via count"); + +cmp_ok(scalar($rs3->all), '==', 15, "All cds for artist returned"); + +cmp_ok($rs3->count, '==', 15, "All cds for artist returned via count"); my $rs4 = $schema->resultset("CD")->search({ 'artist.artistid' => '1' }, { join => ['tracks', 'artist'], prefetch => 'artist' }); my @rs4_results = $rs4->all; @@ -82,7 +105,7 @@ my $merge_rs_2 = $schema->resultset("Artist")->search({ }, { join => 'cds' })->s is(scalar(@{$merge_rs_2->{attrs}->{join}}), 1, 'only one join kept when inherited'); my $merge_rs_2_cd = $merge_rs_2->next; -eval { +lives_ok (sub { my @rs_with_prefetch = $schema->resultset('TreeLike') ->search( @@ -91,8 +114,44 @@ eval { prefetch => [ 'parent', { 'children' => 'parent' } ], }); -}; +}, 'pathological prefetch ok'); -ok(!$@, "pathological prefetch ok"); +my $rs = $schema->resultset("Artist")->search({}, { join => 'twokeys' }); +my $second_search_rs = $rs->search({ 'cds_2.cdid' => '2' }, { join => +['cds', 'cds'] }); +is(scalar(@{$second_search_rs->{attrs}->{join}}), 3, 'both joins kept'); +ok($second_search_rs->next, 'query on double joined rel runs okay'); -1; +# test joinmap pruner +lives_ok ( sub { + my $rs = $schema->resultset('Artwork')->search ( + { + }, + { + distinct => 1, + join => [ + { artwork_to_artist => 'artist' }, + { cd => 'artist' }, + ], + }, + ); + + is_same_sql_bind ( + $rs->count_rs->as_query, + '( + SELECT COUNT( * ) + FROM ( + SELECT me.cd_id + FROM cd_artwork me + JOIN cd cd ON cd.cdid = me.cd_id + JOIN artist artist_2 ON artist_2.artistid = cd.artist + GROUP BY me.cd_id + ) count_subq + )', + [], + ); + + ok (defined $rs->count); +}); + +done_testing;