X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F88result_set_column.t;h=c26f2073f9b213d1be99adab5483fab339433282;hb=bfcecabc3c48500d28a9a648c8e4c8a649a63f66;hp=52221f9a4ac49ad11a51421e9d673067e7cdb04f;hpb=cda5e0825360a15f97520dae86864b68ac90d5f5;p=dbsrgits%2FDBIx-Class.git diff --git a/t/88result_set_column.t b/t/88result_set_column.t index 52221f9..c26f207 100644 --- a/t/88result_set_column.t +++ b/t/88result_set_column.t @@ -1,50 +1,131 @@ use strict; -use warnings; +use warnings; use Test::More; +use Test::Warn; +use Test::Exception; use lib qw(t/lib); use DBICTest; +use DBIC::SqlMakerTest; my $schema = DBICTest->init_schema(); -plan tests => 14; +my $rs = $schema->resultset("CD"); -my $cd; -my $rs = $cd = $schema->resultset("CD")->search({}); +cmp_ok ( + $rs->count, + '>', + $rs->search ({}, {columns => ['year'], distinct => 1})->count, + 'At least one year is the same in rs' +); my $rs_title = $rs->get_column('title'); my $rs_year = $rs->get_column('year'); my $max_year = $rs->get_column(\'MAX (year)'); -is($rs_title->next, 'Spoonful of bees', "next okay"); +my @all_titles = $rs_title->all; +cmp_ok(scalar @all_titles, '==', 5, "five titles returned"); + +my @nexted_titles; +while (my $r = $rs_title->next) { + push @nexted_titles, $r; +} + +is_deeply (\@all_titles, \@nexted_titles, 'next works'); + is_deeply( [ sort $rs_year->func('DISTINCT') ], [ 1997, 1998, 1999, 2001 ], "wantarray context okay"); ok ($max_year->next == $rs_year->max, q/get_column (\'FUNC') ok/); -my @all = $rs_title->all; -cmp_ok(scalar @all, '==', 5, "five titles returned"); - cmp_ok($rs_year->max, '==', 2001, "max okay for year"); is($rs_title->min, 'Caterwaulin\' Blues', "min okay for title"); cmp_ok($rs_year->sum, '==', 9996, "three artists returned"); +my $rso_year = $rs->search({}, { order_by => 'cdid' })->get_column('year'); +is($rso_year->next, 1999, "reset okay"); + +is($rso_year->first, 1999, "first okay"); + +warnings_exist (sub { + is($rso_year->single, 1999, "single okay"); +}, qr/Query returned more than one row/, 'single warned'); + + +# test distinct propagation +is_deeply ( + [sort $rs->search ({}, { distinct => 1 })->get_column ('year')->all], + [sort $rs_year->func('distinct')], + 'distinct => 1 is passed through properly', +); + +# test +select/+as for single column my $psrs = $schema->resultset('CD')->search({}, { - '+select' => \'COUNT(*)', - '+as' => 'count' + '+select' => \'MAX(year)', + '+as' => 'last_year' + } +); +lives_ok(sub { $psrs->get_column('last_year')->next }, '+select/+as additional column "last_year" present (scalar)'); +dies_ok(sub { $psrs->get_column('noSuchColumn')->next }, '+select/+as nonexistent column throws exception'); + +# test +select/+as for overriding a column +$psrs = $schema->resultset('CD')->search({}, + { + 'select' => \"'The Final Countdown'", + 'as' => 'title' } ); -ok(defined($psrs->get_column('count')), '+select/+as count'); +is($psrs->get_column('title')->next, 'The Final Countdown', '+select/+as overridden column "title"'); + +# test +select/+as for multiple columns $psrs = $schema->resultset('CD')->search({}, { - '+select' => [ \'COUNT(*)', 'title' ], - '+as' => [ 'count', 'addedtitle' ] + '+select' => [ \'LENGTH(title) AS title_length', 'title' ], + '+as' => [ 'tlength', 'addedtitle' ] } ); -ok(defined($psrs->get_column('count')), '+select/+as arrayref count'); -ok(defined($psrs->get_column('addedtitle')), '+select/+as title'); +lives_ok(sub { $psrs->get_column('tlength')->next }, '+select/+as multiple additional columns, "tlength" column present'); +lives_ok(sub { $psrs->get_column('addedtitle')->next }, '+select/+as multiple additional columns, "addedtitle" column present'); + +# test that +select/+as specs do not leak +is_same_sql_bind ( + $psrs->get_column('year')->as_query, + '(SELECT me.year FROM cd me)', + [], + 'Correct SQL for get_column/as' +); +is_same_sql_bind ( + $psrs->get_column('addedtitle')->as_query, + '(SELECT me.title FROM cd me)', + [], + 'Correct SQL for get_column/+as col' +); + +is_same_sql_bind ( + $psrs->get_column('tlength')->as_query, + '(SELECT LENGTH(title) AS title_length FROM cd me)', + [], + 'Correct SQL for get_column/+as func' +); + +# test that order_by over a function forces a subquery +lives_ok ( sub { + is_deeply ( + [ $psrs->search ({}, { order_by => { -desc => 'title_length' } })->get_column ('title')->all ], + [ + "Generic Manufactured Singles", + "Come Be Depressed With Us", + "Caterwaulin' Blues", + "Spoonful of bees", + "Forkful of bees", + ], + 'Subquery count induced by aliased ordering function', + ); +}); + +# test for prefetch not leaking { my $rs = $schema->resultset("CD")->search({}, { prefetch => 'artist' }); my $rsc = $rs->get_column('year'); @@ -58,3 +139,62 @@ is ($schema->resultset('BooksInLibrary')->get_column ('price')->sum, 125, 'Sum o my $owner = $schema->resultset('Owners')->find ({ name => 'Newton' }); ok ($owner->books->count > 1, 'Owner Newton has multiple books'); is ($owner->search_related ('books')->get_column ('price')->sum, 60, 'Correctly calculated price of all owned books'); + + +# make sure joined/prefetched get_column of a PK dtrt +$rs->reset; +my $j_rs = $rs->search ({}, { join => 'tracks' })->get_column ('cdid'); +is_deeply ( + [ sort $j_rs->all ], + [ sort map { my $c = $rs->next; ( ($c->id) x $c->tracks->count ) } (1 .. $rs->count) ], + 'join properly explodes amount of rows from get_column', +); + +$rs->reset; +my $p_rs = $rs->search ({}, { prefetch => 'tracks' })->get_column ('cdid'); +is_deeply ( + [ sort $p_rs->all ], + [ sort $rs->get_column ('cdid')->all ], + 'prefetch properly collapses amount of rows from get_column', +); + +$rs->reset; +my $pob_rs = $rs->search({}, { + select => ['me.title', 'tracks.title'], + prefetch => 'tracks', + order_by => [{-asc => ['position']}], + group_by => ['me.title', 'tracks.title'], +}); +is_same_sql_bind ( + $pob_rs->get_column("me.title")->as_query, + '(SELECT me.title FROM (SELECT me.title, tracks.title FROM cd me LEFT JOIN track tracks ON tracks.cd = me.cdid GROUP BY me.title, tracks.title ORDER BY position ASC) me)', + [], + 'Correct SQL for prefetch/order_by/group_by' +); + +# test aggregate on a function +{ + my $tr_rs = $schema->resultset("Track"); + $tr_rs->create({ cd => 2, title => 'dealbreaker' }); + + is( + $tr_rs->get_column('cd')->max, + 5, + "Correct: Max cd in Track is 5" + ); + + my $track_counts_per_cd_via_group_by = $tr_rs->search({}, { + columns => [ 'cd', { cnt => { count => 'trackid', -as => 'cnt' } } ], + group_by => 'cd', + })->get_column('cnt'); + + is ($track_counts_per_cd_via_group_by->max, 4, 'Correct max tracks per cd'); + is ($track_counts_per_cd_via_group_by->min, 3, 'Correct min tracks per cd'); + is ( + sprintf('%0.1f', $track_counts_per_cd_via_group_by->func('avg') ), + '3.2', + 'Correct avg tracks per cd' + ); +} + +done_testing;