X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F88result_set_column.t;h=b1c1e96d3cbad115c606ea5ff0fcc321299dc4da;hb=a58529c7e6e863c4e9f5e01944839ab9fd31e465;hp=c26f2073f9b213d1be99adab5483fab339433282;hpb=449760452303b9084eb3f8cc7bc12dc917eae748;p=dbsrgits%2FDBIx-Class.git

diff --git a/t/88result_set_column.t b/t/88result_set_column.t
index c26f207..b1c1e96 100644
--- a/t/88result_set_column.t
+++ b/t/88result_set_column.t
@@ -58,6 +58,51 @@ is_deeply (
   'distinct => 1 is passed through properly',
 );
 
+# test illogical distinct
+my $dist_rs = $rs->search ({}, {
+  columns => ['year'],
+  distinct => 1,
+  order_by => { -desc => [qw( cdid year )] },
+});
+
+is_same_sql_bind(
+  $dist_rs->as_query,
+  '(
+    SELECT me.year
+      FROM cd me
+    GROUP BY me.year
+    ORDER BY MAX(cdid) DESC, year DESC
+  )',
+  [],
+  'Correct SQL on external-ordered distinct',
+);
+
+is_same_sql_bind(
+  $dist_rs->count_rs->as_query,
+  '(
+    SELECT COUNT( * )
+      FROM (
+        SELECT me.year
+          FROM cd me
+        GROUP BY me.year
+      ) me
+  )',
+  [],
+  'Correct SQL on count of external-orderdd distinct',
+);
+
+is (
+  $dist_rs->count_rs->next,
+  4,
+  'Correct rs-count',
+);
+
+is (
+  $dist_rs->count,
+  4,
+  'Correct direct count',
+);
+
 # test +select/+as for single column
 my $psrs = $schema->resultset('CD')->search({},
     {
@@ -172,7 +217,7 @@ is_same_sql_bind (
   'Correct SQL for prefetch/order_by/group_by'
 );
 
-# test aggregate on a function
+# test aggregate on a function (create an extra track on one cd)
 {
   my $tr_rs = $schema->resultset("Track");
   $tr_rs->create({ cd => 2, title => 'dealbreaker' });
@@ -197,4 +242,71 @@ is_same_sql_bind (
   );
 }
 
+# test exotic scenarious (create a track-less cd)
+# "How many CDs (not tracks) have been released per year where a given CD has at least one track and the artist isn't evancarroll?"
+{
+
+  $schema->resultset('CD')->create({ artist => 1, title => 'dealbroker no tracks', year => 2001 });
+
+  my $rs = $schema->resultset ('CD')->search (
+    { 'artist.name' => { '!=', 'evancarrol' }, 'tracks.trackid' => { '!=', undef } },
+    {
+      order_by => 'me.year',
+      join => [qw(artist tracks)],
+      columns => [ 'year', { cnt => { count => 'me.cdid' }} ],
+    },
+  );
+
+  my $rstypes = {
+    'explicitly grouped' => $rs->search_rs({}, { group_by => 'year' }),
+    'implicitly grouped' => $rs->search_rs({}, { distinct => 1 }),
+  };
+
+  for my $type (keys %$rstypes) {
+    is ($rstypes->{$type}->count, 4, "correct cd count with $type column");
+
+    is_deeply (
+      [ $rstypes->{$type}->get_column ('year')->all ],
+      [qw(1997 1998 1999 2001)],
+      "Getting $type column works",
+    );
+  }
+
+  # Why do we test this - we want to make sure that the selector *will* actually make
+  # it to the group_by as per the distinct => 1 contract. Before 0.08251 this situation
+  # would silently drop the group_by entirely, likely ending up with nonsensival results
+  # With the current behavior the user will at least get a nice fat exception from the
+  # RDBMS (or maybe the RDBMS will even decide to handle the situation sensibly...)
+  warnings_exist { is_same_sql_bind(
+    $rstypes->{'implicitly grouped'}->get_column('cnt')->as_query,
+    '(
+      SELECT COUNT( me.cdid )
+        FROM cd me
+        JOIN artist artist
+          ON artist.artistid = me.artist
+        LEFT JOIN track tracks
+          ON tracks.cd = me.cdid
+      WHERE artist.name != ? AND tracks.trackid IS NOT NULL
+      GROUP BY COUNT( me.cdid )
+      ORDER BY MIN(me.year)
+    )',
+    [ [ { dbic_colname => 'artist.name', sqlt_datatype => 'varchar', sqlt_size => 100 }
+        => 'evancarrol'
+    ] ],
+    'Expected (though nonsensical) SQL generated on rscol-with-distinct-over-function',
+  ) } qr/
+    \QUse of distinct => 1 while selecting anything other than a column \E
+    \Qdeclared on the primary ResultSource is deprecated\E
+  /x, 'deprecation warning';
+
+  {
+    local $TODO = 'multiplying join leaks through to the count aggregate... this may never actually work';
+    is_deeply (
+      [ $rstypes->{'explicitly grouped'}->get_column ('cnt')->all ],
+      [qw(1 1 1 2)],
+      "Get aggregate over group works",
+    );
+  }
+}
+
 done_testing;