X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F86sqlt.t;h=513a9b6e421f50e6a59fe34b90073b7a4aa8fe11;hb=0da8b7da7a9df7b84e9a3228cd1f5feb1d65bb07;hp=d01a6306ebfc97e7c9dd11ca358d4a3d5be8820d;hpb=ae51573612aec70814b81bfe0c3683b824564368;p=dbsrgits%2FDBIx-Class.git diff --git a/t/86sqlt.t b/t/86sqlt.t index d01a630..513a9b6 100644 --- a/t/86sqlt.t +++ b/t/86sqlt.t @@ -8,18 +8,15 @@ use DBICTest; eval "use SQL::Translator"; plan skip_all => 'SQL::Translator required' if $@; -# do not taunt happy dave ball +my $schema = DBICTest->init_schema; -my $schema = 'DBICTest::Schema'; +plan tests => 160; -plan tests => 31; - -my $translator = SQL::Translator->new( - parser_args => { - 'DBIx::Schema' => $schema, - }, - producer_args => { - }, +my $translator = SQL::Translator->new( + parser_args => { + 'DBIx::Schema' => $schema, + }, + producer_args => {}, ); $translator->parser('SQL::Translator::Parser::DBIx::Class'); @@ -27,200 +24,428 @@ $translator->producer('SQLite'); my $output = $translator->translate(); -my @fk_constraints = - ( - {'display' => 'twokeys->cd', - 'selftable' => 'twokeys', 'foreigntable' => 'cd', - 'selfcols' => ['cd'], 'foreigncols' => ['cdid'], - 'needed' => 1, on_delete => '', on_update => ''}, - {'display' => 'twokeys->artist', - 'selftable' => 'twokeys', 'foreigntable' => 'artist', - 'selfcols' => ['artist'], 'foreigncols' => ['artistid'], - 'needed' => 1, on_delete => 'CASCADE', on_update => 'CASCADE'}, - {'display' => 'cd_to_producer->cd', - 'selftable' => 'cd_to_producer', 'foreigntable' => 'cd', - 'selfcols' => ['cd'], 'foreigncols' => ['cdid'], - 'needed' => 1, on_delete => 'CASCADE', on_update => 'CASCADE'}, - {'display' => 'cd_to_producer->producer', - 'selftable' => 'cd_to_producer', 'foreigntable' => 'producer', - 'selfcols' => ['producer'], 'foreigncols' => ['producerid'], - 'needed' => 1, on_delete => '', on_update => ''}, - {'display' => 'self_ref_alias -> self_ref for self_ref', - 'selftable' => 'self_ref_alias', 'foreigntable' => 'self_ref', - 'selfcols' => ['self_ref'], 'foreigncols' => ['id'], - 'needed' => 1, on_delete => 'CASCADE', on_update => 'CASCADE'}, - {'display' => 'self_ref_alias -> self_ref for alias', - 'selftable' => 'self_ref_alias', 'foreigntable' => 'self_ref', - 'selfcols' => ['alias'], 'foreigncols' => ['id'], - 'needed' => 1, on_delete => '', on_update => ''}, - {'display' => 'cd -> artist', - 'selftable' => 'cd', 'foreigntable' => 'artist', - 'selfcols' => ['artist'], 'foreigncols' => ['artistid'], - 'needed' => 1, on_delete => 'CASCADE', on_update => 'CASCADE'}, - {'display' => 'artist_undirected_map -> artist for id1', - 'selftable' => 'artist_undirected_map', 'foreigntable' => 'artist', - 'selfcols' => ['id1'], 'foreigncols' => ['artistid'], - 'needed' => 1, on_delete => 'CASCADE', on_update => ''}, - {'display' => 'artist_undirected_map -> artist for id2', - 'selftable' => 'artist_undirected_map', 'foreigntable' => 'artist', - 'selfcols' => ['id2'], 'foreigncols' => ['artistid'], - 'needed' => 1, on_delete => 'CASCADE', on_update => ''}, - {'display' => 'track->cd', - 'selftable' => 'track', 'foreigntable' => 'cd', - 'selfcols' => ['cd'], 'foreigncols' => ['cdid'], - 'needed' => 2, on_delete => 'CASCADE', on_update => 'CASCADE'}, - {'display' => 'treelike -> treelike for parent', - 'selftable' => 'treelike', 'foreigntable' => 'treelike', - 'selfcols' => ['parent'], 'foreigncols' => ['id'], - 'needed' => 1, on_delete => '', on_update => ''}, - - # shouldn't this be generated? - # - #{'display' => 'twokeytreelike -> twokeytreelike for parent1,parent2', - # 'selftable' => 'twokeytreelike', 'foreigntable' => 'twokeytreelike', - # 'selfcols' => ['parent1', 'parent2'], 'foreigncols' => ['id1','id2'], - # 'needed' => 1, on_delete => '', on_update => ''}, - - {'display' => 'tags -> cd', - 'selftable' => 'tags', 'foreigntable' => 'cd', - 'selfcols' => ['cd'], 'foreigncols' => ['cdid'], - 'needed' => 1, on_delete => 'CASCADE', on_update => 'CASCADE'}, - {'display' => 'bookmark -> link', - 'selftable' => 'bookmark', 'foreigntable' => 'link', - 'selfcols' => ['link'], 'foreigncols' => ['id'], - 'needed' => 1, on_delete => '', on_update => ''}, - ); - -my @unique_constraints = ( - {'display' => 'cd artist and title unique', - 'table' => 'cd', 'cols' => ['artist', 'title'], - 'needed' => 1}, - {'display' => 'twokeytreelike name unique', - 'table' => 'twokeytreelike', 'cols' => ['name'], - 'needed' => 1}, -# {'display' => 'employee position and group_id unique', -# 'table' => 'employee', cols => ['position', 'group_id'], -# 'needed' => 1}, + +ok($output, "SQLT produced someoutput") + or diag($translator->error); + +# Note that the constraints listed here are the only ones that are tested -- if +# more exist in the Schema than are listed here and all listed constraints are +# correct, the test will still pass. If you add a class with UNIQUE or FOREIGN +# KEY constraints to DBICTest::Schema, add tests here if you think the existing +# test coverage is not sufficient + +my %fk_constraints = ( + + # TwoKeys + twokeys => [ + { + 'display' => 'twokeys->cd', + 'name' => 'twokeys_fk_cd', 'index_name' => 'cd', + 'selftable' => 'twokeys', 'foreigntable' => 'cd', + 'selfcols' => ['cd'], 'foreigncols' => ['cdid'], + on_delete => '', on_update => '', deferrable => 0, + }, + { + 'display' => 'twokeys->artist', + 'name' => 'twokeys_fk_artist', 'index_name' => 'artist', + 'selftable' => 'twokeys', 'foreigntable' => 'artist', + 'selfcols' => ['artist'], 'foreigncols' => ['artistid'], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + ], + + # FourKeys_to_TwoKeys + fourkeys_to_twokeys => [ + { + 'display' => 'fourkeys_to_twokeys->twokeys', + 'name' => 'fourkeys_to_twokeys_fk_t_cd_t_artist', 'index_name' => 't_cd_t_artist', + 'selftable' => 'fourkeys_to_twokeys', 'foreigntable' => 'twokeys', + 'selfcols' => ['t_artist', 't_cd'], 'foreigncols' => ['artist', 'cd'], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + { + 'display' => 'fourkeys_to_twokeys->fourkeys', 'index_name' => 'f_foo_f_goodbye_f_hello_f_bar', + 'name' => 'fourkeys_to_twokeys_fk_f_foo_f_goodbye_f_hello_f_bar', + 'selftable' => 'fourkeys_to_twokeys', 'foreigntable' => 'fourkeys', + 'selfcols' => [qw(f_foo f_bar f_hello f_goodbye)], + 'foreigncols' => [qw(foo bar hello goodbye)], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + ], + + # CD_to_Producer + cd_to_producer => [ + { + 'display' => 'cd_to_producer->cd', + 'name' => 'cd_to_producer_fk_cd', 'index_name' => 'cd', + 'selftable' => 'cd_to_producer', 'foreigntable' => 'cd', + 'selfcols' => ['cd'], 'foreigncols' => ['cdid'], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + { + 'display' => 'cd_to_producer->producer', + 'name' => 'cd_to_producer_fk_producer', 'index_name' => 'producer', + 'selftable' => 'cd_to_producer', 'foreigntable' => 'producer', + 'selfcols' => ['producer'], 'foreigncols' => ['producerid'], + on_delete => '', on_update => '', deferrable => 1, + }, + ], + + # Self_ref_alias + self_ref_alias => [ + { + 'display' => 'self_ref_alias->self_ref for self_ref', + 'name' => 'self_ref_alias_fk_self_ref', 'index_name' => 'self_ref', + 'selftable' => 'self_ref_alias', 'foreigntable' => 'self_ref', + 'selfcols' => ['self_ref'], 'foreigncols' => ['id'], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + { + 'display' => 'self_ref_alias->self_ref for alias', + 'name' => 'self_ref_alias_fk_alias', 'index_name' => 'alias', + 'selftable' => 'self_ref_alias', 'foreigntable' => 'self_ref', + 'selfcols' => ['alias'], 'foreigncols' => ['id'], + on_delete => '', on_update => '', deferrable => 1, + }, + ], + + # CD + cd => [ + { + 'display' => 'cd->artist', + 'name' => 'cd_fk_artist', 'index_name' => 'artist', + 'selftable' => 'cd', 'foreigntable' => 'artist', + 'selfcols' => ['artist'], 'foreigncols' => ['artistid'], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + ], + + # Artist_undirected_map + artist_undirected_map => [ + { + 'display' => 'artist_undirected_map->artist for id1', + 'name' => 'artist_undirected_map_fk_id1', 'index_name' => 'id1', + 'selftable' => 'artist_undirected_map', 'foreigntable' => 'artist', + 'selfcols' => ['id1'], 'foreigncols' => ['artistid'], + on_delete => 'CASCADE', on_update => '', deferrable => 1, + }, + { + 'display' => 'artist_undirected_map->artist for id2', + 'name' => 'artist_undirected_map_fk_id2', 'index_name' => 'id2', + 'selftable' => 'artist_undirected_map', 'foreigntable' => 'artist', + 'selfcols' => ['id2'], 'foreigncols' => ['artistid'], + on_delete => 'CASCADE', on_update => '', deferrable => 1, + }, + ], + + # Track + track => [ + { + 'display' => 'track->cd', + 'name' => 'track_fk_cd', 'index_name' => 'cd', + 'selftable' => 'track', 'foreigntable' => 'cd', + 'selfcols' => ['cd'], 'foreigncols' => ['cdid'], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + ], + + # TreeLike + treelike => [ + { + 'display' => 'treelike->treelike for parent', + 'name' => 'treelike_fk_parent', 'index_name' => 'parent', + 'selftable' => 'treelike', 'foreigntable' => 'treelike', + 'selfcols' => ['parent'], 'foreigncols' => ['id'], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + ], + + # TwoKeyTreeLike + twokeytreelike => [ + { + 'display' => 'twokeytreelike->twokeytreelike for parent1,parent2', + 'name' => 'twokeytreelike_fk_parent1_parent2', 'index_name' => 'parent1_parent2', + 'selftable' => 'twokeytreelike', 'foreigntable' => 'twokeytreelike', + 'selfcols' => ['parent1', 'parent2'], 'foreigncols' => ['id1','id2'], + on_delete => '', on_update => '', deferrable => 1, + }, + ], + + # Tags + tags => [ + { + 'display' => 'tags->cd', + 'name' => 'tags_fk_cd', 'index_name' => 'cd', + 'selftable' => 'tags', 'foreigntable' => 'cd', + 'selfcols' => ['cd'], 'foreigncols' => ['cdid'], + on_delete => 'CASCADE', on_update => 'CASCADE', deferrable => 1, + }, + ], + + # Bookmark + bookmark => [ + { + 'display' => 'bookmark->link', + 'name' => 'bookmark_fk_link', 'index_name' => 'link', + 'selftable' => 'bookmark', 'foreigntable' => 'link', + 'selfcols' => ['link'], 'foreigncols' => ['id'], + on_delete => '', on_update => '', deferrable => 1, + }, + ], + # ForceForeign + forceforeign => [ + { + 'display' => 'forceforeign->artist', + 'name' => 'forceforeign_fk_artist', 'index_name' => 'artist', + 'selftable' => 'forceforeign', 'foreigntable' => 'artist', + 'selfcols' => ['artist'], 'foreigncols' => ['artist_id'], + on_delete => '', on_update => '', deferrable => 1, + }, + ], + + # LongColumns + long_columns => [ + { + 'display' => 'long_columns->owner', + 'name' => 'long_columns_fk_64_character_column_aaaaaaaaaaaaaaaaaaa_1ca973e2', + 'index_name' => '64_character_column_aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', + 'selftable' => 'long_columns', 'foreigntable' => 'long_columns', + 'selfcols' => ['64_character_column_aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'], + 'foreigncols' => ['lcid'], + on_delete => '', on_update => '', deferrable => 1, + }, + { + 'display' => 'long_columns->owner2', + 'name' => 'long_columns_fk_32_character_column_aaaaaaaaaaaa_32_cha_6060a8f3', + 'index_name' => '32_character_column_aaaaaaaaaaaa_32_character_column_bb_30f7a7fe', + 'selftable' => 'long_columns', 'foreigntable' => 'long_columns', + 'selfcols' => ['32_character_column_bbbbbbbbbbbb', '32_character_column_aaaaaaaaaaaa'], + 'foreigncols' => ['32_character_column_aaaaaaaaaaaa', '32_character_column_bbbbbbbbbbbb'], + on_delete => '', on_update => '', deferrable => 1, + }, + { + 'display' => 'long_columns->owner3', + 'name' => 'long_columns_fk_16_character_col', + 'index_name' => '16_character_col', + 'selftable' => 'long_columns', 'foreigntable' => 'long_columns', + 'selfcols' => ['16_character_col'], 'foreigncols' => ['8_char_c'], + on_delete => '', on_update => '', deferrable => 1, + }, + ], +); + +my %unique_constraints = ( + # CD + cd => [ + { + 'display' => 'cd artist and title unique', + 'name' => 'cd_artist_title', + 'table' => 'cd', 'cols' => ['artist', 'title'], + }, + ], + + # Producer + producer => [ + { + 'display' => 'producer name unique', + 'name' => 'prod_name', # explicit name + 'table' => 'producer', 'cols' => ['name'], + }, + ], + + long_columns => [ + { + 'display' => 'long but not quite truncated unique', + 'name' => 'long_columns_16_character_col_32_character_column_aaaaaaaaaaaa', + 'table' => 'long_columns', 'cols' => [qw( 32_character_column_aaaaaaaaaaaa 16_character_col )], + }, + { + 'display' => 'multi column truncated unique', + 'name' => 'long_columns_8_char_c_16_character_col_32_character_col_ee4a438c', + 'table' => 'long_columns', 'cols' => [qw( 32_character_column_aaaaaaaaaaaa 16_character_col 8_char_c )], + }, + { + 'display' => 'different multi column truncated unique with same base', + 'name' => 'long_columns_8_char_c_16_character_col_32_character_col_c5dbc7a7', + 'table' => 'long_columns', 'cols' => [qw( 32_character_column_bbbbbbbbbbbb 16_character_col 8_char_c )], + }, + { + 'display' => 'single column truncated unique', + 'name' => 'long_columns_64_character_column_aaaaaaaaaaaaaaaaaaaaaa_095dc664', + 'table' => 'long_columns', 'cols' => ['64_character_column_aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'], + }, + ], + + # TwoKeyTreeLike + twokeytreelike => [ + { + 'display' => 'twokeytreelike name unique', + 'name' => 'tktlnameunique', # explicit name + 'table' => 'twokeytreelike', 'cols' => ['name'], + }, + ], + + # Employee +# Constraint is commented out in DBICTest/Schema/Employee.pm +# employee => [ +# { +# 'display' => 'employee position and group_id unique', +# 'name' => 'position_group', +# 'table' => 'employee', cols => ['position', 'group_id'], +# }, +# ], +); + +my %indexes = ( + artist => [ + { + 'fields' => ['name'] + }, + ] ); my $tschema = $translator->schema(); -for my $table ($tschema->get_tables) { - my $table_name = $table->name; - for my $c ( $table->get_constraints ) { - if ($c->type eq 'FOREIGN KEY') { - ok(check_fk($table_name, scalar $c->fields, - $c->reference_table, scalar $c->reference_fields, - $c->on_delete, $c->on_update), "Foreign key constraint on $table_name matches an expected constraint"); - } - elsif ($c->type eq 'UNIQUE') { - ok(check_unique($table_name, scalar $c->fields), - "Unique constraint on $table_name matches an expected constraint"); - } - } +# Test that the $schema->sqlt_deploy_hook was called okay and that it removed +# the 'link' table +ok( !defined($tschema->get_table('link')), "Link table was removed by hook"); + +# Test that nonexistent constraints are not found +my $constraint = get_constraint('FOREIGN KEY', 'cd', ['title'], 'cd', ['year']); +ok( !defined($constraint), 'nonexistent FOREIGN KEY constraint not found' ); +$constraint = get_constraint('UNIQUE', 'cd', ['artist']); +ok( !defined($constraint), 'nonexistent UNIQUE constraint not found' ); +$constraint = get_constraint('FOREIGN KEY', 'forceforeign', ['cd'], 'cd', ['cdid']); +ok( !defined($constraint), 'forced nonexistent FOREIGN KEY constraint not found' ); + +for my $expected_constraints (keys %fk_constraints) { + for my $expected_constraint (@{ $fk_constraints{$expected_constraints} }) { + my $desc = $expected_constraint->{display}; + my $constraint = get_constraint( + 'FOREIGN KEY', + $expected_constraint->{selftable}, $expected_constraint->{selfcols}, + $expected_constraint->{foreigntable}, $expected_constraint->{foreigncols}, + ); + ok( defined($constraint), "FOREIGN KEY constraint matching `$desc' found" ); + test_fk($expected_constraint, $constraint); + } +} + +for my $expected_constraints (keys %unique_constraints) { + for my $expected_constraint (@{ $unique_constraints{$expected_constraints} }) { + my $desc = $expected_constraint->{display}; + my $constraint = get_constraint( + 'UNIQUE', $expected_constraint->{table}, $expected_constraint->{cols}, + ); + ok( defined($constraint), "UNIQUE constraint matching `$desc' found" ); + test_unique($expected_constraint, $constraint); + } } -# Make sure all the foreign keys are done. -my $i; -for ($i = 0; $i <= $#fk_constraints; ++$i) { - ok(!$fk_constraints[$i]->{'needed'}, "Constraint $fk_constraints[$i]->{display}"); +for my $table_index (keys %indexes) { + for my $expected_index ( @{ $indexes{$table_index} } ) { + + ok ( get_index($table_index, $expected_index), "Got a matching index on $table_index table"); + } +} + +# Returns the Constraint object for the specified constraint type, table and +# columns from the SQL::Translator schema, or undef if no matching constraint +# is found. +# +# NB: $type is either 'FOREIGN KEY' or 'UNIQUE'. In UNIQUE constraints the last +# two parameters are not used. +sub get_constraint { + my ($type, $table_name, $cols, $f_table, $f_cols) = @_; + $f_table ||= ''; # For UNIQUE constraints, reference_table is '' + $f_cols ||= []; + + my $table = $tschema->get_table($table_name); + + my %fields = map { $_ => 1 } @$cols; + my %f_fields = map { $_ => 1 } @$f_cols; + + CONSTRAINT: + for my $constraint ( $table->get_constraints ) { + next unless $constraint->type eq $type; + next unless $constraint->reference_table eq $f_table; + + my %rev_fields = map { $_ => 1 } $constraint->fields; + my %rev_f_fields = map { $_ => 1 } $constraint->reference_fields; + + # Check that the given fields are a subset of the constraint's fields + for my $field ($constraint->fields) { + next CONSTRAINT unless $fields{$field}; + } + if ($type eq 'FOREIGN KEY') { + for my $f_field ($constraint->reference_fields) { + next CONSTRAINT unless $f_fields{$f_field}; + } + } + + # Check that the constraint's fields are a subset of the given fields + for my $field (@$cols) { + next CONSTRAINT unless $rev_fields{$field}; + } + if ($type eq 'FOREIGN KEY') { + for my $f_field (@$f_cols) { + next CONSTRAINT unless $rev_f_fields{$f_field}; + } + } + + return $constraint; # everything passes, found the constraint + } + return undef; # didn't find a matching constraint } -# Make sure all the uniques are done. -for ($i = 0; $i <= $#unique_constraints; ++$i) { - ok(!$unique_constraints[$i]->{'needed'}, "Constraint $unique_constraints[$i]->{display}"); + +sub get_index { + my ($table_name, $index) = @_; + + my $table = $tschema->get_table($table_name); + + CAND_INDEX: + for my $cand_index ( $table->get_indices ) { + + next CAND_INDEX if $index->{name} && $cand_index->name ne $index->{name} + || $index->{type} && $cand_index->type ne $index->{type}; + + my %idx_fields = map { $_ => 1 } $cand_index->fields; + + for my $field ( @{ $index->{fields} } ) { + next CAND_INDEX unless $idx_fields{$field}; + } + + %idx_fields = map { $_ => 1 } @{$index->{fields}}; + for my $field ( $cand_index->fields) { + next CAND_INDEX unless $idx_fields{$field}; + } + + return $cand_index; + } + + return undef; # No matching idx } -sub check_fk { - my ($selftable, $selfcol, $foreigntable, $foreigncol, $ondel, $onupd) = @_; - - $ondel = '' if (!defined($ondel)); - $onupd = '' if (!defined($onupd)); - - my $i; - for ($i = 0; $i <= $#fk_constraints; ++$i) { - if ($selftable eq $fk_constraints[$i]->{'selftable'} && - $foreigntable eq $fk_constraints[$i]->{'foreigntable'} && - ($ondel eq $fk_constraints[$i]->{on_delete}) && - ($onupd eq $fk_constraints[$i]->{on_update})) { - # check columns - - my $found = 0; - for (my $j = 0; $j <= $#$selfcol; ++$j) { - $found = 0; - for (my $k = 0; $k <= $#{$fk_constraints[$i]->{'selfcols'}}; ++$k) { - if ($selfcol->[$j] eq $fk_constraints[$i]->{'selfcols'}->[$k] && - $foreigncol->[$j] eq $fk_constraints[$i]->{'foreigncols'}->[$k]) { - $found = 1; - last; - } - } - last unless $found; - } - - if ($found) { - for (my $j = 0; $j <= $#{$fk_constraints[$i]->{'selfcols'}}; ++$j) { - $found = 0; - for (my $k = 0; $k <= $#$selfcol; ++$k) { - if ($selfcol->[$k] eq $fk_constraints[$i]->{'selfcols'}->[$j] && - $foreigncol->[$k] eq $fk_constraints[$i]->{'foreigncols'}->[$j]) { - $found = 1; - last; - } - } - last unless $found; - } - } - - if ($found) { - --$fk_constraints[$i]->{needed}; - return 1; - } - } - } - return 0; +# Test parameters in a FOREIGN KEY constraint other than columns +sub test_fk { + my ($expected, $got) = @_; + my $desc = $expected->{display}; + is( $got->name, $expected->{name}, + "name parameter correct for `$desc'" ); + is( $got->on_delete, $expected->{on_delete}, + "on_delete parameter correct for `$desc'" ); + is( $got->on_update, $expected->{on_update}, + "on_update parameter correct for `$desc'" ); + is( $got->deferrable, $expected->{deferrable}, + "is_deferrable parameter correct for `$desc'" ); + + my $index = get_index( $got->table, { fields => $expected->{selfcols} } ); + ok( defined $index, "index exists for `$desc'" ); + is( $index->name, $expected->{index_name}, "index has correct name for `$desc'" ); } -my( $ondel, $onupd ); - -sub check_unique { - my ($selftable, $selfcol) = @_; - - $ondel = '' if (!defined($ondel)); - $onupd = '' if (!defined($onupd)); - - my $i; - for ($i = 0; $i <= $#unique_constraints; ++$i) { - if ($selftable eq $unique_constraints[$i]->{'table'}) { - - my $found = 0; - for (my $j = 0; $j <= $#$selfcol; ++$j) { - $found = 0; - for (my $k = 0; $k <= $#{$unique_constraints[$i]->{'cols'}}; ++$k) { - if ($selfcol->[$j] eq $unique_constraints[$i]->{'cols'}->[$k]) { - $found = 1; - last; - } - } - last unless $found; - } - - if ($found) { - for (my $j = 0; $j <= $#{$unique_constraints[$i]->{'cols'}}; ++$j) { - $found = 0; - for (my $k = 0; $k <= $#$selfcol; ++$k) { - if ($selfcol->[$k] eq $unique_constraints[$i]->{'cols'}->[$j]) { - $found = 1; - last; - } - } - last unless $found; - } - } - - if ($found) { - --$unique_constraints[$i]->{needed}; - return 1; - } - } - } - return 0; +sub test_unique { + my ($expected, $got) = @_; + my $desc = $expected->{display}; + is( $got->name, $expected->{name}, + "name parameter correct for `$desc'" ); }