X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F85utf8.t;h=fbba764b64bd09d8cc2df20755a9105c7ef757d7;hb=0ae1217d4c8ec781f748789de447d07cc1395fbf;hp=a18814d80b713d3caff3b3dbf6bcb8f5a31386d8;hpb=8236f0dc975f51ed07e7d901e4534878cb6a6b15;p=dbsrgits%2FDBIx-Class.git diff --git a/t/85utf8.t b/t/85utf8.t index a18814d..fbba764 100644 --- a/t/85utf8.t +++ b/t/85utf8.t @@ -1,28 +1,59 @@ use strict; -use warnings; +use warnings; use Test::More; +use Test::Warn; use lib qw(t/lib); use DBICTest; +use utf8; + +warning_like ( + sub { + package A::Comp; + use base 'DBIx::Class'; + sub store_column { shift->next::method (@_) }; + 1; + + package A::Test; + use base 'DBIx::Class::Core'; + __PACKAGE__->load_components(qw(UTF8Columns +A::Comp)); + 1; + }, + qr/Incorrect loading order of DBIx::Class::UTF8Columns.+affect other components overriding store_column \(A::Comp\)/, + 'incorrect order warning issued', +); my $schema = DBICTest->init_schema(); - -eval 'use utf8; 1' - or plan skip_all => 'Need utf8 run this test'; - -plan tests => 3; - DBICTest::Schema::CD->load_components('UTF8Columns'); DBICTest::Schema::CD->utf8_columns('title'); Class::C3->reinitialize(); -my $cd = $schema->resultset('CD')->create( { artist => 1, title => 'øni', year => 'foo' } ); +my $cd = $schema->resultset('CD')->create( { artist => 1, title => 'øni', year => '2048' } ); +my $utf8_char = 'uniuni'; + + ok( utf8::is_utf8( $cd->title ), 'got title with utf8 flag' ); -ok( !utf8::is_utf8( $cd->year ), 'got year without utf8 flag' ); +ok(! utf8::is_utf8( $cd->year ), 'got year without utf8 flag' ); -my $utf8_char = 'uniuni'; utf8::decode($utf8_char); $cd->title($utf8_char); -ok( !utf8::is_utf8( $cd->{_column_data}{title} ), - 'store utf8-less chars' ); +ok(! utf8::is_utf8( $cd->{_column_data}{title} ), 'store utf8-less chars' ); + + +my $v_utf8 = "\x{219}"; + +$cd->update ({ title => $v_utf8 }); +$cd->title($v_utf8); +ok( !$cd->is_column_changed('title'), 'column is not dirty after setting the same unicode value' ); + +$cd->update ({ title => $v_utf8 }); +$cd->title('something_else'); +ok( $cd->is_column_changed('title'), 'column is dirty after setting to something completely different'); + +TODO: { + local $TODO = 'There is currently no way to propagate aliases to inflate_result()'; + $cd = $schema->resultset('CD')->find ({ title => $v_utf8 }, { select => 'title', as => 'name' }); + ok (utf8::is_utf8( $cd->get_column ('name') ), 'utf8 flag propagates via as'); +} +done_testing;