X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F85utf8.t;h=3e4483596b25e6c58c025a3d1923f10e4bbe2a06;hb=63ee8b7896e02ee888eb26251fc28311721832c5;hp=af6dedf5fde6d90a03415a2d1a9c3d4099e26d6d;hpb=70c288086248e5a4008490df22a56632341f2473;p=dbsrgits%2FDBIx-Class.git diff --git a/t/85utf8.t b/t/85utf8.t index af6dedf..3e44835 100644 --- a/t/85utf8.t +++ b/t/85utf8.t @@ -1,11 +1,12 @@ +BEGIN { do "./t/lib/ANFANG.pm" or die ( $@ || $! ) } + use strict; use warnings; use Test::More; use Test::Warn; -use lib qw(t/lib); + use DBICTest; -use DBIC::DebugObj; { package A::Comp; @@ -37,6 +38,7 @@ warnings_are ( warnings_like ( sub { + local $ENV{DBIC_UTF8COLUMNS_OK}; package A::Test1Loud; use base 'DBIx::Class::Core'; __PACKAGE__->load_components(qw(Core +A::Comp Ordered UTF8Columns)); @@ -87,7 +89,7 @@ warnings_like ( my $schema = DBICTest->init_schema(); DBICTest::Schema::CD->load_components('UTF8Columns'); DBICTest::Schema::CD->utf8_columns('title'); -Class::C3->reinitialize(); +Class::C3->reinitialize() if DBIx::Class::_ENV_::OLD_MRO; # as per http://search.cpan.org/dist/Test-Simple/lib/Test/More.pm#utf8 binmode (Test::More->builder->$_, ':utf8') for qw/output failure_output todo_output/; @@ -96,24 +98,22 @@ my $bytestream_title = my $utf8_title = "weird \x{466} stuff"; utf8::encode($bytestream_title); cmp_ok ($bytestream_title, 'ne', $utf8_title, 'unicode/raw differ (sanity check)'); -my $storage = $schema->storage; -my ($sql, @bind); -my $debugobj = DBIC::DebugObj->new (\$sql, \@bind); -my ($orig_debug, $orig_debugobj) = ($storage->debug, $storage->debugobj); -$storage->debugobj ($debugobj); -$storage->debug (1); - -my $cd = $schema->resultset('CD')->create( { artist => 1, title => $utf8_title, year => '2048' } ); - -$storage->debugobj ($orig_debugobj); -$storage->debug ($orig_debug); - -# bind values are always alphabetically ordered by column, thus [1] -# the single quotes are an artefact of the debug-system -TODO: { +my $cd; +{ local $TODO = "This has been broken since rev 1191, Mar 2006"; - is ($bind[1], "'$bytestream_title'", 'INSERT: raw bytes sent to the database'); -} + + $schema->is_executed_sql_bind( sub { + $cd = $schema->resultset('CD')->create( { artist => 1, title => $utf8_title, year => '2048' } ) + }, [[ + 'INSERT INTO cd ( artist, title, year) VALUES ( ?, ?, ? )', + [ { dbic_colname => "artist", sqlt_datatype => "integer" } + => 1 ], + [ { dbic_colname => "title", sqlt_datatype => "varchar", sqlt_size => 100 } + => $bytestream_title ], + [ { dbic_colname => "year", sqlt_datatype => "varchar", sqlt_size => 100 } + => 2048 ], + ]], 'INSERT: raw bytes sent to the database' ); +}; # this should be using the cursor directly, no inflation/processing of any sort my ($raw_db_title) = $schema->resultset('CD') @@ -148,16 +148,20 @@ ok(! utf8::is_utf8( $cd->{_column_data}{title} ), 'reloaded utf8-less title' ); $bytestream_title = $utf8_title = "something \x{219} else"; utf8::encode($bytestream_title); +$schema->is_executed_sql_bind( sub { + $cd->update ({ title => $utf8_title }); +}, [ + [ 'BEGIN' ], + [ + 'UPDATE cd SET title = ? WHERE cdid = ?', + [ { dbic_colname => "title", sqlt_datatype => "varchar", sqlt_size => 100 } + => $bytestream_title ], + [ { dbic_colname => "cdid", sqlt_datatype => "integer" } + => 6 ], + ], + [ 'COMMIT' ], +], 'UPDATE: raw bytes sent to the database'); -$storage->debugobj ($debugobj); -$storage->debug (1); - -$cd->update ({ title => $utf8_title }); - -$storage->debugobj ($orig_debugobj); -$storage->debug ($orig_debug); - -is ($bind[0], "'$bytestream_title'", 'UPDATE: raw bytes sent to the database'); ($raw_db_title) = $schema->resultset('CD') ->search ($cd->ident_condition) ->get_column('title') @@ -174,7 +178,7 @@ $cd->update ({ title => $utf8_title }); $cd->title('something_else'); ok( $cd->is_column_changed('title'), 'column is dirty after setting to something completely different'); -TODO: { +{ local $TODO = 'There is currently no way to propagate aliases to inflate_result()'; $cd = $schema->resultset('CD')->find ({ title => $utf8_title }, { select => 'title', as => 'name' }); ok (utf8::is_utf8( $cd->get_column ('name') ), 'utf8 flag propagates via as');