X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F81transactions.t;h=32d5f17ec9a96cb0cf3234e65caea5376142a3b5;hb=ee9f372c2a8baeca71c3a4affb6869d2ceeff419;hp=b0054afc5ca2dc2aad9894770e62ce514f0256bf;hpb=57c18b65cf1c7d708efd3717f54fbbc3def07794;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/t/81transactions.t b/t/81transactions.t index b0054af..32d5f17 100644 --- a/t/81transactions.t +++ b/t/81transactions.t @@ -2,12 +2,13 @@ use strict; use warnings; use Test::More; +use Test::Exception; use lib qw(t/lib); use DBICTest; my $schema = DBICTest->init_schema(); -plan tests => 54; +plan tests => 64; my $code = sub { my ($artist, @cd_titles) = @_; @@ -234,5 +235,87 @@ my $fail_code = sub { $schema2->txn_begin(); }; my $err = $@; - ok(($err eq ''), 'Pre-connection nested transactions.'); + ok(! $err, 'Pre-connection nested transactions.'); + + # although not connected DBI would still warn about rolling back at disconnect + $schema2->txn_rollback; + $schema2->txn_rollback; + $schema2->storage->disconnect; +} +$schema->storage->disconnect; + +# Test txn_scope_guard +{ + my $schema = DBICTest->init_schema(); + + is($schema->storage->transaction_depth, 0, "Correct transaction depth"); + my $artist_rs = $schema->resultset('Artist'); + throws_ok { + my $guard = $schema->txn_scope_guard; + + + $artist_rs->create({ + name => 'Death Cab for Cutie', + made_up_column => 1, + }); + + $guard->commit; + } qr/No such column made_up_column .*? at .*?81transactions.t line \d+/s, "Error propogated okay"; + + ok(!$artist_rs->find({name => 'Death Cab for Cutie'}), "Artist not created"); + + my $inner_exception; + eval { + outer($schema, 1); + }; + is($@, $inner_exception, "Nested exceptions propogated"); + + ok(!$artist_rs->find({name => 'Death Cab for Cutie'}), "Artist not created"); + + lives_ok (sub { + my $w; + local $SIG{__WARN__} = sub { $w = shift }; + + # The 0 arg says don't die, just let the scope guard go out of scope + # forcing a txn_rollback to happen + outer($schema, 0); + + like ($w, qr/A DBIx::Class::Storage::TxnScopeGuard went out of scope without explicit commit or an error/, 'Out of scope warning detected'); + ok(!$artist_rs->find({name => 'Death Cab for Cutie'}), "Artist not created"); + }, 'rollback successful withot exception'); + + sub outer { + my ($schema) = @_; + + my $guard = $schema->txn_scope_guard; + $schema->resultset('Artist')->create({ + name => 'Death Cab for Cutie', + }); + inner(@_); + } + + sub inner { + my ($schema, $fatal) = @_; + + my $inner_guard = $schema->txn_scope_guard; + is($schema->storage->transaction_depth, 2, "Correct transaction depth"); + + my $artist = $artist_rs->find({ name => 'Death Cab for Cutie' }); + + eval { + $artist->cds->create({ + title => 'Plans', + year => 2005, + $fatal ? ( foo => 'bar' ) : () + }); + }; + if ($@) { + # Record what got thrown so we can test it propgates out properly. + $inner_exception = $@; + die $@; + } + + # inner guard should commit without consequences + $inner_guard->commit; + } }