X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F76joins.t;h=c03df6bbe4c3a56561e5ad240aaf6a04b643c658;hb=fdb8385a961f14c3fd4ecf321c7ea6465066d306;hp=538699f6d49d982c25aa66a1c45ec26d158665f3;hpb=e9188247f020a63ab8b6280c9dcdcb0df5b5f0c1;p=dbsrgits%2FDBIx-Class.git diff --git a/t/76joins.t b/t/76joins.t index 538699f..c03df6b 100644 --- a/t/76joins.t +++ b/t/76joins.t @@ -16,7 +16,7 @@ BEGIN { eval "use DBD::SQLite"; plan $@ ? ( skip_all => 'needs DBD::SQLite for testing' ) - : ( tests => 53 ); + : ( tests => 62 ); } # figure out if we've got a version of sqlite that is older than 3.2.6, in @@ -105,7 +105,7 @@ my @j6 = ( [ { father => 'person' }, { 'father.person_id' => { '!=', '42' } }, ], [ { mother => 'person' }, { 'mother.person_id' => 'child.mother_id' } ], ); -$match = qr/^\QHASH reference arguments are not supported in JOINS - try using \"..." instead\E/; +$match = qr/^HASH reference arguments are not supported in JOINS - try using "\.\.\." instead/; eval { $sa->_recurse_from(@j6) }; like( $@, $match, 'join 6 (HASH reference for ON statement dies) ok' ); @@ -169,7 +169,7 @@ is(Dumper($attr), $attr_str, 'Attribute hash untouched after search()'); cmp_ok($rs + 0, '==', 3, 'Correct number of records returned'); my $queries = 0; -$schema->storage->debugcb(sub { $queries++ }); +$schema->storage->debugcb(sub { $queries++; }); $schema->storage->debug(1); my @cd = $rs->all; @@ -222,12 +222,42 @@ is($queries, 1, 'nested prefetch ran exactly 1 select statement (excluding colum $queries = 0; +is($tag->search_related('cd')->search_related('artist')->first->name, + 'Caterwauler McCrae', + 'chained belongs_to->belongs_to search_related ok'); + +is($queries, 0, 'chained search_related after belontgs_to->belongs_to prefetch ran no queries'); + +$queries = 0; + $cd = $schema->resultset('CD')->find(1, { prefetch => 'artist' }); is($cd->{_inflated_column}{artist}->name, 'Caterwauler McCrae', 'artist prefetched correctly on find'); is($queries, 1, 'find with prefetch ran exactly 1 select statement (excluding column_info)'); +$queries = 0; + +$schema->storage->debugcb(sub { $queries++; }); + +$cd = $schema->resultset('CD')->find(1, { prefetch => { cd_to_producer => 'producer' } }); + +is($cd->producers->first->name, 'Matt S Trout', 'many_to_many accessor ok'); + +TODO: { + local $TODO = 'use prefetched values for many_to_many accessor'; + + is($queries, 1, 'many_to_many accessor with nested prefetch ran exactly 1 query'); +} + +$queries = 0; + +my $producers = $cd->search_related('cd_to_producer')->search_related('producer'); + +is($producers->first->name, 'Matt S Trout', 'chained many_to_many search_related ok'); + +is($queries, 0, 'chained search_related after many_to_many prefetch ran no queries'); + $schema->storage->debug($orig_debug); $schema->storage->debugobj->callback(undef); @@ -380,7 +410,8 @@ my $art_rs_pr = $art_rs->search( {}, { join => [ { cds => ['tracks'] } ], - prefetch => [ { cds => ['tracks'] } ] + prefetch => [ { cds => ['tracks'] } ], + cache => 1 # last test needs this } ); @@ -405,12 +436,24 @@ sub make_hash_struc { return $struc; } +$queries = 0; +$schema->storage->debugcb(sub { $queries++ }); +$schema->storage->debug(1); + my $prefetch_result = make_hash_struc($art_rs_pr); + +is($queries, 1, 'nested prefetch across has_many->has_many ran exactly 1 query'); + my $nonpre_result = make_hash_struc($art_rs); -TODO: { - local $TODO = 'fixing collapse in -current'; is_deeply( $prefetch_result, $nonpre_result, 'Compare 2 level prefetch result to non-prefetch result' ); -} +$queries = 0; + +is($art_rs_pr->search_related('cds')->search_related('tracks')->first->title, + 'Fowlin', + 'chained has_many->has_many search_related ok' + ); + +is($queries, 0, 'chained search_related after has_many->has_many prefetch ran no queries');