X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F752sqlite.t;h=c07327ef44fde46bd2ad0797c2cdb6e798f5837c;hb=7e763495bb690cf995a23e2c33c3f55c7d1842e4;hp=b7935433bcee01c9d96d355843d9add5c032c517;hpb=d634850b14e7b23a617d8373a4bb8684a8db8b8a;p=dbsrgits%2FDBIx-Class.git diff --git a/t/752sqlite.t b/t/752sqlite.t index b793543..c07327e 100644 --- a/t/752sqlite.t +++ b/t/752sqlite.t @@ -144,6 +144,11 @@ $row->discard_changes; is ($row->rank, 'abc', 'proper rank inserted into database'); # and make sure we do not lose actual bigints +SKIP: { + +skip "Not testing bigint handling on known broken DBD::SQLite trial versions", 1 + if modver_gt_or_eq_and_lt( 'DBD::SQLite', '1.45', '1.45_03' ); + { package DBICTest::BigIntArtist; use base 'DBICTest::Schema::Artist'; @@ -174,7 +179,6 @@ for my $bi ( qw( 1 2 - -9223372036854775808 -9223372036854775807 -8694837494948124658 -6848440844435891639 @@ -209,6 +213,15 @@ for my $bi ( qw( $sqlite_broken_bigint ? () : ( '2147483648', '2147483649' ) + , + + # with newer compilers ( gcc 4.9+ ) older DBD::SQLite does not + # play well with the "Most Negative Number" + modver_gt_or_eq( 'DBD::SQLite', '1.33' ) + ? ( '-9223372036854775808' ) + : () + , + ) { # unsigned 32 bit ints have a range of −2,147,483,648 to 2,147,483,647 # alternatively expressed as the hexadecimal numbers below @@ -240,7 +253,7 @@ for my $bi ( qw( eval { $row = $schema->resultset('BigIntArtist')->create({ bigint => $bi }); } or do { - fail("Exception on inserting $v_desc") unless $sqlite_broken_bigint; + fail("Exception on inserting $v_desc: $@") unless $sqlite_broken_bigint; next; }; @@ -266,11 +279,6 @@ for my $bi ( qw( "value in database correct ($v_desc)" ); -# FIXME - temporary smoke-only escape -SKIP: { - skip 'Potential for false negatives - investigation pending', 1 - if DBICTest::RunMode->is_plain; - # check if math works # start by adding/subtracting a 50 bit integer, and then divide by 2 for good measure my ($sqlop, $expect) = $bi < 0 @@ -304,11 +312,10 @@ SKIP: { , "simple integer math with@{[ $dtype ? '' : 'out' ]} bindtype in database correct (base $v_desc)") or diag sprintf '%s != %s', $row->bigint, $expect; } -# end of fixme -} is_deeply (\@w, [], "No mismatch warnings on bigint operations ($v_desc)" ); -} + +}} done_testing;