X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F74mssql.t;h=f24e1967ca8841f7eafb9eb479f186e20870826e;hb=8b16ef4e820ac2e747bbb639614bd9405c6b735c;hp=2ec7fa5fed223459c8a5094b686c6e581fbccca5;hpb=65d351219882184861384aedac6f251b6797d0d7;p=dbsrgits%2FDBIx-Class.git

diff --git a/t/74mssql.t b/t/74mssql.t
index 2ec7fa5..f24e196 100644
--- a/t/74mssql.t
+++ b/t/74mssql.t
@@ -1,29 +1,17 @@
+BEGIN { do "./t/lib/ANFANG.pm" or die ( $@ || $! ) }
+use DBIx::Class::Optional::Dependencies -skip_all_without => 'test_rdbms_mssql_sybase';
+
 use strict;
 use warnings;
 
-# use this if you keep a copy of DBD::Sybase linked to FreeTDS somewhere else
-BEGIN {
-  if (my $lib_dirs = $ENV{DBICTEST_MSSQL_PERL5LIB}) {
-    unshift @INC, $_ for split /:/, $lib_dirs;
-  }
-}
-
 use Test::More;
 use Test::Exception;
 use Scalar::Util 'weaken';
-use DBIx::Class::Optional::Dependencies ();
-use lib qw(t/lib);
+use DBIx::Class::_Util 'sigwarn_silencer';
+
 use DBICTest;
 
 my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_MSSQL_${_}" } qw/DSN USER PASS/};
-
-plan skip_all => 'Set $ENV{DBICTEST_MSSQL_DSN}, _USER and _PASS to run this test'
-  unless ($dsn);
-
-
-plan skip_all => 'Test needs ' . DBIx::Class::Optional::Dependencies->req_missing_for ('test_rdbms_mssql_sybase')
-  unless DBIx::Class::Optional::Dependencies->req_ok_for ('test_rdbms_mssql_sybase');
-
 {
   my $srv_ver = DBICTest::Schema->connect($dsn, $user, $pass)->storage->_server_info->{dbms_version};
   ok ($srv_ver, 'Got a test server version on fresh schema: ' . ($srv_ver||'???') );
@@ -201,13 +189,14 @@ SQL
     $rs->delete;
   }
 
-  # test transaction handling on a disconnected handle
   my $wrappers = {
     no_transaction => sub { shift->() },
     txn_do => sub { my $code = shift; $schema->txn_do(sub { $code->() } ) },
     txn_begin => sub { $schema->txn_begin; shift->(); $schema->txn_commit },
     txn_guard => sub { my $g = $schema->txn_scope_guard; shift->(); $g->commit },
   };
+
+  # test transaction handling on a disconnected handle
   for my $wrapper (keys %$wrappers) {
     $rs->delete;
 
@@ -215,7 +204,7 @@ SQL
     $schema->storage->_get_dbh->disconnect;
 
 
-    lives_and {
+    lives_ok {
       $wrappers->{$wrapper}->( sub {
         $rs_cp->create({ amount => 900 + $_ }) for 1..3;
       });
@@ -223,45 +212,45 @@ SQL
     } "transaction on disconnected handle with $wrapper wrapper";
   }
 
-  TODO: {
-    local $TODO = 'Transaction handling with multiple active statements will '
-                 .'need eager cursor support.';
-
-    # test transaction handling on a disconnected handle with multiple active
-    # statements
-    my $wrappers = {
-      no_transaction => sub { shift->() },
-      txn_do => sub { my $code = shift; $schema->txn_do(sub { $code->() } ) },
-      txn_begin => sub { $schema->txn_begin; shift->(); $schema->txn_commit },
-      txn_guard => sub { my $g = $schema->txn_scope_guard; shift->(); $g->commit },
-    };
-    for my $wrapper (keys %$wrappers) {
-      $rs->reset;
-      $rs->delete;
-      $rs->create({ amount => 1000 + $_ }) for (1..3);
-
-      my $artist_rs = $schema->resultset('Artist')->search({
-        name => { -like => 'Artist %' }
-      });;
-
-      $rs->next;
-
-      my $map = [ ['Artist 1', '1002.00'], ['Artist 2', '1003.00'] ];
-
-      weaken(my $a_rs_cp = $artist_rs);
-
-      lives_and {
-        my @results;
-        $wrappers->{$wrapper}->( sub {
-          while (my $money = $rs_cp->next) {
-            my $artist = $a_rs_cp->next;
-            push @results, [ $artist->name, $money->amount ];
-          };
-        });
-
-        is_deeply \@results, $map;
-      } "transactions with multiple active statement with $wrapper wrapper";
-    }
+  # test transaction handling on a disconnected handle with multiple active
+  # statements
+  for my $wrapper (keys %$wrappers) {
+    $schema->storage->disconnect;
+    $rs->delete;
+    $rs->reset;
+    $rs->create({ amount => 1000 + $_ }) for (1..3);
+
+    my $artist_rs = $schema->resultset('Artist')->search({
+      name => { -like => 'Artist %' }
+    });;
+
+    $rs->next;
+
+    my $map = [ ['Artist 1', '1002.00'], ['Artist 2', '1003.00'] ];
+
+    weaken(my $a_rs_cp = $artist_rs);
+
+    $wrapper ne 'no_transaction'
+      and
+    (
+      local $TODO = 'Transaction handling with multiple active statements will '
+                   .'need eager cursor support.',
+
+      local local $SIG{__WARN__} = sigwarn_silencer qr/disconnect invalidates .+? active statement/
+    );
+
+    lives_ok {
+      my @results;
+
+      $wrappers->{$wrapper}->( sub {
+        while (my $money = $rs_cp->next) {
+          my $artist = $a_rs_cp->next;
+          push @results, [ $artist->name, $money->amount ];
+        };
+      });
+
+      is_deeply \@results, $map;
+    } "transactions with multiple active statement with $wrapper wrapper";
   }
 
   # test RNO detection when version detection fails