X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F746mssql.t;h=f120c128d18a53675f41280a5500bd454d325e54;hb=d867eedaa703200d7f0bc329836e99b6bd22bc39;hp=a9589868ecac8f78764dec5dcb3e9eaf63a79db1;hpb=64c7c000587e6e6dccb9fc6330a66dcebd1f3695;p=dbsrgits%2FDBIx-Class.git diff --git a/t/746mssql.t b/t/746mssql.t index a958986..f120c12 100644 --- a/t/746mssql.t +++ b/t/746mssql.t @@ -2,6 +2,7 @@ use strict; use warnings; use Test::More; +use Test::Exception; use lib qw(t/lib); use DBICTest; use DBIC::SqlMakerTest; @@ -11,8 +12,7 @@ my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_MSSQL_ODBC_${_}" } qw/DSN USER PA plan skip_all => 'Set $ENV{DBICTEST_MSSQL_ODBC_DSN}, _USER and _PASS to run this test' unless ($dsn && $user); -plan tests => 25; - +DBICTest::Schema->load_classes('ArtistGUID'); my $schema = DBICTest::Schema->connect($dsn, $user, $pass); { @@ -32,7 +32,6 @@ $schema->storage->dbh_do (sub { my ($storage, $dbh) = @_; eval { $dbh->do("DROP TABLE artist") }; $dbh->do(<<'SQL'); - CREATE TABLE artist ( artistid INT IDENTITY NOT NULL, name VARCHAR(100), @@ -40,19 +39,38 @@ CREATE TABLE artist ( charfield CHAR(10) NULL, primary key(artistid) ) - SQL - }); my %seen_id; -# fresh $schema so we start unconnected -$schema = DBICTest::Schema->connect($dsn, $user, $pass); +my @opts = ( + { on_connect_call => 'use_dynamic_cursors' }, + {}, +); +my $new; + +# test Auto-PK with different options +for my $opts (@opts) { + SKIP: { + $schema = DBICTest::Schema->connect($dsn, $user, $pass, $opts); + + eval { + $schema->storage->ensure_connected + }; + if ($@ =~ /dynamic cursors/) { + skip +'Dynamic Cursors not functional, tds_version 8.0 or greater required if using'. +' FreeTDS', 1; + } + + $schema->resultset('Artist')->search({ name => 'foo' })->delete; -# test primary key handling -my $new = $schema->resultset('Artist')->create({ name => 'foo' }); -ok($new->artistid > 0, "Auto-PK worked"); + $new = $schema->resultset('Artist')->create({ name => 'foo' }); + + ok($new->artistid > 0, "Auto-PK worked"); + } +} $seen_id{$new->artistid}++; @@ -74,13 +92,90 @@ $it->next; is( $it->next->name, "Artist 2", "iterator->next ok" ); is( $it->next, undef, "next past end of resultset ok" ); +# test GUID columns + $schema->storage->dbh_do (sub { my ($storage, $dbh) = @_; - eval { $dbh->do("DROP TABLE Owners") }; - eval { $dbh->do("DROP TABLE Books") }; + eval { $dbh->do("DROP TABLE artist") }; $dbh->do(<<'SQL'); +CREATE TABLE artist ( + artistid UNIQUEIDENTIFIER NOT NULL, + name VARCHAR(100), + rank INT NOT NULL DEFAULT '13', + charfield CHAR(10) NULL, + a_guid UNIQUEIDENTIFIER, + primary key(artistid) +) +SQL +}); + +# start disconnected to make sure insert works on an un-reblessed storage +$schema = DBICTest::Schema->connect($dsn, $user, $pass); + +my $row; +lives_ok { + $row = $schema->resultset('ArtistGUID')->create({ name => 'mtfnpy' }) +} 'created a row with a GUID'; + +ok( + eval { $row->artistid }, + 'row has GUID PK col populated', +); +diag $@ if $@; + +ok( + eval { $row->a_guid }, + 'row has a GUID col with auto_nextval populated', +); +diag $@ if $@; + +my $row_from_db = $schema->resultset('ArtistGUID') + ->search({ name => 'mtfnpy' })->first; +is $row_from_db->artistid, $row->artistid, + 'PK GUID round trip'; +is $row_from_db->a_guid, $row->a_guid, + 'NON-PK GUID round trip'; + +# test MONEY type +$schema->storage->dbh_do (sub { + my ($storage, $dbh) = @_; + eval { $dbh->do("DROP TABLE money_test") }; + $dbh->do(<<'SQL'); +CREATE TABLE money_test ( + id INT IDENTITY PRIMARY KEY, + amount MONEY NULL +) +SQL +}); + +my $rs = $schema->resultset('Money'); + +lives_ok { + $row = $rs->create({ amount => 100 }); +} 'inserted a money value'; + +cmp_ok $rs->find($row->id)->amount, '==', 100, 'money value round-trip'; + +lives_ok { + $row->update({ amount => 200 }); +} 'updated a money value'; + +cmp_ok $rs->find($row->id)->amount, '==', 200, + 'updated money value round-trip'; + +lives_ok { + $row->update({ amount => undef }); +} 'updated a money value to NULL'; + +is $rs->find($row->id)->amount, undef,'updated money value to NULL round-trip'; + +$schema->storage->dbh_do (sub { + my ($storage, $dbh) = @_; + eval { $dbh->do("DROP TABLE Owners") }; + eval { $dbh->do("DROP TABLE Books") }; + $dbh->do(<<'SQL'); CREATE TABLE Books ( id INT IDENTITY (1, 1) NOT NULL, source VARCHAR(100), @@ -93,52 +188,77 @@ CREATE TABLE Owners ( id INT IDENTITY (1, 1) NOT NULL, name VARCHAR(100), ) - SQL }); -$schema->populate ('Owners', [ - [qw/id name /], - [qw/1 wiggle/], - [qw/2 woggle/], - [qw/3 boggle/], - [qw/4 fREW/], - [qw/5 fRIOUX/], - [qw/6 fROOH/], - [qw/7 fRUE/], - [qw/8 fISMBoC/], - [qw/9 station/], - [qw/10 mirror/], - [qw/11 dimly/], - [qw/12 face_to_face/], - [qw/13 icarus/], - [qw/14 dream/], - [qw/15 dyrstyggyr/], -]); - -$schema->populate ('BooksInLibrary', [ - [qw/source owner title /], - [qw/Library 1 secrets0/], - [qw/Library 1 secrets1/], - [qw/Eatery 1 secrets2/], - [qw/Library 2 secrets3/], - [qw/Library 3 secrets4/], - [qw/Eatery 3 secrets5/], - [qw/Library 4 secrets6/], - [qw/Library 5 secrets7/], - [qw/Eatery 5 secrets8/], - [qw/Library 6 secrets9/], - [qw/Library 7 secrets10/], - [qw/Eatery 7 secrets11/], - [qw/Library 8 secrets12/], -]); + +lives_ok ( sub { + # start a new connection, make sure rebless works + my $schema = DBICTest::Schema->connect($dsn, $user, $pass); + $schema->populate ('Owners', [ + [qw/id name /], + [qw/1 wiggle/], + [qw/2 woggle/], + [qw/3 boggle/], + [qw/4 fREW/], + [qw/5 fRIOUX/], + [qw/6 fROOH/], + [qw/7 fRUE/], + [qw/8 fISMBoC/], + [qw/9 station/], + [qw/10 mirror/], + [qw/11 dimly/], + [qw/12 face_to_face/], + [qw/13 icarus/], + [qw/14 dream/], + [qw/15 dyrstyggyr/], + ]); +}, 'populate with PKs supplied ok' ); + +lives_ok (sub { + # start a new connection, make sure rebless works + # test an insert with a supplied identity, followed by one without + my $schema = DBICTest::Schema->connect($dsn, $user, $pass); + for (1..2) { + my $id = $_ * 20 ; + $schema->resultset ('Owners')->create ({ id => $id, name => "troglodoogle $id" }); + $schema->resultset ('Owners')->create ({ name => "troglodoogle " . ($id + 1) }); + } +}, 'create with/without PKs ok' ); + +is ($schema->resultset ('Owners')->count, 19, 'owner rows really in db' ); + +lives_ok ( sub { + # start a new connection, make sure rebless works + my $schema = DBICTest::Schema->connect($dsn, $user, $pass); + $schema->populate ('BooksInLibrary', [ + [qw/source owner title /], + [qw/Library 1 secrets0/], + [qw/Library 1 secrets1/], + [qw/Eatery 1 secrets2/], + [qw/Library 2 secrets3/], + [qw/Library 3 secrets4/], + [qw/Eatery 3 secrets5/], + [qw/Library 4 secrets6/], + [qw/Library 5 secrets7/], + [qw/Eatery 5 secrets8/], + [qw/Library 6 secrets9/], + [qw/Library 7 secrets10/], + [qw/Eatery 7 secrets11/], + [qw/Library 8 secrets12/], + ]); +}, 'populate without PKs supplied ok' ); # -# try a distinct + prefetch on tables with identically named columns +# try a prefetch on tables with identically named columns # +# set quote char - make sure things work while quoted +$schema->storage->_sql_maker->{quote_char} = [qw/[ ]/]; +$schema->storage->_sql_maker->{name_sep} = '.'; + { - # try a ->has_many direction (group_by is not possible on has_many with limit) + # try a ->has_many direction my $owners = $schema->resultset ('Owners')->search ({ 'books.id' => { '!=', undef } }, { @@ -156,19 +276,19 @@ $schema->populate ('BooksInLibrary', [ is ($owners->page(3)->count, 2, 'has-many prefetch returns correct count'); is ($owners->page(3)->count_rs->next, 2, 'has-many prefetch returns correct count_rs'); - # make sure count does not become overly complex FIXME + # make sure count does not become overly complex is_same_sql_bind ( $owners->page(3)->count_rs->as_query, '( SELECT COUNT( * ) FROM ( - SELECT TOP 3 me.id - FROM owners me - LEFT JOIN books books ON books.owner = me.id - WHERE ( books.id IS NOT NULL ) - GROUP BY me.id - ORDER BY me.id DESC - ) count_subq + SELECT TOP 3 [me].[id] + FROM [owners] [me] + LEFT JOIN [books] [books] ON [books].[owner] = [me].[id] + WHERE ( [books].[id] IS NOT NULL ) + GROUP BY [me].[id] + ORDER BY [me].[id] DESC + ) [count_subq] )', [], ); @@ -180,8 +300,10 @@ $schema->populate ('BooksInLibrary', [ }, { distinct => 1, prefetch => 'owner', - order_by => 'name', rows => 2, # 3 results total + order_by => { -desc => 'owner' }, + # there is no sane way to order by the right side of a grouped prefetch currently :( + #order_by => { -desc => 'owner.name' }, }); @@ -194,19 +316,19 @@ $schema->populate ('BooksInLibrary', [ is ($books->page(2)->count, 1, 'Prefetched grouped search returns correct count'); is ($books->page(2)->count_rs->next, 1, 'Prefetched grouped search returns correct count_rs'); - # make sure count does not become overly complex FIXME + # make sure count does not become overly complex (FIXME - the distinct-induced group_by is incorrect) is_same_sql_bind ( $books->page(2)->count_rs->as_query, '( SELECT COUNT( * ) FROM ( - SELECT TOP 2 me.id - FROM books me - JOIN owners owner ON owner.id = me.owner - WHERE ( ( ( owner.name = ? OR owner.name = ? ) AND source = ? ) ) - GROUP BY me.id, me.source, me.owner, me.title, me.price, owner.id, owner.name - ORDER BY me.id DESC - ) count_subq + SELECT TOP 2 [me].[id] + FROM [books] [me] + JOIN [owners] [owner] ON [owner].[id] = [me].[owner] + WHERE ( ( ( [owner].[name] = ? OR [owner].[name] = ? ) AND [source] = ? ) ) + GROUP BY [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price] + ORDER BY [me].[id] DESC + ) [count_subq] )', [ [ 'owner.name' => 'wiggle' ], @@ -215,12 +337,15 @@ $schema->populate ('BooksInLibrary', [ ], ); } - } +done_testing; + # clean up our mess END { - my $dbh = eval { $schema->storage->_dbh }; - $dbh->do('DROP TABLE artist') if $dbh; + if (my $dbh = eval { $schema->storage->_dbh }) { + eval { $dbh->do("DROP TABLE $_") } + for qw/artist money_test Books Owners/; + } } # vim:sw=2 sts=2