X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F746mssql.t;h=0dbd4792e3afef45bb9cc6ab45b52179990150ab;hb=e06ad5d5eca3cad12045953e06fd6b6c72c1027d;hp=a23898f5babe2a34107891e5041632b95ef1654a;hpb=b2d16f1f55e1768a7690e312b97492fe7143391e;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/t/746mssql.t b/t/746mssql.t index a23898f..0dbd479 100644 --- a/t/746mssql.t +++ b/t/746mssql.t @@ -2,6 +2,7 @@ use strict; use warnings; use Test::More; +use Test::Exception; use lib qw(t/lib); use DBICTest; use DBIC::SqlMakerTest; @@ -11,7 +12,7 @@ my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_MSSQL_ODBC_${_}" } qw/DSN USER PA plan skip_all => 'Set $ENV{DBICTEST_MSSQL_ODBC_DSN}, _USER and _PASS to run this test' unless ($dsn && $user); -plan tests => 23; +plan tests => 33; my $schema = DBICTest::Schema->connect($dsn, $user, $pass); @@ -32,7 +33,6 @@ $schema->storage->dbh_do (sub { my ($storage, $dbh) = @_; eval { $dbh->do("DROP TABLE artist") }; $dbh->do(<<'SQL'); - CREATE TABLE artist ( artistid INT IDENTITY NOT NULL, name VARCHAR(100), @@ -40,7 +40,6 @@ CREATE TABLE artist ( charfield CHAR(10) NULL, primary key(artistid) ) - SQL }); @@ -74,13 +73,44 @@ $it->next; is( $it->next->name, "Artist 2", "iterator->next ok" ); is( $it->next, undef, "next past end of resultset ok" ); +# test MONEY type $schema->storage->dbh_do (sub { my ($storage, $dbh) = @_; - eval { $dbh->do("DROP TABLE Owners") }; - eval { $dbh->do("DROP TABLE Books") }; + eval { $dbh->do("DROP TABLE money_test") }; $dbh->do(<<'SQL'); +CREATE TABLE money_test ( + id INT IDENTITY PRIMARY KEY, + amount MONEY NULL +) +SQL +}); + +my $rs = $schema->resultset('Money'); + +my $row; +lives_ok { + $row = $rs->create({ amount => 100 }); +} 'inserted a money value'; + +is $rs->find($row->id)->amount, '100.00', 'money value round-trip'; + +lives_ok { + $row->update({ amount => 200 }); +} 'updated a money value'; + +is $rs->find($row->id)->amount, '200.00', 'updated money value round-trip'; + +lives_ok { + $row->update({ amount => undef }); +} 'updated a money value to NULL'; +is $rs->find($row->id)->amount, undef,'updated money value to NULL round-trip'; +$schema->storage->dbh_do (sub { + my ($storage, $dbh) = @_; + eval { $dbh->do("DROP TABLE Owners") }; + eval { $dbh->do("DROP TABLE Books") }; + $dbh->do(<<'SQL'); CREATE TABLE Books ( id INT IDENTITY (1, 1) NOT NULL, source VARCHAR(100), @@ -93,52 +123,60 @@ CREATE TABLE Owners ( id INT IDENTITY (1, 1) NOT NULL, name VARCHAR(100), ) - SQL }); -$schema->populate ('Owners', [ - [qw/id name /], - [qw/1 wiggle/], - [qw/2 woggle/], - [qw/3 boggle/], - [qw/4 fREW/], - [qw/5 fRIOUX/], - [qw/6 fROOH/], - [qw/7 fRUE/], - [qw/8 fISMBoC/], - [qw/9 station/], - [qw/10 mirror/], - [qw/11 dimly/], - [qw/12 face_to_face/], - [qw/13 icarus/], - [qw/14 dream/], - [qw/15 dyrstyggyr/], -]); - -$schema->populate ('BooksInLibrary', [ - [qw/source owner title /], - [qw/Library 1 secrets0/], - [qw/Library 1 secrets1/], - [qw/Eatery 1 secrets2/], - [qw/Library 2 secrets3/], - [qw/Library 3 secrets4/], - [qw/Eatery 3 secrets5/], - [qw/Library 4 secrets6/], - [qw/Library 5 secrets7/], - [qw/Eatery 5 secrets8/], - [qw/Library 6 secrets9/], - [qw/Library 7 secrets10/], - [qw/Eatery 7 secrets11/], - [qw/Library 8 secrets12/], -]); + +lives_ok ( sub { + $schema->populate ('Owners', [ + [qw/id name /], + [qw/1 wiggle/], + [qw/2 woggle/], + [qw/3 boggle/], + [qw/4 fREW/], + [qw/5 fRIOUX/], + [qw/6 fROOH/], + [qw/7 fRUE/], + [qw/8 fISMBoC/], + [qw/9 station/], + [qw/10 mirror/], + [qw/11 dimly/], + [qw/12 face_to_face/], + [qw/13 icarus/], + [qw/14 dream/], + [qw/15 dyrstyggyr/], + ]); +}, 'populate with PKs supplied ok' ); + +lives_ok ( sub { + $schema->populate ('BooksInLibrary', [ + [qw/source owner title /], + [qw/Library 1 secrets0/], + [qw/Library 1 secrets1/], + [qw/Eatery 1 secrets2/], + [qw/Library 2 secrets3/], + [qw/Library 3 secrets4/], + [qw/Eatery 3 secrets5/], + [qw/Library 4 secrets6/], + [qw/Library 5 secrets7/], + [qw/Eatery 5 secrets8/], + [qw/Library 6 secrets9/], + [qw/Library 7 secrets10/], + [qw/Eatery 7 secrets11/], + [qw/Library 8 secrets12/], + ]); +}, 'populate without PKs supplied ok' ); # -# try a distinct + prefetch on tables with identically named columns +# try a prefetch on tables with identically named columns # +# set quote char - make sure things work while quoted +$schema->storage->_sql_maker->{quote_char} = [qw/[ ]/]; +$schema->storage->_sql_maker->{name_sep} = '.'; + { - # try a ->has_many direction (group_by is not possible on has_many with limit) + # try a ->has_many direction my $owners = $schema->resultset ('Owners')->search ({ 'books.id' => { '!=', undef } }, { @@ -154,37 +192,36 @@ $schema->populate ('BooksInLibrary', [ local $TODO = 'limit past end of resultset problem'; is ($owners->page(3)->all, 2, 'has_many prefetch returns correct number of rows'); is ($owners->page(3)->count, 2, 'has-many prefetch returns correct count'); + is ($owners->page(3)->count_rs->next, 2, 'has-many prefetch returns correct count_rs'); + + # make sure count does not become overly complex FIXME + is_same_sql_bind ( + $owners->page(3)->count_rs->as_query, + '( + SELECT COUNT( * ) + FROM ( + SELECT TOP 3 [me].[id] + FROM [owners] [me] + LEFT JOIN [books] [books] ON [books].[owner] = [me].[id] + WHERE ( [books].[id] IS NOT NULL ) + GROUP BY [me].[id] + ORDER BY [me].[id] DESC + ) [count_subq] + )', + [], + ); } - # make sure count does not become overly complex FIXME - is_same_sql_bind ( - $owners->page(2)->count_rs->as_query, - '( - SELECT COUNT( * ) - FROM ( - SELECT TOP 3 id - FROM ( - SELECT TOP 6 me.id - FROM owners me - LEFT JOIN books books ON books.owner = me.id - WHERE ( books.id IS NOT NULL ) - GROUP BY me.id - ORDER BY me.id ASC - ) AS inner_sel - ORDER BY id DESC - ) count_subq - )', - [], - ); - # try a ->belongs_to direction (no select collapse, group_by should work) my $books = $schema->resultset ('BooksInLibrary')->search ({ 'owner.name' => [qw/wiggle woggle/], }, { distinct => 1, prefetch => 'owner', - order_by => 'name', rows => 2, # 3 results total + order_by => { -desc => 'owner' }, + # there is no sane way to order by the right side of a grouped prefetch currently :( + #order_by => { -desc => 'owner.name' }, }); @@ -195,38 +232,37 @@ $schema->populate ('BooksInLibrary', [ local $TODO = 'limit past end of resultset problem'; is ($books->page(2)->all, 1, 'Prefetched grouped search returns correct number of rows'); is ($books->page(2)->count, 1, 'Prefetched grouped search returns correct count'); + is ($books->page(2)->count_rs->next, 1, 'Prefetched grouped search returns correct count_rs'); + + # make sure count does not become overly complex FIXME + is_same_sql_bind ( + $books->page(2)->count_rs->as_query, + '( + SELECT COUNT( * ) + FROM ( + SELECT TOP 2 [me].[id] + FROM [books] [me] + JOIN [owners] [owner] ON [owner].[id] = [me].[owner] + WHERE ( ( ( [owner].[name] = ? OR [owner].[name] = ? ) AND [source] = ? ) ) + GROUP BY [me].[id], [me].[source], [me].[owner], [me].[title], [me].[price], [owner].[id], [owner].[name] + ORDER BY [me].[id] DESC + ) [count_subq] + )', + [ + [ 'owner.name' => 'wiggle' ], + [ 'owner.name' => 'woggle' ], + [ 'source' => 'Library' ], + ], + ); } - # make sure count does not become overly complex FIXME - is_same_sql_bind ( - $books->page(2)->count_rs->as_query, - '( - SELECT COUNT( * ) - FROM ( - SELECT TOP 2 id - FROM ( - SELECT TOP 4 me.id - FROM books me - JOIN owners owner ON owner.id = me.owner - WHERE ( ( ( owner.name = ? OR owner.name = ? ) AND source = ? ) ) - GROUP BY me.id, me.source, me.owner, me.title, me.price, owner.id, owner.name - ORDER BY me.id ASC - ) AS inner_sel - ORDER BY id DESC - ) count_subq - )', - [ - [ 'owner.name' => 'wiggle' ], - [ 'owner.name' => 'woggle' ], - [ 'source' => 'Library' ], - ], - ); - } # clean up our mess END { - my $dbh = eval { $schema->storage->_dbh }; - $dbh->do('DROP TABLE artist') if $dbh; + if (my $dbh = eval { $schema->storage->_dbh }) { + eval { $dbh->do("DROP TABLE $_") } + for qw/artist money_test Books Owners/; + } } # vim:sw=2 sts=2