X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F55namespaces_cleaned.t;h=e87cab7dfc3f7df4d9f09cdff245857e073ad6a5;hb=fcf32d045;hp=5a5cd63af4d4d46532b53f89c71032e4b83d969e;hpb=e6ff36589c607d5a5a403169f7df73379b93e256;p=dbsrgits%2FDBIx-Class.git diff --git a/t/55namespaces_cleaned.t b/t/55namespaces_cleaned.t index 5a5cd63..e87cab7 100644 --- a/t/55namespaces_cleaned.t +++ b/t/55namespaces_cleaned.t @@ -109,7 +109,7 @@ for my $mod (@modules) { for my $name (keys %all_method_like) { - next if ( DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN() and $name =~ /^carp(?:_unique|_once)?$/ ); + next if ( DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN and $name =~ /^carp(?:_unique|_once)?$/ ); # overload is a funky thing - it is not cleaned, and its imports are named funny next if $name =~ /^\(/; @@ -117,17 +117,10 @@ for my $mod (@modules) { my $gv = svref_2object($all_method_like{$name})->GV; my $origin = $gv->STASH->NAME; - TODO: { - local $TODO; - if ($name =~ /^__CAG_/) { - $TODO = 'CAG does not clean its BEGIN constants'; - } - - is ($gv->NAME, $name, "Properly named $name method at $origin" . ($origin eq $mod - ? '' - : " (inherited by $mod)" - )); - } + is ($gv->NAME, $name, "Properly named $name method at $origin" . ($origin eq $mod + ? '' + : " (inherited by $mod)" + )); next if $seen->{"${origin}:${name}"}++; @@ -154,7 +147,7 @@ for my $mod (@modules) { } } - next if DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN(); + next if DBIx::Class::_ENV_::BROKEN_NAMESPACE_CLEAN; # some common import names (these should never ever be methods) for my $f (qw/carp carp_once carp_unique croak confess cluck try catch finally/) {